From 6f4586199bb524f64486ff293ef041ae95afc7c2 Mon Sep 17 00:00:00 2001 From: Amna <amna.snene@savoirfairelinux.com> Date: Mon, 26 Aug 2024 13:49:27 -0400 Subject: [PATCH] upnp: ignore auto-update when the user releases the mapping Change-Id: I51f20de11398e394228fd4619dffe255ab215ab9 --- src/upnp/upnp_context.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/upnp/upnp_context.cpp b/src/upnp/upnp_context.cpp index 42de87f..e832c65 100644 --- a/src/upnp/upnp_context.cpp +++ b/src/upnp/upnp_context.cpp @@ -378,7 +378,6 @@ UPnPContext::reserveMapping(Mapping& requestedMap) return mapRes; } -// TODO: double-check what the expected behavior is when the mapping has auto-update enabled. void UPnPContext::releaseMapping(const Mapping& map) { @@ -400,7 +399,7 @@ UPnPContext::releaseMapping(const Mapping& map) // Remove it. requestRemoveMapping(mapPtr); - unregisterMapping(mapPtr); + unregisterMapping(mapPtr, true); enforceAvailableMappingsLimits(); }); } -- GitLab