Andreas Traczyk authored 1 year ago and Adrien Béraud committed 1 year ago

https://review.jami.net/c/dhtnet/+/26809 revisited

Change-Id: Ib8e20e6322fd06ca0a2acb25823549e3271ca593

Sébastien Blin authored 1 year ago and Adrien Béraud committed 1 year ago

Else, a deadlock may occurs

jami-daemon#936
Change-Id: Ib4a02845bd0b7e5d482f3fc5f5c8b8a01a50a80f

Change-Id: Icf73d406d749168ff22652b0b27fa241fb2ed047

Amna Snene authored 1 year ago and Sébastien Blin committed 1 year ago

Change-Id: Id200b73da4c35e001b69749bc32ca3dcc5eb989a
GitLab: #14

issue: when clicking on this link from local, it redirects to the github file.
solution: redirect to local file.
pros: it will also helps when clicking the link on gitlab to not be redirected to github.
Change-Id: I2b8cdc83837b003b067d04eb7f42c3fdedc5cb42

Change-Id: Ic2397eee6ea67fc5d0b76ce77bbd8e000f90177c

Change-Id: Ic9bd9a2b570b334cd84652cae97c9a1ffe3350b5

It seems there are scenarios in which the ConnectionInfo is disposed during the on-ready callback, resulting in the TlsSocketEndpoint's callback mutex being locked twice on the same thread.

Change-Id: I401b3c70ba81708e4a3d4ecf3f099f0292c2ff04

Change-Id: Ib7f3ae5a49ee73e4c3c9c97b7ca1e2788d241bf3

Change-Id: Ic24123e329b221f5f1e24d3df6f3cc93649c4591

To check if we're connected with a device

Change-Id: I9d0659c3d6d5e305baabd5c4156a820754bae377

In the else branch, `s` is always an invalid iterator.
Use `us` instead.

Change-Id: Ib517dce22f3bde103f753b325e919f86db299623

Change-Id: I8732dfaab77bc147763b7591d88e8ca476566627

Change-Id: Ia0c3c975961bf96c6db80ed8f5c7b45bdee7e9cb

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I1f32ffe43a51535ec64355186a1c7cc13e6be281

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I30ca8601fa2e221158b28a260bb7893d1ff8aac3

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I18622e6064494c19952ddafc21d81a40da841cc7

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: Iaaee0ed079c8f5d181776a08b8865c9e637d3f29

Change-Id: I03cf7bead8bcf5760d035e32a82ec3412ef6fea9

Change-Id: I4030534348074592b6f2a3ff8c1f8f2cb4438ca3

Change-Id: Ie1338675efb16783a68a344da2a164632c0e088a

Change-Id: I869fcb8903654558c39afa4f9d4aaefecd7cb40a

Change-Id: Idbd2d136cf6725bf198afeb4ebe3284f9a817744

Change-Id: Ifdb26180460343fab1cf39a770d90d924f8ef263

Adrien Béraud authored 1 year ago and Sébastien Blin committed 1 year ago

Change-Id: I4c29a9117414da46bc57af6649763cecea6e6918

Adrien Béraud authored 1 year ago and Sébastien Blin committed 1 year ago

Change-Id: Ie5fe090494e30f99587d048dad709b8ac50a3cef

Change-Id: I46a4563e24f3a427931be886b726a585fe823eff

Change-Id: I8ef7ed0336a02692fb3ec0959f2f7f8891c52808

If a TLS handshake was failing, the device information was not
correctly removed, causing a connection to be detected and further
communications to fail.
So, while monitoring, some connections were stuck in "Connecting TLS".

Moreover, remove waitForReady because it's unused

Change-Id: I8350d7f8731311ab46db78fb26328edc0dcb31dc

Avoids blocking on socket write sequentially,
and prevents locking while blocked on a write.

Change-Id: Ia9e6e0f3e0d73e070f90d988f351d782932a1a07

Change-Id: I93782be5cd93c824d14e7c9871be47ed6527d836

Change-Id: I768da190ea9dc891aba059ab9b44664897a9fffe

Change-Id: I44eca33dc35747eda86cee32be38782cb96d077b

Avoids potential processing ordering issues

Change-Id: I480872ffecb80439620a8442610b845f790b9db6

Allows to better handle new states in the future.

Change-Id: Ie8b28f9776d2c4ce8a45eb02f5af323a2ea37ffd

Change-Id: I71d88e0efbf78009ba003b03d107c0f897dbc485

Change-Id: I5bc6cdc830959dfc37f2b0f620340653ed2342a9

* merge info, waiting and pending maps into DeviceInfo,
  improving consistency of various operations
* DeviceInfo has its own mutex,
  and operations keep a weak pointer to it,
  reducing contention
* DeviceInfoSet encapsulate atomic management of DeviceInfos,
  enforcing proper locking order

Change-Id: I12c107782600355a34d460e7802d92ae9d590993

Prevents the peer from hijacking existing channels,
preventing various issues when collisions occur.

Also mark accepted connections as 'answered', allowing
its removal if shutdown by the server.

Change-Id: Ie91d50b0d518cb6621289233bfda2c289deeed5c

Sadly, this method is async, and can cause really long delay in
shutdown, but at least, avoid to call UPnPFinish before the end
of the download (else this method never returns)

GitLab: #8
Change-Id: I80df3da9b884b93a331aae738eae9a27be898fe2