... → …
wish → want

Change-Id: Iedfd8fcf6cdb56819b80a954d511f83eb2b8e906

ssh → SSH
stun server → STUN server
try → attempt
turn server → TURN server
UPNP → UPnP

Change-Id: Ia31a3baae908850a7e99d50128447f2eb9113df1

ovari authored 4 months ago and Adrien Béraud committed 4 months ago

won't → unable to

Change-Id: I1ce5af3ac16ed364df62d20338507b714a47b913
GitLab: jami-client-qt#1730

platform → platforms

Change-Id: I99a79c2073e4c9a593fd264f75e22e4e1df1afcc
GitLab: jami-client-qt#1730

{can't, won't} → unable to
plateform → platform

Change-Id: I7723ac5ed881572201fb8367f1e5c84c52330888
GitLab: jami-client-qt#1730

Change-Id: I3acce7150d5f21bfdaf6174060e8671086c4f56e

3-character ellipsis ... → 1-character ellipsis …

Change-Id: If14c822aaf7c32a50a5367c26cc2deededebfd90
GitLab: jami-client-qt#1730

Adrien Béraud authored 4 months ago and Adrien Béraud committed 4 months ago

Change-Id: Ied3cc750a1dca7dd14f3ef75ffc8729c09bf7087

* fix: use the same mutex in callback and to wait
* fix: notify with mutex locked
* fix: avoid accessing this from callback, preventing potential use-after-free
* allows to stop waiting for upnp mappings immediately
 when the transport is stopped
* perform single allocation of shared state,
 and free the memory of mutex and cv after mapping completes

Change-Id: I573937d2e8a90b31501a237607bbc7f52942bcea

Change-Id: Ic7c5bf97c9ac159519eea2c265787cf47d378ce7

On Ubuntu/debian, it have happenned that some build have inconsistent
paths like /usr/usr/lib. To avoid this, hard-coded most of the paths
like we are doing in Fedora.

Change-Id: I8c1a3567490e02ac11ec57315bc3a7cc38d02ea0

Cleaned all the dead code in debian/ubuntu post install script.

Change-Id: Idb23b5974e544d704ee9feb753990bf185575ec5

Building dhtnet for ubuntu 24.10 require the addition of libzstd for
compilation to work (linker require it).

Change-Id: I2168a84ee9fde3dc21925f000d5f136ef76fb207

Louis Maillard authored 5 months ago and Adrien Béraud committed 5 months ago

Add dhtnet.spec for RPM build and fedora_40,39 dockerfile for env build.
Fix and changes was required in Cmake instruction in order to build:
- Dependencies can now be built in static mode even with dynamic library
- Remove occurence of INSTALL_DIR path in dhtnet.pc and dnc.service
  but only when option TRIM_PREFIX_PATH is turned On.

Fix and replace previously-reverted review 28703
Replace change id (I2f2161d7c65241a35c4acbcc006ba27bfcc1f176)

Change-Id: I5a80317d83791743ba6ee443fae7f89156e8013b

Change-Id: Ifef17404e31f7478d310179255092d0e17743b16

Only process the callback if it was not already done by the tls
shutdown callback.

Change-Id: Iee9b479100268c4815f40f7b5d51b9db7dbb22cd

Adrien Béraud authored 5 months ago and Adrien Béraud committed 5 months ago

Avoid re-using the same ID from the previous connection attempt,
which prevents various issues, including the new connectionInfo being
destroyed just after the retry by the async shutdown callback
from the previous connection.

Change-Id: I9c9017f7d0b3107dd8311b5066ba558d8c87b053

Adrien Béraud authored 5 months ago and Adrien Béraud committed 5 months ago

* mtx -> mutex
* cbIds_ -> pendingCbs_

Change-Id: Iea5c1ed55efe197024f25adda4860e599bc94892

Louis Maillard authored 6 months ago and Adrien Béraud committed 5 months ago

Upload generated artefacts on nigtly folder and keep the last 10 build
in Jenkins for now. Avoid using the exclude method used before
for artifact and switch to creating a publish/ folder as it's easier
for rsync.

Change-Id: I311a1ef457bb96b8106263e21d5e9abc2a5f43e3

And remove unneeded check added in previous commit

Change-Id: I1b1f946fde02a09c9695b1f092c041fbd9278e06

Change-Id: I3bad2a7673e9faf860a4a34544c51ef2df2d387c

The change made in commit 41d80670 to
prevent a mapping's NotifyCallback from being called more than once
unnecessarily didn't correctly handle the case where the callback is
null. As a result, the callback would sometimes not be called at all in
situations where it should have been.
https://git.jami.net/savoirfairelinux/jami-client-ios/-/issues/410

Change-Id: Icce78210b8be873be244e93e430d8c6123619db9

François-Simon Fauteux-Chapleau authored 6 months ago and Adrien Béraud committed 5 months ago

This patch modifies the Mapping class to prevent a mapping's
NotifyCallback from being called more than once if the mapping's state
hasn't changed (which can cause bugs, cf. the GitLab issue linked
below).

The patch also fixes a race condition in the reserveMapping function
where a mapping reserved by one thread could wrongly appear to still be
available from the perspective of a different thread.

https://git.jami.net/savoirfairelinux/jami-client-ios/-/issues/410

Change-Id: I3784d36ccbb2f278ecc1c2573ac6f36b125f58c1

GitLab: #630
Change-Id: If4aece97b8c2e63d63981a36bafb35523c01d3a6

Theses changes include using underscore instead of dash, to include the
full version name for ubuntu (24 => 24.04) and a refactor of Jenkins to
reduce duplications.

Change-Id: I45eada9d5078e7e973527141c743fe1736e87a1b

Adrien Béraud authored 6 months ago and Adrien Béraud committed 6 months ago

Change-Id: I7154f3adeec0dd09bcfe42fb8adc30891a24bb2f

There was missing documentation on how to use the tools as an DevOps or
SysAdmin. It now explain where to download, how to setup client and
server, as well as basics about security in the tool.

Change-Id: I7271d2dc37aa65459de16d0cf8a5cd41628e13e8

This reverts commit eab419d3.

Reason for revert: should not have been merged

Change-Id: I4d3f4fea0681debf625be0e8e289baf2a236017e

Add dhtnet.spec for RPM build and fedora-40,39 dockerfile for env build.
Fix and changes was required in Cmake instruction in order to build:
- Add `llhttp` and `neddle` library linking when building tools
- `llhttp` liking is disabled by default for debian, enabled for fedora
- Remove occurence of INSTALL_DIR path in dhtnet.pc and dnc.service

Change-Id: I2f2161d7c65241a35c4acbcc006ba27bfcc1f176

We was using jami.net tun server and bootstrap node in docs, config and
even source code as default. To split concerns, DHTNet now have it's
own turn.sfl.io and bootstrap.sfl.io services for demonstration and
public testing purpose. They are still not intended for production use.

Also change default conf to allow anonymous by default.
This is not a security concern as by default we only allow SSH access,
which is secure and restricted by key / password.

Change-Id: Ibcd3607dcd7f46ed21c0ac396fde0459edc2c92e

Add a Jenkinsfile for automation of building artefacts for debian, ubuntu
and following distros.
Jenkins read a build.version file to determine version to build.

We don't just run `extras/packaging/build_package.sh -a` because this
would lead to running unverified shell script from unapproved commit
outside of docker isolation, directly on jenkins server.

Change-Id: I0482aa489272952755b88efefa0674175ca88cdd

In order to support new distribution not using .deb file format,
it should be better to call export folder `artifacts` instead of `debs`.

Change-Id: I21524fe535a4297851d87a66f2000a27efa565cc

Adrien Béraud authored 6 months ago and Adrien Béraud committed 6 months ago

Change-Id: I4f344be3c820b744f442286f8e226f9185fa9cfd

Change-Id: I78c8b85a62172e8304b4bf21d4d3647f17aefbed

Change-Id: I57c29dcf0a0fc54dcd299edd9db1a6d2b363bcf4

Change-Id: Ifb27b9a147d83c144adc996fcae83b123e08fbbc

update Jami docs link to the connection manager.

move the packaging and release section from the Readme to a separate file named packaging.md

Change-Id: If665d5a15cd9237ecff12c572ce6d177c829fabf

Change-Id: I65f7c277e32b71e45f4eaf08be4df4146d823348

8+3 filename → 8.3 filename
be ware → beware
{cannot, can not, can't, could not, couldn't} → unable to
familly → family
file name → filename
informations → information
plateform → platform
trial → attempt
trying to → attempting to
{web-server, webserver} → Web server

Change-Id: I33b1a0091b5af4f0f055bd4c21b2a05a39adbc50
GitLab: jami-client-qt#1730

Amna Snene authored 6 months ago and François-Simon Fauteux-Chapleau committed 6 months ago

This patch fixes a bug where mappings in the FAILED state were
sometimes left in the UPnPContext's mapping list. This is not necessary
and can lead to problems if the list grows too large.

GitLab: #45
Change-Id: I35641880160194be9c29867abb05161fbc7f9376