From de820078485395fd206e7a0a1d564034b069339c Mon Sep 17 00:00:00 2001
From: Alexandre Savard <alexandre.savard@savoirfairelinux.com>
Date: Fri, 26 Oct 2012 15:39:21 -0400
Subject: [PATCH] #17013: No need of switch case in SipCall.setState()
---
.../sflphone/client/SipCall.java | 35 ++-----------------
1 file changed, 3 insertions(+), 32 deletions(-)
diff --git a/src/com/savoirfairelinux/sflphone/client/SipCall.java b/src/com/savoirfairelinux/sflphone/client/SipCall.java
index 55b6d42ca..70bd65b74 100644
--- a/src/com/savoirfairelinux/sflphone/client/SipCall.java
+++ b/src/com/savoirfairelinux/sflphone/client/SipCall.java
@@ -206,41 +206,12 @@ public class SipCall
public void setCallState(int callState) {
mCallInfo.mCallState = callState;
-
+
+ // Check if this call is associated to a view in CallElementList
if(mRowView == null)
return;
- String state;
-
- switch(mCallInfo.mCallState) {
- case CALL_STATE_INCOMING:
- state = "INCOMING";
- break;
- case CALL_STATE_RINGING:
- state = "RINGING";
- break;
- case CALL_STATE_CURRENT:
- state = "CURRENT";
- break;
- case CALL_STATE_HUNGUP:
- state = "HUNGUP";
- break;
- case CALL_STATE_BUSY:
- state = "BUSY";
- break;
- case CALL_STATE_FAILURE:
- state = "FAILURE";
- break;
- case CALL_STATE_HOLD:
- state = "HOLD";
- break;
- case CALL_STATE_UNHOLD:
- state = "UNHOLD";
- break;
- default:
- state = "NULL";
- }
-
+ // Update the state to the view
CallElementView entryView = (CallElementView) mRowView.getTag();
final String CURRENT_STATE_LABEL = " CURRENT STATE: ";
entryView.state.setText(CURRENT_STATE_LABEL + getCallStateString());
--
GitLab