vcard: catch more errors

Change-Id: I07b0e7c27cc778ca8cada7ed08b0cddcd7828b05

ring-android/app/build.gradle

@@ -8,8 +8,8 @@ android {
     defaultConfig {
         minSdkVersion 21
         targetSdkVersion 28
-        versionCode 162
-        versionName "20190525-4"
+        versionCode 163
+        versionName "20190525-5"
     }
 
     sourceSets {

ring-android/app/src/main/java/cx/ring/application/RingApplication.java

@@ -62,6 +62,7 @@ import cx.ring.services.DaemonService;
 import cx.ring.services.DeviceRuntimeService;
 import cx.ring.services.HardwareService;
 import cx.ring.services.PreferencesService;
+import io.reactivex.plugins.RxJavaPlugins;
 
 public abstract class RingApplication extends Application {
     private static final String TAG = RingApplication.class.getSimpleName();
@@ -221,6 +222,8 @@ public abstract class RingApplication extends Application {
         super.onCreate();
         sInstance = this;
 
+        RxJavaPlugins.setErrorHandler(e -> Log.e(TAG, "Unhandled RxJava error", e));
+
         // building injection dependency tree
         mRingInjectionComponent = DaggerRingInjectionComponent.builder()
                 .ringInjectionModule(new RingInjectionModule(this))

ring-android/app/src/main/java/cx/ring/services/NotificationServiceImpl.java

@@ -446,7 +446,7 @@ public class NotificationServiceImpl implements NotificationService {
 
                 setContactPicture(c, builder);
                 notificationManager.notify(notificationId, builder.build());
-            });
+            }, e -> Log.w(TAG,  "error showing notification", e));
         } else {
             NotificationCompat.Builder builder = getRequestNotificationBuilder(account.getAccountID());
             boolean newRequest = false;

ring-android/app/src/main/java/cx/ring/tv/main/MainPresenter.java

@@ -123,7 +123,7 @@ public class MainPresenter extends RootPresenter<MainView> {
                         cd.add(mContactService.observeContact(vm.getAccountId(), vm.getContact())
                                 .subscribeOn(Schedulers.computation())
                                 .observeOn(mUiScheduler)
-                                .subscribe(this::refreshContact));
+                                .subscribe(this::refreshContact, e -> Log.d(TAG, "error loading contact", e)));
                     }
                     mContactDisposable.clear();
                     mContactDisposable.add(cd);
@@ -162,7 +162,7 @@ public class MainPresenter extends RootPresenter<MainView> {
                             Log.d(TAG, "getPendingSubject " + pending.size());
                             ArrayList<TVListViewModel> viewmodel = new ArrayList<>(pending.size());
                             for (Conversation c : pending) {
-                                mContactService.loadContactData(c.getContact()).subscribe();
+                                mContactService.loadContactData(c.getContact()).subscribe(() -> {}, e -> Log.e(TAG, "Can't load contact data"));
                                 viewmodel.add(new TVListViewModel(a.getAccountID(), c.getContact()));
                             }
                             return viewmodel;

ring-android/libringclient/src/main/java/cx/ring/conversation/ConversationPresenter.java

@@ -182,28 +182,28 @@ public class ConversationPresenter extends RootPresenter<ConversationView> {
         Account account = mAccountService.getAccount(mAccountId);
 
         mConversationDisposable.add(c.getSortedHistory()
-                .subscribe(view::refreshView));
+                .subscribe(view::refreshView, e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getCleared()
                 .observeOn(mUiScheduler)
-                .subscribe(view::refreshView));
+                .subscribe(view::refreshView, e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(mContactService.getLoadedContact(c.getAccountId(), c.getContact())
                 .observeOn(mUiScheduler)
-                .subscribe(contact -> initContact(account, mContactRingId, view)));
+                .subscribe(contact -> initContact(account, mContactRingId, view), e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getNewElements()
                 .observeOn(mUiScheduler)
-                .subscribe(view::addElement));
+                .subscribe(view::addElement, e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getUpdatedElements()
                 .observeOn(mUiScheduler)
-                .subscribe(view::updateElement));
+                .subscribe(view::updateElement, e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getRemovedElements()
                 .observeOn(mUiScheduler)
-                .subscribe(view::removeElement));
+                .subscribe(view::removeElement, e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getCalls()
                 .observeOn(mUiScheduler)
-                .subscribe(calls -> updateOngoingCallView()));
+                .subscribe(calls -> updateOngoingCallView(), e -> Log.e(TAG, "Can't update element", e)));
         mConversationDisposable.add(c.getColor()
                 .observeOn(mUiScheduler)
-                .subscribe(view::setConversationColor));
+                .subscribe(view::setConversationColor, e -> Log.e(TAG, "Can't update element", e)));
     }
 
     public void openContact() {

ring-android/libringclient/src/main/java/cx/ring/smartlist/SmartListPresenter.java

@@ -304,7 +304,7 @@ public class SmartListPresenter extends RootPresenter<SmartListView> {
                                 if (mSmartListViewModels.get(i).getContact() == vm.getContact())
                                     mSmartListViewModels.set(i, vm);
                             getView().update(vm);
-                        }));
+                        }, e -> Log.d(TAG, "loadConversations accountSubject onError", e)));
     }
 
     private List<SmartListViewModel> filter(List<SmartListViewModel> list, String query) {

ring-android/libringclient/src/main/java/cx/ring/utils/VCardUtils.java

@@ -31,7 +31,9 @@ import ezvcard.VCardVersion;
 import ezvcard.io.text.VCardWriter;
 import ezvcard.property.FormattedName;
 import ezvcard.property.Uid;
+import io.reactivex.Scheduler;
 import io.reactivex.Single;
+import io.reactivex.schedulers.Schedulers;
 
 public final class VCardUtils {
     public static final String TAG = VCardUtils.class.getSimpleName();
@@ -206,11 +208,9 @@ public final class VCardUtils {
     private static VCard setupDefaultProfile(File filesDir, String accountId) {
         VCard vcard = new VCard();
         vcard.setUid(new Uid(accountId));
-        try {
-            saveLocalProfileToDisk(vcard, accountId, filesDir).subscribe();
-        } catch (Exception e) {
-            Log.e(TAG, "Error while saving vcard", e);
-        }
+        saveLocalProfileToDisk(vcard, accountId, filesDir)
+                .subscribeOn(Schedulers.io())
+                .subscribe(vc -> {}, e -> Log.e(TAG, "Error while saving vcard", e));
         return vcard;
     }
 }