From f5bd757c5e8abe80ccd49c8beea2a5584c961cf6 Mon Sep 17 00:00:00 2001 From: Pierre Duchemin <pierre.duchemin@savoirfairelinux.com> Date: Wed, 30 May 2018 14:26:11 -0400 Subject: [PATCH] Remove unused listener Was previously used to add contact. Avatar is now clickable: it opens conversation. Change-Id: I9e1546fc6a8e6b7464a3e597faf27cf783910db6 --- .../src/main/java/cx/ring/fragments/SmartListFragment.java | 5 ----- .../main/java/cx/ring/viewholders/SmartListViewHolder.java | 3 --- .../src/main/java/cx/ring/smartlist/SmartListPresenter.java | 4 ---- 3 files changed, 12 deletions(-) diff --git a/ring-android/app/src/main/java/cx/ring/fragments/SmartListFragment.java b/ring-android/app/src/main/java/cx/ring/fragments/SmartListFragment.java index af1254ccb..d1107bb5a 100644 --- a/ring-android/app/src/main/java/cx/ring/fragments/SmartListFragment.java +++ b/ring-android/app/src/main/java/cx/ring/fragments/SmartListFragment.java @@ -556,9 +556,4 @@ public class SmartListFragment extends BaseFragment<SmartListPresenter> implemen public void onItemLongClick(SmartListViewModel smartListViewModel) { presenter.conversationLongClicked(smartListViewModel); } - - @Override - public void onPhotoClick(SmartListViewModel smartListViewModel) { - presenter.photoClicked(smartListViewModel); - } } diff --git a/ring-android/app/src/main/java/cx/ring/viewholders/SmartListViewHolder.java b/ring-android/app/src/main/java/cx/ring/viewholders/SmartListViewHolder.java index d6de97878..dd6543df5 100644 --- a/ring-android/app/src/main/java/cx/ring/viewholders/SmartListViewHolder.java +++ b/ring-android/app/src/main/java/cx/ring/viewholders/SmartListViewHolder.java @@ -53,15 +53,12 @@ public class SmartListViewHolder extends RecyclerView.ViewHolder { clickListener.onItemLongClick(smartListViewModel); return true; }); - photo.setOnClickListener(v -> clickListener.onPhotoClick(smartListViewModel)); } public interface SmartListListeners { void onItemClick(SmartListViewModel smartListViewModel); void onItemLongClick(SmartListViewModel smartListViewModel); - - void onPhotoClick(SmartListViewModel smartListViewModel); } } diff --git a/ring-android/libringclient/src/main/java/cx/ring/smartlist/SmartListPresenter.java b/ring-android/libringclient/src/main/java/cx/ring/smartlist/SmartListPresenter.java index a0787b82b..fdb1f815a 100644 --- a/ring-android/libringclient/src/main/java/cx/ring/smartlist/SmartListPresenter.java +++ b/ring-android/libringclient/src/main/java/cx/ring/smartlist/SmartListPresenter.java @@ -190,10 +190,6 @@ public class SmartListPresenter extends RootPresenter<SmartListView> implements getView().displayConversationDialog(smartListViewModel); } - public void photoClicked(SmartListViewModel smartListViewModel) { - // ignored - } - public void quickCallClicked() { if (mCallContact != null) { if (mCallContact.getPhones().size() > 1) { -- GitLab