diff --git a/ring-android/app/src/main/java/cx/ring/client/QRCodeActivity.java b/ring-android/app/src/main/java/cx/ring/client/QRCodeActivity.java index a797722a67a30f8340465c60bf1b7cfd0458ffaf..3020354b3a8ba39561cca6805487d19112cec8c5 100644 --- a/ring-android/app/src/main/java/cx/ring/client/QRCodeActivity.java +++ b/ring-android/app/src/main/java/cx/ring/client/QRCodeActivity.java @@ -22,7 +22,6 @@ package cx.ring.client; import android.content.Context; import android.os.Bundle; -import android.view.View; import com.google.android.material.tabs.TabLayout; @@ -47,36 +46,28 @@ public class QRCodeActivity extends AppCompatActivity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_qrcode); - SectionsPagerAdapter sectionsPagerAdapter = new SectionsPagerAdapter(this, getSupportFragmentManager()); + ViewPager viewPager = findViewById(R.id.view_pager); - viewPager.setAdapter(sectionsPagerAdapter); + viewPager.setAdapter(new SectionsPagerAdapter(this, getSupportFragmentManager())); TabLayout tabs = findViewById(R.id.tabs); tabs.setupWithViewPager(viewPager); Toolbar toolbar = findViewById(R.id.qrToolbar); - setSupportActionBar(toolbar); ActionBar supportActionBar = getSupportActionBar(); - - if (supportActionBar != null) { supportActionBar.setDisplayHomeAsUpEnabled(true); supportActionBar.setDisplayShowHomeEnabled(true); - } - - toolbar.setNavigationOnClickListener((View v) -> - finish()); + toolbar.setNavigationOnClickListener(v -> finish()); } - - public class SectionsPagerAdapter extends FragmentPagerAdapter { - + class SectionsPagerAdapter extends FragmentPagerAdapter { @StringRes private final int[] TAB_TITLES = new int[]{R.string.tab_code, R.string.tab_scan}; private final Context mContext; - public SectionsPagerAdapter(Context context, FragmentManager fm) { + SectionsPagerAdapter(Context context, FragmentManager fm) { super(fm); mContext = context; } @@ -91,7 +82,6 @@ public class QRCodeActivity extends AppCompatActivity { default: return null; } - } @Nullable @@ -102,8 +92,7 @@ public class QRCodeActivity extends AppCompatActivity { @Override public int getCount() { - // Show 2 total pages. - return 2; + return TAB_TITLES.length; } } diff --git a/ring-android/app/src/main/java/cx/ring/share/ShareFragment.java b/ring-android/app/src/main/java/cx/ring/share/ShareFragment.java index 541789d8ffe298a196feede8c46904a6656dd2ac..299ff1017152c8b791bdc4fa97b2058c732b7a04 100644 --- a/ring-android/app/src/main/java/cx/ring/share/ShareFragment.java +++ b/ring-android/app/src/main/java/cx/ring/share/ShareFragment.java @@ -64,9 +64,7 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement @BindString(R.string.share_via) protected String mShareVia; - private String mUriToShow; - private int mQRCodeSize = 0; private boolean isShareLocked = false; @Override @@ -82,15 +80,7 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement @Override public void onViewCreated(@NonNull View view, Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); - setHasOptionsMenu(true); - - mQrImage.addOnLayoutChangeListener((v, left, top, right, bottom, oldLeft, oldTop, oldRight, oldBottom) -> { - mQRCodeSize = mQrImage.getMeasuredWidth(); - - // when view is ready, we search for contact infos to display - presenter.loadContactInformation(); - }); } @Override @@ -104,7 +94,7 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement switch (item.getItemId()) { case R.id.menu_qr_share: if (!isShareLocked) { - shareRingAccount(); + shareAccount(); return true; } else { return false; @@ -115,14 +105,13 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement } @OnClick(R.id.share_button) - public void shareClicked(View view) { + void shareClicked(View view) { if(!isShareLocked) { - shareRingAccount(); + shareAccount(); } } - - public void shareRingAccount() { + private void shareAccount() { if (!TextUtils.isEmpty(mUriToShow)) { Intent sharingIntent = new Intent(Intent.ACTION_SEND); sharingIntent.setType("text/plain"); @@ -140,7 +129,7 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement return; } - if (qrCodeData == null || mQRCodeSize <= 0) { + if (qrCodeData == null) { mQrImage.setVisibility(View.INVISIBLE); mShareInstruction.setText(mShareMessageNoAccount); } else { @@ -152,10 +141,6 @@ public class ShareFragment extends BaseSupportFragment<SharePresenter> implement } mUriToShow = viewModel.getAccountShareUri(); - if (TextUtils.isEmpty(mUriToShow)) { - isShareLocked = true; - } else { - isShareLocked = false; - } + isShareLocked = TextUtils.isEmpty(mUriToShow); } } diff --git a/ring-android/app/src/main/res/layout/activity_qrcode.xml b/ring-android/app/src/main/res/layout/activity_qrcode.xml index 4a9e0a91c60cbbb866492a1d1ffa2086fd216a1f..5a63250d35dc951c3b0cb3c7982b6d62d65dd26d 100644 --- a/ring-android/app/src/main/res/layout/activity_qrcode.xml +++ b/ring-android/app/src/main/res/layout/activity_qrcode.xml @@ -19,7 +19,7 @@ android:layout_weight="1" android:background="?attr/colorPrimary" app:layout_scrollFlags="scroll|enterAlways" - app:popupTheme="@style/AppTheme"></androidx.appcompat.widget.Toolbar> + app:popupTheme="@style/AppTheme" /> <com.google.android.material.tabs.TabLayout android:id="@+id/tabs" diff --git a/ring-android/libringclient/src/main/java/cx/ring/share/SharePresenter.java b/ring-android/libringclient/src/main/java/cx/ring/share/SharePresenter.java index 120a363b30cae03594fc571b8ea85c40452d400c..eece58211b197e6a6793af8c89f8a43fd1019bcd 100644 --- a/ring-android/libringclient/src/main/java/cx/ring/share/SharePresenter.java +++ b/ring-android/libringclient/src/main/java/cx/ring/share/SharePresenter.java @@ -49,9 +49,6 @@ public class SharePresenter extends RootPresenter<GenericView<ShareViewModel>> { .subscribe(this::loadContactInformation)); } - public void loadContactInformation() { - loadContactInformation(new ShareViewModel(mAccountService.getCurrentAccount())); - } private void loadContactInformation(ShareViewModel model) { GenericView<ShareViewModel> view = getView(); if (view != null) {