This commit applies MVP to AccountsManagementFragment

Change-Id: I56e1e3658f41b581feccad3ff8026b56bf7baab2
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1366

Apply MVP to ProfileCreationFragment

Tuleap: #1369
Change-Id: Id4434fb1d663d001350a7c0da51340da284d23a3
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

If a contact has a profile name, we can't see his ringID or username
in the conversation screen. It's a security problem because a profile
name can be changed and is not unique.
Now, the username (or the ringID if it does not exists) is always
displayed in the toolbar.

Tuleap: #1345
Change-Id: I7fbc585eb35e708254d77bb998a31e57078461c1
Reviewed-by: Alexandre Lision <alexandre.lision@savoirfairelinux.com>

Apply MVP to HomeAccountCreationFragment

Tuleap: #1369
Change-Id: Id5217e5ec4eda17d18398388b3f3477afed6a14d
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Refactor BaseFragment to inject directly the presenter and remove
the use of createPresenter

Change-Id: I9371d5494e70a263aaa137b772f9ae85afbad3f0
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Move AccountEditionActivity to account package
Add a AccountEditionPresenter
Remove AccountCallbacks and link with Activity from all fragments.
AccountID is passed from start arguments and AccountService is used to
access and display account information

Change-Id: Ibf772b86707394ec68dd8182091acc53c0b9530d
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Aline Bonnet authored 7 years ago and Guillaume Roguez committed 7 years ago

Change-Id: Ib38b4d333218805a741d87b80eee2955558ded50
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Due to refactor, calls oldState and newState were always the same

Change-Id: Id728d3f8a732d6ee1f8a22355a441dddad41bc82
Reviewed-by: Alexandre Lision <alexandre.lision@savoirfairelinux.com>
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Change-Id: I563283a525b683dccd30ccb110a940ce2f73493a
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

* use new Android SDK tools
* download NDK using sdkmanager
* don't install platform-tools (adb, fastboot...),
  unused to build APKs
* install gaz-preprocessor, used by ffmpeg
  to build ASM code for armv7

Change-Id: I1e2973c18d07dfd3dfee9a49632fe495441e3703
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Third-party android-apt isn't supported anymore and its features
have been integrated in the Android gradle plugin.

Remove the android-apt and replace with built-in features.

Change-Id: If60e597e961eae5a34baf5dc9142e42e6d106be4
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Currently, it is possible to set the order of accounts or codecs in the
accounts management. This commit removes this functionality because
it is useless and not used.

Change-Id: If5f40ee13df098f1d8e5425425954f9ec3c794f7
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Change-Id: Idda4ebd3ba24e0817746f4f4c59e2dc081b2507e

This commit removes all files and functions not used in the app module

Change-Id: I8447bab05adafb41b7eec9720672e615c09bce51
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

This commit removes all files or entries not used in the resources.

Change-Id: I2f9eb86520e3e7dc50d148fe9e926f157fa8cd41
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Tuleap: #1367
Change-Id: Ib31f7211ece23f18e2dc1553d807c7eca65bd593

Remove broadcastreceiver from LocalService and change target class to
DRingService for ACTION_CONV_READ and ACTION_CONV_ACCEPT

Tuleap: #1367
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Change-Id: I5658e90704957860f56c1f780b38ed72d259fe29

homeActivity does not need the LocalService to start anymore.

Tuleap: #1367
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Change-Id: I50ea0b054c505b0028b3181e4e3cac01fb6bbc01

System contacts changes must be listened to from DRingService since we
are getting rid of the LocalService

Tuleap: #1367
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Change-Id: Ica563a56eeddf0c504fbee34828f2894c6efca2c

Remove unused lrucache, getters and public interface getRemoteService

Tuleap: #1367
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Change-Id: I788b46113acf8bbf681774e81642758ca95fd305

Refactor CallFragment by adding MVP model, moving video management from
RingApplication to HardwareServiceImpl and removing use of
VideoCallbackManager

Change-Id: Ie75a0d33fa138590911d19d113df362ade29b9f4
Reviewed-by: Alexandre Lision <alexandre.lision@savoirfairelinux.com>
Tuleap: #1360

Change-Id: I9b593c99c5cce407adf3a7038eab5b28ce3f5ac9
Reviewed-by: Alexandre Lision <alexandre.lision@savoirfairelinux.com>

When we delete a system contact by clicking on the photo in the
smartlist and then we restart the application, the smartlist does not
loaded because the contact is null.

Checks are added to fixes this problem.

Change-Id: Iff0ffbb6c6ef99e6051e14f288bc1bb709a2f1d5
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

When there is an incoming call, the smartlist displays the message
"current call" before that the call transaction is terminated. This
is caused by two problems:
- callStateChanged signals are received before the incomingCall signal
- the SipCall object is duplicated

This commit blocks the callStateChanged signals received before the
incomingCall signal to prevents the SipCall object to be duplicate and
fixes the incoming state in the SipCall model.

Change-Id: I0d199ba3eaea4617651fb62f92eec708ea3524aa
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1565

With a Ring account, when we click on the blacklist and then on the
advanced settings, the summary and advanced settings fragments are
overlay. This commit fixes this behavior.

Change-Id: I88a8e2116d2ef8a66a4e8d8bbb5ec86e37803f32
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1588

This commit links the argon2 library to use it in the daemon.

Change-Id: I79eb188ae818ac6e7a971c99bd6a2e2e57c4a1a4
Reviewed-by: Alexandre Lision <alexandre.lision@savoirfairelinux.com>

When we receive a text message, a notification is displayed even if
the conversation is opened. This commit fixes this behavior.

Change-Id: I1c7d50a748ba0d3f2165c4a54d69580bd882e427
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Fix an existing method not displaying the username correctly whereas
the right value is returned by the service

Tuleap: #1345
Change-Id: I7c1857ed30decc2ac7c3258cd0c066dac4cec9ff
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Change-Id: I1c91e1d489487275414a34fcc3322ab835dfa942

Commit 776607c2 introduced a regression on the notification actions.
Restore the old behaviour for now.

Change-Id: I66ae15a12a8911659ec3e947df21fe0cc5d5ab9f
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

When we search a contact and we then click on the back button, the menu
icons desappears. Now, the items are always showed to fix this behavior

Change-Id: I723143710d23ab898291f9e69a5b5366d437db19
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1566

There was a visual desynchronisation between the actual network state
and what was visible to the user. We now refresh the connectivity state
display of the smart list every time an acocunt state changes

The LocalService BroadcastReceiver has been moved to the DRingService.
Most of its actions have been removed since they have been reimplemented
by low level services.

SharedPreferenceService has been renamed to PreferencesService since
SharedPreferences are an Android notion.

Tuleap: #1568
Change-Id: Ic002d8ccb6bf55c0fcaa1ca381b7a35a7d5b465f
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Change-Id: I5917043f26dddea493334291aa12b5e3a2de3c1e

Change-Id: I2b6d0cbc04790ee6ec89e513952cb9b0f67902ea
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

Use DiffUtils to manage change in SmartListFragment adapter

Tuleap: #1374
Change-Id: I0872c9178c7fd9062d57287e61c4a2a650c7c393
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>

This commit adds two missing elements on the about screen:
- a short description of Ring
- the authors and artists list

Change-Id: Id141bfa77378449b08d165a7b32688fe34f45f19
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1574

The incomingTrustRequest signal is received whenever the daemon starts
and we receive a new trust request. This commit adds functions to save
and load the ringID of trust requests in the shared preferences. A
notification is displayed only the first time.

Change-Id: Id9866e52bf0c1b4754630848612e494f8a97ca99
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1528

When we receive a incoming call, the call indication is displayed on
the conversation screen before the call transaction is completed.
This commit adds a check on the call status to fix this problem.

Change-Id: If3cec95d3ac9670b8b2102ffa4c9bde68733846a
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>
Tuleap: #1565

Change-Id: Ic31458fdd90716b88dc105947c0e32fa147a76a9
Reviewed-by: Hadrien De Sousa <hadrien.desousa@savoirfairelinux.com>

Unit testing does not need to run on an emulator or Android device. It
can be setup easily and run on each commit
This commit adds a couple of tests on libringclient. More tests should
be added on different services or on the app module.

Tuleap: #1364
Change-Id: Ib57aa824f3c414ecfec50b3edc991d0314eb2b8f
Reviewed-by: Aline Bonnet <aline.bonnet@savoirfairelinux.com>