- 22 Jan, 2021 1 commit
-
-
Sébastien Blin authored
Change-Id: I2078783925c625136923a32b51682832273373b3
-
- 17 Jan, 2020 1 commit
-
-
Sébastien Blin authored
Change-Id: Ia585c297e1d1626bbee43defa606192391fade8e
-
- 02 Jan, 2019 1 commit
-
-
Sébastien Blin authored
Change-Id: I5ce8f86371ac870a0be34098473f88c71214ff3d
-
- 01 May, 2018 1 commit
-
-
Before: - RingMainWindow has an unique_ptr to an AccountContainer accountContainer_. - each view / secondary class has its own *copy* of the account container pointer (given by ringmainwindow using accountContainer_.get()). - each time the reference to the struct Info is updated, accountContainer_ has to be reset()-ed and and the account container re-created by the RingMainWindow. This makes *all* copies of the account container pointer invalid (hence all view / secondary classes trying to access the account container before getting updated perform use-after-free / NULL pointer dereference). - These copies have to be manually updated ! (well, currently they are not updated at all) After: - RingMainWindow has a pointer to a struct Info from LRC. - Each view / secondary class has a pointer pointing to the struct Info pointer of RingMainWindow - Each time the reference to the struct Info is updated, the RingMainWindow updates its pointer. Since secondary classes and views hold a pointer to this pointer, they are automatically updated and there is no dangling pointer anymore. This requires no lrc side changes. Change-Id: I1329721920a3d42ad623f9fd7202b43700713eed Reviewed-by:
Sebastien Blin <sebastien.blin@savoirfairelinux.com> Reviewed-by:
Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>
-
- 31 Jan, 2018 1 commit
-
-
Change-Id: Ifb26147e6faf37f5ac4f5ffac582ee069902d382 Reviewed-by:
Olivier Soldano <olivier.soldano@savoirfairelinux.com>
-
- 16 Oct, 2017 1 commit
-
-
Sébastien Blin authored
This class will replace contactpopupmenu to use the new lrc. Change-Id: I4fefd530484288f03a0fd0df7d1ccf7df6f71ea9
-