From 85e35eec4056dea87636323e496a4d0e3d49a28d Mon Sep 17 00:00:00 2001 From: Alexender White <joshtech147@gmail.com> Date: Wed, 5 Feb 2025 14:55:18 -0500 Subject: [PATCH] accessibility: account creation Change-Id: Ibf9bcd0ee1fbffeb7478940f39097d8046bc2182 --- Ring/Ring/Constants/Generated/Strings.swift | 6 ++++++ .../Ring/Features/Walkthrough/Views/CreateAccountView.swift | 1 + Ring/Ring/Features/Walkthrough/Views/ProfileView.swift | 3 +++ Ring/Ring/Resources/en.lproj/Localizable.strings | 3 +++ 4 files changed, 13 insertions(+) diff --git a/Ring/Ring/Constants/Generated/Strings.swift b/Ring/Ring/Constants/Generated/Strings.swift index 3440e3a20..4891ec42b 100644 --- a/Ring/Ring/Constants/Generated/Strings.swift +++ b/Ring/Ring/Constants/Generated/Strings.swift @@ -33,6 +33,12 @@ internal enum L10n { internal static let aboutJamiTitle = L10n.tr("Localizable", "accessibility.aboutJamiTitle", fallback: "About Jami") /// Close internal static let close = L10n.tr("Localizable", "accessibility.close", fallback: "Close") + /// Enter a username to verify if it's available + internal static let createAccountVerifyUsernamePrompt = L10n.tr("Localizable", "accessibility.createAccountVerifyUsernamePrompt", fallback: "Enter a username to verify if it's available") + /// Profile picture + internal static let profilePicturePicker = L10n.tr("Localizable", "accessibility.profilePicturePicker", fallback: "Profile picture") + /// Double-tap to take a picture or select a picture from the library + internal static let profilePicturePickerHint = L10n.tr("Localizable", "accessibility.profilePicturePickerHint", fallback: "Double-tap to take a picture or select a picture from the library") /// Add account internal static let smartListAddAccount = L10n.tr("Localizable", "accessibility.smartListAddAccount", fallback: "Add account") /// Your current account is %@ diff --git a/Ring/Ring/Features/Walkthrough/Views/CreateAccountView.swift b/Ring/Ring/Features/Walkthrough/Views/CreateAccountView.swift index e7933756c..2e7ecd7de 100644 --- a/Ring/Ring/Features/Walkthrough/Views/CreateAccountView.swift +++ b/Ring/Ring/Features/Walkthrough/Views/CreateAccountView.swift @@ -169,6 +169,7 @@ struct CreateAccountView: View { Text("valid name") .foregroundColor(.clear) .font(.footnote) + .accessibilityLabel(L10n.Accessibility.createAccountVerifyUsernamePrompt) } else { Text(viewModel.usernameValidationState.message) .foregroundColor(Color(viewModel.usernameValidationState.textColor)) diff --git a/Ring/Ring/Features/Walkthrough/Views/ProfileView.swift b/Ring/Ring/Features/Walkthrough/Views/ProfileView.swift index 0226631b6..5da80c8c5 100644 --- a/Ring/Ring/Features/Walkthrough/Views/ProfileView.swift +++ b/Ring/Ring/Features/Walkthrough/Views/ProfileView.swift @@ -68,6 +68,9 @@ struct ProfileView: View { .foregroundColor(.white) .padding(8) } + .accessibilityLabel(L10n.Accessibility.profilePicturePicker) + .accessibilityHint(L10n.Accessibility.profilePicturePickerHint) + }) .actionSheet(isPresented: $showingImagePicker) { ActionSheet( diff --git a/Ring/Ring/Resources/en.lproj/Localizable.strings b/Ring/Ring/Resources/en.lproj/Localizable.strings index 1b755352c..772d6f082 100644 --- a/Ring/Ring/Resources/en.lproj/Localizable.strings +++ b/Ring/Ring/Resources/en.lproj/Localizable.strings @@ -512,3 +512,6 @@ "accessibility.smartListAddAccount" = "Add account"; "accessibility.aboutJamiTitle" = "About Jami"; "accessibility.welcomeToJamiTitle" = "Welcome to Jami"; +"accessibility.createAccountVerifyUsernamePrompt" = "Enter a username to verify if it's available"; +"accessibility.profilePicturePicker" = "Profile picture"; +"accessibility.profilePicturePickerHint" = "Double-tap to take a picture or select a picture from the library"; -- GitLab