From 6c8a5d7bc63b46c953942a7da44b19565e6424f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Blin?=
<sebastien.blin@savoirfairelinux.com>
Date: Tue, 11 Oct 2022 09:33:28 -0400
Subject: [PATCH] conversationmodel: fix crash if no interaction
Change-Id: Id50f7b2598e0cff7ca75f5fca13473702da5c207
---
src/libclient/conversationmodel.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libclient/conversationmodel.cpp b/src/libclient/conversationmodel.cpp
index 10e069857..fac188aa6 100644
--- a/src/libclient/conversationmodel.cpp
+++ b/src/libclient/conversationmodel.cpp
@@ -2344,7 +2344,9 @@ ConversationModelPimpl::slotConversationLoaded(uint32_t requestId,
if (conversation.lastMessageUid.isEmpty() && !conversation.allMessagesLoaded
&& messages.size() != 0) {
if (conversation.interactions->size() > 0) {
- QString newLast = conversation.interactions->rbegin()->first;
+ QString newLast;
+ if (conversation.interactions->size() > 0)
+ newLast = conversation.interactions->rbegin()->first;
if (newLast == oldLast && !newLast.isEmpty()) { // [[unlikely]] in c++20
qCritical() << "Loading loop detected for " << conversationId << "(" << newLast
<< ")";
--
GitLab