From 7659080b345c074482a295bc6d6a6d8c5b9a5ea7 Mon Sep 17 00:00:00 2001
From: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>
Date: Tue, 14 Jan 2025 13:39:21 -0500
Subject: [PATCH] crashpad: increase timeout for crashpad submission
Recent testing with a Windows 10 machine has shown that the crashpad
submission timeout is too short. This commit increases the timeout to
10 seconds, as around 5 seconds has been observed in practice.
Gitlab: #1454
Change-Id: I557a414ea371bd94a42696a835370068867c99dc
---
src/app/crashreportclients/crashpad.cpp | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/app/crashreportclients/crashpad.cpp b/src/app/crashreportclients/crashpad.cpp
index c9788842..a11347c9 100644
--- a/src/app/crashreportclients/crashpad.cpp
+++ b/src/app/crashreportclients/crashpad.cpp
@@ -281,10 +281,12 @@ CrashPadClient::uploadLastReport()
return;
}
- // Wait up to 3 seconds (~1.5s observed on Windows) for the report to be uploaded.
- const int maxAttempts = 20;
+ // Wait up to 10 seconds for the report to be uploaded.
+ // Around 5s has been observed running the submission server locally when the client
+ // is on Windows.
+ const int maxAttempts = 40;
int attempts = 0;
- auto timeout = std::chrono::milliseconds(150);
+ auto timeout = std::chrono::milliseconds(250);
C_INFO << "Waiting for report to be uploaded";
while (attempts++ < maxAttempts) {
--
GitLab