From b34b8cf5230f77570f4cf39018b7888dd04d003c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Blin?=
<sebastien.blin@savoirfairelinux.com>
Date: Wed, 1 Dec 2021 14:42:26 -0500
Subject: [PATCH] accessibility: make button readable by screen readers
GitLab: #601
Change-Id: Ic60d035776c5a3ae9f1e6ee93b283c7c422d39f5
---
src/commoncomponents/MaterialButton.qml | 4 ++++
src/commoncomponents/PushButton.qml | 4 ++++
src/mainview/components/SmartListItemDelegate.qml | 4 ++++
src/settingsview/components/ToggleSwitch.qml | 4 ++++
4 files changed, 16 insertions(+)
diff --git a/src/commoncomponents/MaterialButton.qml b/src/commoncomponents/MaterialButton.qml
index c1e4570c5..72a45917a 100644
--- a/src/commoncomponents/MaterialButton.qml
+++ b/src/commoncomponents/MaterialButton.qml
@@ -58,6 +58,10 @@ Button {
focusPolicy: Qt.TabFocus
+ Accessible.role: Accessible.Button
+ Accessible.name: root.text
+ Accessible.description: toolTipText
+
MaterialToolTip {
id: toolTip
diff --git a/src/commoncomponents/PushButton.qml b/src/commoncomponents/PushButton.qml
index 555f1bb59..ad28ae329 100644
--- a/src/commoncomponents/PushButton.qml
+++ b/src/commoncomponents/PushButton.qml
@@ -79,6 +79,10 @@ AbstractButton {
hoverEnabled: true
focusPolicy: Qt.TabFocus
+ Accessible.role: Accessible.Button
+ Accessible.name: buttonText
+ Accessible.description: toolTipText
+
MaterialToolTip {
id: toolTip
diff --git a/src/mainview/components/SmartListItemDelegate.qml b/src/mainview/components/SmartListItemDelegate.qml
index 95af16d0e..6797e4cc7 100644
--- a/src/mainview/components/SmartListItemDelegate.qml
+++ b/src/mainview/components/SmartListItemDelegate.qml
@@ -142,6 +142,10 @@ ItemDelegate {
}
}
}
+
+ Accessible.role: Accessible.Button
+ Accessible.name: Title === undefined? "" : Title
+ Accessible.description: LastInteraction === undefined? "" : LastInteraction
}
background: Rectangle {
diff --git a/src/settingsview/components/ToggleSwitch.qml b/src/settingsview/components/ToggleSwitch.qml
index 4024650c8..2a6e0bb0c 100644
--- a/src/settingsview/components/ToggleSwitch.qml
+++ b/src/settingsview/components/ToggleSwitch.qml
@@ -66,6 +66,10 @@ RowLayout {
ToolTip.visible: hovered && (tooltipText.length > 0)
ToolTip.text: tooltipText
+ Accessible.role: Accessible.Button
+ Accessible.name: root.labelText
+ Accessible.description: root.tooltipText
+
onToggled: {
switchToggled()
}
--
GitLab