From c99d4967c68fbda4b2113528cffd4a92a8e8453e Mon Sep 17 00:00:00 2001 From: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com> Date: Wed, 5 Oct 2022 15:58:05 -0400 Subject: [PATCH] accountwizard: remove some useless parameters Change-Id: I19a26ef9ea3d58565ca2e62f1b75ff8c119abdee GitLab: #847 --- src/app/accountadapter.cpp | 11 +++-- src/app/accountadapter.h | 4 +- src/app/wizardviewstepmodel.cpp | 71 ++++++++++++++++----------------- 3 files changed, 40 insertions(+), 46 deletions(-) diff --git a/src/app/accountadapter.cpp b/src/app/accountadapter.cpp index e7610a922..59ee75a8a 100644 --- a/src/app/accountadapter.cpp +++ b/src/app/accountadapter.cpp @@ -97,16 +97,14 @@ AccountAdapter::connectFailure() } void -AccountAdapter::createJamiAccount(QString registeredName, - const QVariantMap& settings, - bool isCreating) +AccountAdapter::createJamiAccount(const QVariantMap& settings) { + auto registeredName = settings["registeredName"].toString(); Utils::oneShotConnect( &lrcInstance_->accountModel(), &lrc::api::AccountModel::accountAdded, - [this, registeredName, settings, isCreating](const QString& accountId) { + [this, registeredName, settings](const QString& accountId) { lrcInstance_->accountModel().setAvatar(accountId, settings["avatar"].toString()); - Utils::oneShotConnect(&lrcInstance_->accountModel(), &lrc::api::AccountModel::accountDetailsChanged, [this](const QString& accountId) { @@ -127,6 +125,7 @@ AccountAdapter::createJamiAccount(QString registeredName, registeredNameSavedConnection_ = connect(&lrcInstance_->accountModel(), &lrc::api::AccountModel::profileUpdated, + this, [this, addedAccountId = accountId](const QString& accountId) { if (addedAccountId == accountId) { Q_EMIT lrcInstance_->accountListChanged(); @@ -361,4 +360,4 @@ AccountAdapter::setArchivePasswordAsync(const QString& accountID, const QString& config.archivePassword = password; lrcInstance_->accountModel().setAccountConfig(accountID, config); }); -} \ No newline at end of file +} diff --git a/src/app/accountadapter.h b/src/app/accountadapter.h index a582a056c..f8efa6db0 100644 --- a/src/app/accountadapter.h +++ b/src/app/accountadapter.h @@ -56,9 +56,7 @@ public: Q_INVOKABLE void changeAccount(int row); // Create normal Jami account, SIP account and JAMS accounts. - Q_INVOKABLE void createJamiAccount(QString registeredName, - const QVariantMap& settings, - bool isCreating); + Q_INVOKABLE void createJamiAccount(const QVariantMap& settings); Q_INVOKABLE void createSIPAccount(const QVariantMap& settings); Q_INVOKABLE void createJAMSAccount(const QVariantMap& settings); diff --git a/src/app/wizardviewstepmodel.cpp b/src/app/wizardviewstepmodel.cpp index e92aa9914..f5e2cbcfe 100644 --- a/src/app/wizardviewstepmodel.cpp +++ b/src/app/wizardviewstepmodel.cpp @@ -32,21 +32,24 @@ WizardViewStepModel::WizardViewStepModel(LRCInstance* lrcInstance, { reset(); - connect(accountAdapter_, &AccountAdapter::accountAdded, [this](QString accountId, int index) { - accountAdapter_->changeAccount(index); + connect(accountAdapter_, + &AccountAdapter::accountAdded, + this, + [this](QString accountId, int index) { + accountAdapter_->changeAccount(index); - auto accountCreationOption = get_accountCreationOption(); - if (accountCreationOption == AccountCreationOption::ConnectToAccountManager - || accountCreationOption == AccountCreationOption::CreateSipAccount) { - Q_EMIT closeWizardView(); - reset(); - } else if (accountCreationOption != AccountCreationOption::None) { - Q_EMIT closeWizardView(); - reset(); - } + auto accountCreationOption = get_accountCreationOption(); + if (accountCreationOption == AccountCreationOption::ConnectToAccountManager + || accountCreationOption == AccountCreationOption::CreateSipAccount) { + Q_EMIT closeWizardView(); + reset(); + } else if (accountCreationOption != AccountCreationOption::None) { + Q_EMIT closeWizardView(); + reset(); + } - Q_EMIT accountIsReady(accountId); - }); + Q_EMIT accountIsReady(accountId); + }); } void @@ -64,36 +67,30 @@ void WizardViewStepModel::nextStep() { auto accountCreationOption = get_accountCreationOption(); - if (accountCreationOption == AccountCreationOption::None) + if (get_mainStep() == MainSteps::Initial + || accountCreationOption == AccountCreationOption::None) { return; + } - switch (get_mainStep()) { - case MainSteps::NameRegistration: - case MainSteps::AccountCreation: { - switch (get_accountCreationOption()) { - case AccountCreationOption::CreateJamiAccount: - case AccountCreationOption::CreateRendezVous: - case AccountCreationOption::ImportFromBackup: - case AccountCreationOption::ImportFromDevice: { - accountAdapter_->createJamiAccount(get_accountCreationInfo()["registeredName"].toString(), - get_accountCreationInfo(), - false); - break; - } - case AccountCreationOption::ConnectToAccountManager: { - accountAdapter_->createJAMSAccount(get_accountCreationInfo()); - break; - } - case AccountCreationOption::CreateSipAccount: { - accountAdapter_->createSIPAccount(get_accountCreationInfo()); - break; - } - } + switch (accountCreationOption) { + case AccountCreationOption::CreateJamiAccount: + case AccountCreationOption::CreateRendezVous: + case AccountCreationOption::ImportFromBackup: + case AccountCreationOption::ImportFromDevice: { + accountAdapter_->createJamiAccount(get_accountCreationInfo()); break; } - default: + case AccountCreationOption::ConnectToAccountManager: { + accountAdapter_->createJAMSAccount(get_accountCreationInfo()); + break; + } + case AccountCreationOption::CreateSipAccount: { + accountAdapter_->createSIPAccount(get_accountCreationInfo()); break; } + default: + return; + } } void -- GitLab