positionmanager: fix signature

Change-Id: I68b830eeb775ed043c617db838a5160213152720
GitLab: #1194

src/app/positionmanager.cpp

@@ -93,7 +93,7 @@ PositionManager::isConvSharingPosition(const QString& accountId, const QString&
 }
 
 void
-PositionManager::loadPreviousLocations(QString& accountId)
+PositionManager::loadPreviousLocations(const QString& accountId)
 {
     for (auto it = objectListSharingUris_.begin(); it != objectListSharingUris_.end(); it++) {
         if (it.key().first != accountId) {
@@ -112,7 +112,7 @@ PositionManager::loadPreviousLocations(QString& accountId)
 }
 
 QString
-PositionManager::getmapTitle(QString& accountId, QString convId)
+PositionManager::getmapTitle(const QString& accountId, const QString& convId)
 {
     if (!convId.isEmpty() && !accountId.isEmpty()) {
         return lrcInstance_->getAccountInfo(accountId).conversationModel->title(convId);
@@ -180,7 +180,7 @@ PositionManager::onWatchdogTimeout()
 }
 
 void
-PositionManager::sharePosition(int maximumTime, QString accountId, QString convId)
+PositionManager::sharePosition(int maximumTime, const QString& accountId, const QString& convId)
 {
     try {
         if (settingsManager_->getValue(Settings::Key::PositionShareDuration) != 0)
@@ -193,7 +193,7 @@ PositionManager::sharePosition(int maximumTime, QString accountId, QString convI
 }
 
 void
-PositionManager::stopSharingPosition(QString accountId, const QString convId)
+PositionManager::stopSharingPosition(const QString& accountId, const QString& convId)
 {
     QString stopMsg;
     PositionKey key = qMakePair(accountId, convId);
@@ -249,7 +249,7 @@ PositionManager::sendStopMessage(QString accountId, const QString convId)
 }
 
 void
-PositionManager::unPinMap(QString key)
+PositionManager::unPinMap(const QString& key)
 {
     QMutexLocker lk(&mapStatusMutex_);
     if (mapStatus_.find(key) != mapStatus_.end()) {
@@ -262,7 +262,7 @@ PositionManager::unPinMap(QString key)
 }
 
 void
-PositionManager::pinMap(QString key)
+PositionManager::pinMap(const QString& key)
 {
     QMutexLocker lk(&mapStatusMutex_);
     if (mapStatus_.find(key) != mapStatus_.end()) {
@@ -280,7 +280,7 @@ PositionManager::pinMap(QString key)
 }
 
 void
-PositionManager::setMapInactive(const QString key)
+PositionManager::setMapInactive(const QString& key)
 {
     QMutexLocker lk(&mapStatusMutex_);
     if (mapStatus_.find(key) != mapStatus_.end()) {
@@ -296,7 +296,7 @@ PositionManager::setMapInactive(const QString key)
 }
 
 void
-PositionManager::setMapActive(QString key)
+PositionManager::setMapActive(const QString& key)
 {
     if (mapStatus_.find(key) == mapStatus_.end()) {
         mapStatus_.insert(key, false);

src/app/positionmanager.h

@@ -73,12 +73,12 @@ protected:
     void sendStopMessage(QString accountId = "", const QString convId = "");
 
     Q_INVOKABLE void connectAccountModel();
-    Q_INVOKABLE void pinMap(QString key);
-    Q_INVOKABLE void unPinMap(QString key);
-    Q_INVOKABLE void setMapActive(QString key);
-    Q_INVOKABLE void setMapInactive(const QString key);
-    Q_INVOKABLE void sharePosition(int maximumTime, QString accountId, QString convId);
-    Q_INVOKABLE void stopSharingPosition(QString accountId = "", const QString convId = "");
+    Q_INVOKABLE void pinMap(const QString& key);
+    Q_INVOKABLE void unPinMap(const QString& key);
+    Q_INVOKABLE void setMapActive(const QString& key);
+    Q_INVOKABLE void setMapInactive(const QString& key);
+    Q_INVOKABLE void sharePosition(int maximumTime, const QString& accountId, const QString& convId);
+    Q_INVOKABLE void stopSharingPosition(const QString& accountId = "", const QString& convId = "");
 
     Q_INVOKABLE void startPositioning();
     Q_INVOKABLE void stopPositioning();
@@ -86,8 +86,8 @@ protected:
     Q_INVOKABLE bool isPositionSharedToConv(const QString& accountId, const QString& convUid);
     Q_INVOKABLE bool isConvSharingPosition(const QString& accountId, const QString& convUri);
 
-    Q_INVOKABLE void loadPreviousLocations(QString& accountId);
-    Q_INVOKABLE QString getmapTitle(QString& accountId, QString convId = "");
+    Q_INVOKABLE void loadPreviousLocations(const QString& accountId);
+    Q_INVOKABLE QString getmapTitle(const QString& accountId, const QString& convId = "");
 
 private Q_SLOTS:
     void onPositionErrorReceived(const QString error);