Failure to build latest release with missing trace-tools.h

I’m trying to build latest release from yesterday, jami-daemon was built at 72a7d2339a1ba9bb1cf356f19c28deeb2f9be76e using meson (https://github.com/archlinux/svntogit-community/blob/packages/jami-daemon/trunk/PKGBUILD), but jami-client-qt at 1a14fd27 fails to build:

In file included from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/instancemanager_wrap.h:30,
                 from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/instancemanager.cpp:20:
/usr/include/jami/jami.h:33:10: fatal error: trace-tools.h: No such file or directory
   33 | #include "trace-tools.h"
      |          ^~~~~~~~~~~~~~~

In file included from /usr/include/jami/plugin_manager_interface.h:23,
                 from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/pluginmanager_wrap.h:31,
                 from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/pluginmanager.cpp:19:
/usr/include/jami/jami.h:33:10: fatal error: trace-tools.h: No such file or directory
   33 | #include "trace-tools.h"
      |          ^~~~~~~~~~~~~~~

In file included from /usr/include/jami/videomanager_interface.h:24,
                 from /build/jami-qt/src/build/src/libclient/qtwrapper/qtwrapper_autogen/EWIEGA46WW/../../../../../../jami-client-qt/src/libclient/qtwrapper/videomanager_wrap.h:37,
                 from /build/jami-qt/src/build/src/libclient/qtwrapper/qtwrapper_autogen/EWIEGA46WW/moc_videomanager_wrap.cpp:10,
                 from /build/jami-qt/src/build/src/libclient/qtwrapper/qtwrapper_autogen/mocs_compilation.cpp:2:
/usr/include/jami/jami.h:33:10: fatal error: trace-tools.h: No such file or directory
   33 | #include "trace-tools.h"
      |          ^~~~~~~~~~~~~~~

In file included from /usr/include/jami/videomanager_interface.h:24,
                 from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/videomanager_wrap.h:37,
                 from /build/jami-qt/src/jami-client-qt/src/libclient/qtwrapper/videomanager_wrap.cpp:19:
/usr/include/jami/jami.h:33:10: fatal error: trace-tools.h: No such file or directory
   33 | #include "trace-tools.h"
      |          ^~~~~~~~~~~~~~~

The file was apparently added in jami-daemon@22b7425a, but maybe is not handled by meson builds? More generally, tracepoints seems to have been added only to configure.ac (e.g. jami-daemon@67fa5a34), and are not available to meson builds. So maybe the issue is more in jami-daemon that jami-client-qt, but since it failed here I thought I would report there.

changed the description

Ping @Vladimir that always have good ideas and nice solutions. ;)

assigned to @old

cc @old :/

I think it the issue of the daemon, because it provides unusable headers.

As a temporary workaround, this patch works for me.

diff --git a/src/meson.build b/src/meson.build
index cf242a9ac..873c6b930 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -348,6 +348,7 @@ if get_option('interfaces').contains('library')
         'jami/presence_const.h',
         'jami/presencemanager_interface.h',
         'jami/security_const.h',
+        'jami/trace-tools.h',
         subdir: 'jami'
     )
     if conf.get('ENABLE_VIDEO')

But of course the right solution is to add support for tracepoints in Meson (and CMake?). Will try to look at it on the next week.

Thanks @Vladimir, I expected something like that. ;)

mentioned in issue #762 (closed)

trace-tools is supposed to be part of the public header files because it's used in one of those. I think ring_signal.h.

There's indeed missing logic for meson build and CMake because it was only intended as a tool for developer that use autotools.

Adding the missing header files like the answer above should fix the issue.

still the case?

Fixed with https://review.jami.net/c/jami-daemon/+/21784 .

closed