From 14c3e86595fe8ab244fe71b9f68b256c5bf99d54 Mon Sep 17 00:00:00 2001 From: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com> Date: Wed, 26 Dec 2018 14:02:30 -0500 Subject: [PATCH] project: header/warnings cleanup Change-Id: Ie3fb90bd2f55f39c9903ca690881295dca77551b --- bannedlistmodel.cpp | 3 +++ callwidget.cpp | 3 ++- callwidget.ui | 2 +- conversationsfilterwidget.cpp | 4 +++- newwizardwidget.ui | 2 +- regnamedialog.cpp | 3 +++ settingswidget.cpp | 1 + videoview.cpp | 1 + videowidget.h | 2 +- 9 files changed, 16 insertions(+), 5 deletions(-) diff --git a/bannedlistmodel.cpp b/bannedlistmodel.cpp index 1bd85e6..d164ecc 100644 --- a/bannedlistmodel.cpp +++ b/bannedlistmodel.cpp @@ -36,5 +36,8 @@ BannedListModel::rowCount(const QModelIndex &index) const bool BannedListModel::setData(const QModelIndex& index, const QVariant& value, int role) { + Q_UNUSED(index); + Q_UNUSED(value); + Q_UNUSED(role); return 1; } \ No newline at end of file diff --git a/callwidget.cpp b/callwidget.cpp index d1b6017..b28df8a 100644 --- a/callwidget.cpp +++ b/callwidget.cpp @@ -144,6 +144,8 @@ CallWidget::CallWidget(QWidget* parent) : connect(ui->mainActivitySplitter, &QSplitter::splitterMoved, [this](int pos, int index) { + Q_UNUSED(index); + Q_UNUSED(pos); QSettings settings; settings.setValue(SettingsKey::mainSplitterState, ui->mainActivitySplitter->saveState()); }); @@ -748,7 +750,6 @@ CallWidget::slotVideoViewDestroyed(const std::string& callid) { auto convUid = LRCInstance::getSelectedConvUid(); auto currentConversationModel = LRCInstance::getCurrentConversationModel(); - auto callModel = LRCInstance::getCurrentCallModel(); auto conversation = Utils::getConversationFromUid(convUid, *currentConversationModel); if (conversation != currentConversationModel->allFilteredConversations().end() && callid != conversation->callId) { diff --git a/callwidget.ui b/callwidget.ui index f7f045e..73aa9e0 100644 --- a/callwidget.ui +++ b/callwidget.ui @@ -1322,7 +1322,7 @@ Copy and share it with your friends! <height>420</height> </size> </property> - <layout class="QVBoxLayout" name="callInvite" stretch="0,2,1,2,1,9"> + <layout class="QVBoxLayout" name="callInviteLayout" stretch="0,2,1,2,1,9"> <property name="spacing"> <number>0</number> </property> diff --git a/conversationsfilterwidget.cpp b/conversationsfilterwidget.cpp index 6d2bf76..0c349d3 100644 --- a/conversationsfilterwidget.cpp +++ b/conversationsfilterwidget.cpp @@ -36,8 +36,10 @@ void ConversationsFilterWidget::updateBadges() updateNotifier(Type::PENDING); } -void ConversationsFilterWidget::resizeEvent(QResizeEvent * event) +void +ConversationsFilterWidget::resizeEvent(QResizeEvent* event) { + Q_UNUSED(event); updateBadges(); } diff --git a/newwizardwidget.ui b/newwizardwidget.ui index d90d47c..1a98d8d 100644 --- a/newwizardwidget.ui +++ b/newwizardwidget.ui @@ -869,7 +869,7 @@ <number>0</number> </property> <item row="0" column="0"> - <widget class="QWidget" name="verticalWidget" native="true"> + <widget class="QWidget" name="verticalWidget1" native="true"> <property name="sizePolicy"> <sizepolicy hsizetype="Fixed" vsizetype="MinimumExpanding"> <horstretch>0</horstretch> diff --git a/regnamedialog.cpp b/regnamedialog.cpp index ac19392..6421659 100644 --- a/regnamedialog.cpp +++ b/regnamedialog.cpp @@ -62,6 +62,9 @@ void RegNameDialog::nameRegistrationResultSlot(const std::string& accountId, lrc::api::account::RegisterNameStatus status, const std::string& registerdName) { + Q_UNUSED(accountId); + Q_UNUSED(registerdName); + gif->stop(); if(status == lrc::api::account::RegisterNameStatus::SUCCESS) { diff --git a/settingswidget.cpp b/settingswidget.cpp index 13f8fcb..579c277 100644 --- a/settingswidget.cpp +++ b/settingswidget.cpp @@ -137,6 +137,7 @@ SettingsWidget::SettingsWidget(QWidget* parent) accountAddedConnection_ = connect(&LRCInstance::accountModel(), &lrc::api::NewAccountModel::accountAdded, [this, toDisconnect](const std::string& accountId) { + Q_UNUSED(accountId); setConnections(); QObject::disconnect(*toDisconnect); }); diff --git a/videoview.cpp b/videoview.cpp index b083187..834f6b3 100644 --- a/videoview.cpp +++ b/videoview.cpp @@ -178,6 +178,7 @@ VideoView::showChatviewIfToggled() void VideoView::simulateShowChatview(bool checked) { + Q_UNUSED(checked); overlay_->simulateShowChatview(true); } diff --git a/videowidget.h b/videowidget.h index e9e5fe9..e9f9523 100644 --- a/videowidget.h +++ b/videowidget.h @@ -20,12 +20,12 @@ #include <QWidget> #include <QPainter> +#include <QMutex> #include <memory> #include "video/renderer.h" #include "video/previewmanager.h" -#include "callmodel.h" class VideoWidget : public QWidget { -- GitLab