Change-Id: I717d1030dcb5a93eb59eccb2da7e5a3c29355287

Olivier SOLDANO authored Jul 13, 2017 and Adrien Béraud committed Jul 13, 2017

changing the interface to provide a clearer view
and convert the remaining unecessary hashes to
registered name when available.

Change-Id: I985036bc5fc4cdbe121dbf5e88252fb964cdc757

Olivier SOLDANO authored Jul 13, 2017 and Adrien Béraud committed Jul 13, 2017

change from respectively, left bottom and right bottom of avatar
to right bottom and left side center.

Change-Id: I3d94a897bb4bedb53929f59f72c7cc20542d3b28

Change-Id: I5ce22de2417369ab1ec1799b0cc56fee3e542d30

Fix little error in condition check of lupdate execution.

Change-Id: I93b3804b6e927dca2165e4575eddfe614d64c9ac
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

* set mininum-perc to 1 (was 30)
* update from sources first
* add push source file after update and before pull
* correct copyrights and cosmetics

Change-Id: If9cc92c99bb7d9b3cfbdf23f40de4470453454d1

whenever the user receives a call (even when in another call)
display the incoming call invite page.
The previous comportment was to stay on the active page.

Change-Id: I6986f5eb36981d1b329652bf2acadf500e2c0202
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

in the security tab several checkbox where placed to configure
the encryption comportment, but none was either effective or
useful.

Change-Id: I1225c470052a764c0233cb94dfbc87cce902a9f1
Tuleap: #1627

"Permanantly remove..." -> "Permanently remove..."

Change-Id: I743088d0ac5771b0e959adefd26cc00d5fc718ee

DTMF is not well supported in the daemon so this option shouldn't be
presented to the user.

Change-Id: Ieb1b35ba82c4771e0de283a1741c5ea33bb5d916
Tuleap: #1626

In the wizard dialog, we now set a default alias if user decides
not to give one. Such an account is referred under a generic
“Ring account” in the settings panel.

Change-Id: If07644cee0246486b5a0418a97abfb1734982639
Tuleap: #1625

Anthony Léonard authored Jun 21, 2017 and Philippe Gorley committed Jun 21, 2017

This mention was supposed to be the client version which is not
related to daemon or lrc version. It was misleading as this wasn't
clearly indicated.

Moreover, indicating a non-zero major number is not correct as Ring is
not considered to be stable yet.

Change-Id: I6ed590950c13b9835ecf66706d9e5777a0b715d2
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

duplication was occuring in the smartlist whenever a contact method
was added from the searchbar. This was due to  the use of
getNumber(URI&,QString&) instead of getNumber(const QString&,
Account*, const QString&)

Change-Id: I3a0f4f8d129d6022b1e79168f121c7421c60e1ac
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

implements banned account, add a tab at the end of account details
that shows a list of banned contacts, and on click displays a pannel
with detailed contact informations, providing the option to deban
this contact.

Change-Id: Icc2a0e315830bc3f7beb23797bedf12ecfd9a074
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

add a cycling gif to the outbound call page of callwidget
to show that the process of the call is ongoing and has not
froze.

Change-Id: I0014b0716b095b526bd4a7cb7bf8ea9632a4d156
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Change-Id: I46018d08cbf1f143123f3875c5b92ed7569ce912
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

added the bestId bellow the alias to strengthen
the identification of caller by the callee.

Change-Id: Ieae16cdcc39935e1a1a2da59ea6526b5dbd6a9dc
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Bringing Ring's window to front when clicking on an incoming message
notification was only working in the case where the window was
minimized. It is now also working when it is just left behind another
application.

Change-Id: I777a0eb74f3534fa8b538379ae43e59681801df5
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>
Tuleap: #926

Tabs are now smaller and use icons instead of text for "Conversations"
and "Contact requests" tabs. It gives a better looking UI and room for
 additional pages.

Moreover, tab switching was giving inconsistencies in many situations
between item selected on the left and what is displayed on the right
panel. Showing or hiding a widget on the right panel now depends on
the selection model of the list on the left. Consequently, clicking on
a back button now deselects the item on the left which is what switches
the view back to the welcome page.

Change-Id: Ib67149dba62e15bebcfe3ebce2398b7717e3f85d
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

hides the search bar in case of the user has disabled all
its accounts to avoid the case that searching anything
makes it a SIP contact method.

It also clears the ID field displayed in the welcome page.

Change-Id: I86e299a7dc35f65f8dc05761cd1afecb3f9d84c2
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

The account deletion was performed by solely clicking the bin icon
in the configuration account panel of a selected account.
This was done without warning nor confirmation.

This patch moves the dedicated button to the account list bottom
as in the other desktop clients, and adds a confimation popup,
summarising the account identifiers (in order, alias, registered name,
ringID), and displays a warning about losing the account in case
it hasn't been exported or added to another device.

Change-Id: I259388da9e143400ab65e88d1fb7c223dbfbff19
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

One occurence of userChosenAccount() was left which was crashing the
application when sending a contact request to a ContactMethod without
account linked to it.

Moreover, this is a deprecated method which is now totally removed
from the client.

Change-Id: I46a938c7bf4ac8a3212a2a7a2f7de80a647d956d
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

When the messaging panel was closed by clicking on the back button, a
slot was still triggered when the last selected contact method
received a message. This one was calling setAllRead() from
TextRecording to indicate that all messages were read by the user and
then the indicator wasn't displayed.

Clicking on the back button now disconnect this signal so new incoming
messages are not marked as read.

Change-Id: I65049ac13ea6fe5c758935333ceda0f97f2b45ab
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

The whole contact request view design has been modified to show every
informations contained in vCard that are useful for a user to decide
if he should or not trust somebody. It is also better looking than
the previous version.

Those informations are presented:
 * An embedded picture if any (with a fallback to the default one)
 * The profile name chosen by the sender of the request
 * The "best ID" which is the registered name or the RingID (in that
   order of priority)

This last information is a security measure to check the real identity
of the contact request sender.

Change-Id: Ibcb3e8667f91c8123b9016e6dfd72621bfb4f3f1
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

this patch adds buttons to switch to welcome page and settings
page whilst in a call.
The client was lacking this fonctionnality, in comparison to the
gnome client.

This patch also fixes the comportment of the smartlist responding
to these new possible states (including changing account during
a call).

Change-Id: I9c620d83ae0daf75f3ffc64205299006686807f1
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

This reverts commit 9690f647

.
Smartlist refresh on selected account changes is now managed directly
by LRC. The "hack" with empty regex is not needed anymore.

Change-Id: I2b06dfb3d474b271505df7bb927b2cc64a877844
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

this patch adds the ID of a contact under its alias
in the smartlist. This allows to differentiate the
contact methods and helps to prevent identity spoofing.

Change-Id: Ia8b8943f4b7a5f223e1fdc1ae5b3bd74f90e6582
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

this patch will facilitate the future work on contact requests.
It will also alleviate callwidget code.

Change-Id: I9ec0220d5c37d960822170e30ab95bf306a7bf5e
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

implements a hover widget with three buttons, for accepting,
discarding, and blocking a contact request without requiring to
use the dedicated panel

Change-Id: I5002d3d156d8783bc613f52d7dd2abaaf9fc064f
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

add the libre font "FontAwesome" implementing unicode symbols

Change-Id: I4ca439fcd1768239b7bd62a768b92d17b86fdad9
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

Presence indicators are now displayed in the smartlist. It is placed
at the bottom left of an avatar and is refreshed automatically when
presence status is modified.

Change-Id: I4acf8a0df0d8a0f03ac013388bf5fc5d417afcb5
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Accepting and discarding was already possible but not blocking
requests from somebody (banning it). This is now possible when
looking at an incoming contact request by clicking on a red button.

Change-Id: I89914beaf27713cabece02de107569b1e1f851d0
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

With this modification, the smartlist now displays the conversations
that are linked to the selected account. The list updates its content
when the selection model of AvailableAccount model is changed.

Change-Id: Ie611f013f6eeb5763061380c34ab7d680f4c4b02
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Adding a new contact by its registered username was correctly linking
it to the current selected account but adding it with a raw RingID
wasn't doing this step. A consequence of this was a fail when sending
a contact request to a new contact added by RingID.

The account associated to a ContactMethod is now set in both cases.

Moreover, a method was added to retrieve the current selected account
as it is often needed in CallWidget.

Change-Id: Ie1476ad85a5e624d7684a95fad37abc01a2d23ee
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Comments are added to improve readability of the item drawing code as
it is not always self-explanatory.

Furthermore, some lines are moved or deleted for various reasons:
 * Some lines were repeated or not doing any operations.
 * Objects/structures were initialised at one place but used much
   later in code which lead to poor legibility.
 * Dead code, variables and constants were present.

Change-Id: I833769cc594033d88a70ce192ae002ac091a37a5
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Recent changes in LRC introduced a selection system to choose a
current active account in AccountModel. It was decided to prefer the
selectionModel of the AvailableAccountModel as it filters out accounts
not enabled.

Moreover, the selected account is now the one used when looking for a
new contact. The default scheme used depends on the account type and
the account linked to the contact method is now the selected one.

Finally, the CurrentAccountWidget now better reflects changes of
profile's picture and selected account when this one is changed by an
external event (like a call on an enabled, but not selected, account).

Change-Id: I5ad50a6f6b9d28e03ab031ffecfb0018965475f9

Last changes were merged quickly without strict code-review
as it was needed to integrate them promptly.
Related modifications:
 * callwidget.cpp: Removed unnecessary line feed
 * callwidget.{cpp,ui}: Renamed “contactRequestView” to
   “contactRequestPage” for consistency
 * contactrequestwidget.cpp: Refactoring of a too-long line
 * sendcontactrequestwidget.{cpp,ui}: Better placeholders

Moreover, contactrequestwidget.{cpp,ui} were missing the GPL
header and copyrights' years are now updated to 2017 in every
files.

Change-Id: Id52f340fc62340df6cf5bda8d782fefc732beabe

The new logo wasn't scaled correctly. It is now correct and looks
nicer.

Change-Id: I92aad28eae06886d8b338b4a38960610957bb744
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

This change adds an item delegate used to display every
elements in the pending contact requests list.

The displayed view is consistent with the existing smart
list view. It shows the RingID of the sender and its picture.
This last one is currently the default picture but is expected
to become the one embedded in the payload if any.

Change-Id: Idc7afb5c6bfcda7bce67dfd042a28f9789506815
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

This patch improves the way the client react to a modification
of the selected account.

From a UI point of view, the displayed Ring ID now depends
on the selected account in the combo box. Previously, it was
always set to the first enabled Ring account found in
AccountModel.

The old behavior is removed from findRingAccount() which now
only focus on looking if an account needs migration or if it
is needed to create one (at first launch).

Change-Id: If63a74eb320b8fc31064d87b04b5e062fc0cc10a
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>