From 12c74ad251dbe0fc2557754612999f97b93f650a Mon Sep 17 00:00:00 2001
From: Olivier Dion <olivier.dion@savoirfairelinux.com>
Date: Fri, 22 Oct 2021 15:56:50 -0400
Subject: [PATCH] jamidht/jamiaccount: Fix read of empty payload
ASAN does not like this:
--------------------------------------------------------------------------------
runtime error: reference binding to null pointer of type 'const value_type'
--------------------------------------------------------------------------------
Change-Id: Idca4720dda401c756bd6ea5dc054dd9e63779153
---
src/jamidht/jamiaccount.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/jamidht/jamiaccount.cpp b/src/jamidht/jamiaccount.cpp
index 69c02e34b3..f1930379e7 100644
--- a/src/jamidht/jamiaccount.cpp
+++ b/src/jamidht/jamiaccount.cpp
@@ -3229,7 +3229,11 @@ JamiAccount::sendTrustRequest(const std::string& to, const std::vector<uint8_t>&
JAMI_ERR("Could not write data to %s", cachedFile.c_str());
return;
}
- req.write(reinterpret_cast<const char*>(&payload[0]), payload.size());
+
+ if (not payload.empty()) {
+ req.write(reinterpret_cast<const char*>(payload.data()), payload.size());
+ }
+
if (payload.size() > 64000) {
JAMI_WARN() << "Trust request is too big";
}
--
GitLab