[ #13801 ] Fix about 200 Krazy2 notification/warning/comments

kde/src/lib/ContactBackend.cpp

@@ -56,10 +56,10 @@ ContactList ContactBackend::update()
 ///Return the extension/user of an URI (<sip:12345@exemple.com>)
 QString ContactBackend::getUserFromPhone(QString phoneNumber)
 {
-   if (phoneNumber.indexOf("@") != -1) {
-      QString user = phoneNumber.split("@")[0];
-      if (user.indexOf(":") != -1) {
-         return user.split(":")[1];
+   if (phoneNumber.indexOf('@') != -1) {
+      QString user = phoneNumber.split('@')[0];
+      if (user.indexOf(':') != -1) {
+         return user.split(':')[1];
       }
       else {
          return user;
@@ -71,8 +71,8 @@ QString ContactBackend::getUserFromPhone(QString phoneNumber)
 ///Return the domaine of an URI (<sip:12345@exemple.com>)
 QString ContactBackend::getHostNameFromPhone(QString phoneNumber)
 {
-   if (phoneNumber.indexOf("@") != -1) {
-      return phoneNumber.split("@")[1].left(phoneNumber.split("@")[1].size()-1);
+   if (phoneNumber.indexOf('@') != -1) {
+      return phoneNumber.split('@')[1].left(phoneNumber.split('@')[1].size()-1);
    }
    return "";
 }

kde/src/lib/HistoryModel.cpp

@@ -58,8 +58,8 @@ CallMap       HistoryModel::m_sHistoryCalls          ;
 HistoryModel::HistoryModel():m_HistoryInit(false)
 {
    ConfigurationManagerInterface& configurationManager = ConfigurationManagerInterfaceSingleton::getInstance();
-   QVector< QMap<QString, QString> > history = configurationManager.getHistory();
-   foreach (MapStringString hc, history) {
+   const QVector< QMap<QString, QString> > history = configurationManager.getHistory();
+   foreach (const MapStringString& hc, history) {
       Call* pastCall = Call::buildHistoryCall(
                hc[ CALLID_KEY          ]         ,
                hc[ TIMESTAMP_START_KEY ].toUInt(),

kde/src/lib/InstantMessagingModel.cpp

@@ -17,6 +17,7 @@
  *   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA *
  ***********************************************************************************/
 #include "InstantMessagingModel.h"
+
 #include "CallModel.h"
 #include "callmanager_interface_singleton.h"
 #include "Call.h"

kde/src/lib/InstantMessagingModel.h

@@ -52,7 +52,7 @@ public:
    }
    InstantMessagingModel* getModel(Call* call);
 private:
-   InstantMessagingModelManager();
+   explicit InstantMessagingModelManager();
    static InstantMessagingModelManager* m_spInstance;
    static CallModelBase* m_spCallModel;
    QHash<QString,InstantMessagingModel*> m_lModels;
@@ -75,7 +75,7 @@ public:
    static const int MESSAGE_IMAGE_ROLE   = 103;
    static const int MESSAGE_CONTACT_ROLE = 104;
 
-   InstantMessagingModel(Call* call, QObject* parent = nullptr);
+   explicit InstantMessagingModel(Call* call, QObject* parent = nullptr);
    QVariant      data     ( const QModelIndex& index, int role = Qt::DisplayRole     ) const;
    int           rowCount ( const QModelIndex& parent = QModelIndex()                ) const;
    Qt::ItemFlags flags    ( const QModelIndex& index                                 ) const;

kde/src/lib/VideoCodecModel.cpp

@@ -76,8 +76,8 @@ void VideoCodecModel::reload()
 {
    m_lCodecs.clear();
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
-   VectorMapStringString codecs =  interface.getCodecs(m_pAccount->getAccountId());
-   foreach(MapStringString h,codecs) {
+   const VectorMapStringString codecs =  interface.getCodecs(m_pAccount->getAccountId());
+   foreach(const MapStringString& h,codecs) {
       VideoCodec* c = new VideoCodec(h["name"],h["bitrate"].toInt(),h["enabled"]=="true");
       m_lCodecs << c;
    }

kde/src/lib/VideoDevice.cpp

@@ -28,12 +28,12 @@ VideoDevice::VideoDevice(QString id) : m_DeviceId(id)
 }
 
 ///Get the video device list
-QList<VideoDevice*> VideoDevice::getDeviceList()
+const QList<VideoDevice*> VideoDevice::getDeviceList()
 {
    QHash<QString,VideoDevice*> devices;
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
-   QStringList deviceList = interface.getDeviceList();
-   foreach(QString device,deviceList) {
+   const QStringList deviceList = interface.getDeviceList();
+   foreach(const QString& device,deviceList) {
       if (!m_slDevices[device])
          devices[device] = new VideoDevice(device);
       else
@@ -55,14 +55,14 @@ VideoDevice* VideoDevice::getDevice(QString name)
 }
 
 ///Get the valid rates for this device
-QStringList VideoDevice::getRateList(VideoChannel channel, Resolution resolution)
+const QStringList VideoDevice::getRateList(VideoChannel channel, Resolution resolution)
 {
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
    return interface.getDeviceRateList(m_DeviceId,channel,resolution.toString());
 }
 
 ///Get the valid channel list
-QList<VideoChannel> VideoDevice::getChannelList()
+const QList<VideoChannel> VideoDevice::getChannelList()
 {
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
    return interface.getDeviceChannelList(m_DeviceId);
@@ -90,39 +90,40 @@ void VideoDevice::setChannel(VideoChannel channel) //??? No device
 }
 
 ///Get the current resolution
-Resolution VideoDevice::getResolution()
+const Resolution VideoDevice::getResolution()
 {
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
    return Resolution(interface.getActiveDeviceSize());
 }
 
 ///Get the current channel
-VideoChannel VideoDevice::getChannel() //??? No device
+const VideoChannel VideoDevice::getChannel() //??? No device
 {
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
    return interface.getActiveDeviceChannel();
 }
 
 ///Get the current rate
-VideoRate VideoDevice::getRate()
+const VideoRate VideoDevice::getRate()
 {
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
    return interface.getActiveDeviceRate();
 }
 
 ///Get a list of valid resolution
-QList<Resolution> VideoDevice::getResolutionList(VideoChannel channel)
+const QList<Resolution> VideoDevice::getResolutionList(VideoChannel channel)
 {
    QList<Resolution> toReturn;
    VideoInterface& interface = VideoInterfaceSingleton::getInstance();
-   QStringList list = interface.getDeviceSizeList(m_DeviceId,channel);
-   foreach(QString res,list) {
+   const QStringList list = interface.getDeviceSizeList(m_DeviceId,channel);
+   foreach(const QString& res,list) {
       toReturn << Resolution(res);
    }
    return toReturn;
 }
 
-QString VideoDevice::getDeviceId()
+///Get the device id
+const QString VideoDevice::getDeviceId() const
 {
    return m_DeviceId;
 }

kde/src/lib/VideoDevice.h

@@ -42,7 +42,7 @@ struct LIB_EXPORT Resolution {
    Resolution(const Resolution& res):width(res.width),height(res.height){}
    Resolution(const QSize& size):width(size.width()),height(size.height()){}
    //Getter
-   QString toString() { return QString::number(width)+"x"+QString::number(height);}
+   const QString toString() const { return QString::number(width)+"x"+QString::number(height);}
 
    //Attributes
    uint width;
@@ -61,16 +61,16 @@ class LIB_EXPORT VideoDevice {
       static VideoDevice* getDevice(QString id);
 
       //Getter
-      QStringList                getRateList(VideoChannel channel, Resolution resolution);
-      QList<Resolution>          getResolutionList(VideoChannel channel);
-      QList<VideoChannel>        getChannelList ();
-      Resolution                 getResolution  ();
-      VideoChannel               getChannel     ();
-      VideoRate                  getRate        ();
-      QString                    getDeviceId    ();
+      const QStringList         getRateList(VideoChannel channel, Resolution resolution);
+      const QList<Resolution>   getResolutionList(VideoChannel channel);
+      const QList<VideoChannel> getChannelList ();
+      const Resolution          getResolution  ();
+      const VideoChannel        getChannel     ();
+      const VideoRate           getRate        ();
+      const QString             getDeviceId    () const;
       
       //Static getter
-      static QList<VideoDevice*> getDeviceList();
+      static const QList<VideoDevice*> getDeviceList();
 
       //Setter
       void setRate       ( VideoRate rate        );

kde/src/lib/configurationmanager_interface_singleton.cpp

@@ -34,4 +34,3 @@ ConfigurationManagerInterface & ConfigurationManagerInterfaceSingleton::getInsta
    }
    return *interface;
 }
-