From 251d6fd16f97882263dba2daff274c1e76aef34a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois-Simon=20Fauteux-Chapleau?=
<francois-simon.fauteux-chapleau@savoirfairelinux.com>
Date: Tue, 2 Apr 2024 10:38:19 -0400
Subject: [PATCH] sipcall: don't try to change media if media list is empty
GitLab: #978
Change-Id: I89644008fd6e8b22e1a1805778f3983ab9df7795
---
src/sip/sipcall.cpp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/sip/sipcall.cpp b/src/sip/sipcall.cpp
index 5f9d738695..a2ed3011ea 100644
--- a/src/sip/sipcall.cpp
+++ b/src/sip/sipcall.cpp
@@ -2612,6 +2612,11 @@ SIPCall::requestMediaChange(const std::vector<libjami::MediaMap>& mediaList)
if (hasVideo)
mediaAttrList.emplace_back(videoAttr);
}
+
+ if (mediaAttrList.empty()) {
+ JAMI_ERROR("[call:{}] Invalid media change request: new media list is empty", getCallId());
+ return false;
+ }
JAMI_DEBUG("[call:{}] Requesting media change. List of new media:", getCallId());
unsigned idx = 0;
--
GitLab