plugins: cleanup

Change-Id: I57ea8db1cf5b2c28e000bc66db41c0b8224f9b7b

src/plugin/jamipluginmanager.cpp

@@ -439,16 +439,11 @@ std::map<std::string, std::string> JamiPluginManager::getPluginPreferencesValues
     std::map<std::string, std::string>  rmap;
 
     std::vector<std::map<std::string,std::string>> preferences = getPluginPreferences(rootPath);
-
-    for (int i = 0; i < preferences.size(); i++)
-    {
+    for (size_t i = 0; i < preferences.size(); i++) {
         rmap[preferences[i]["key"]] = preferences[i]["defaultValue"];
     }
 
-    std::map<std::string, std::string> pluginUserPreferencesMap = getPluginUserPreferencesValuesMap(rootPath);
-
-    for (const auto& pair : pluginUserPreferencesMap)
-    {
+    for (const auto& pair : getPluginUserPreferencesValuesMap(rootPath)) {
         rmap[pair.first] = pair.second;
     }
     return rmap;