From 935b76099e880197a781f8cf487e278469a10559 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Blin?=
 <sebastien.blin@savoirfairelinux.com>
Date: Tue, 2 Feb 2021 09:23:42 -0500
Subject: [PATCH] turn: do not add ipv4 turn twice

Change-Id: I5d6f9d8fe3b44a5bbe2045cc3d48f11a81a2512c
---
 src/sip/sipaccountbase.cpp | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/sip/sipaccountbase.cpp b/src/sip/sipaccountbase.cpp
index 3749b37fdb..aac4c79fb1 100644
--- a/src/sip/sipaccountbase.cpp
+++ b/src/sip/sipaccountbase.cpp
@@ -479,13 +479,15 @@ SIPAccountBase::getIceOptions() const noexcept
                                               .setPassword(turnServerPwd_)
                                               .setRealm(turnServerRealm_));
         }
-        if (cacheTurnV6_ && *cacheTurnV6_) {
-            opts.turnServers.emplace_back(TurnServerInfo()
-                                              .setUri(cacheTurnV4_->toString(true))
-                                              .setUsername(turnServerUserName_)
-                                              .setPassword(turnServerPwd_)
-                                              .setRealm(turnServerRealm_));
-        }
+        // NOTE: first test with ipv6 turn was not concluant and resulted in multiple
+        // co issues. So this needs some debug. for now just disable
+        // if (cacheTurnV6_ && *cacheTurnV6_) {
+        //    opts.turnServers.emplace_back(TurnServerInfo()
+        //                                      .setUri(cacheTurnV6_->toString(true))
+        //                                      .setUsername(turnServerUserName_)
+        //                                      .setPassword(turnServerPwd_)
+        //                                      .setRealm(turnServerRealm_));
+        //}
         // Nothing cached, so do the resolution
         if (!cached) {
             opts.turnServers.emplace_back(TurnServerInfo()
-- 
GitLab