Skip to content
Snippets Groups Projects
Commit ab6b1726 authored by Adrien Béraud's avatar Adrien Béraud
Browse files

Revert "namedirectory: prevent deadlock on destruction"

Reason for revert: breaks the design

Change-Id: Ib94d36d5f671628ddfcbaaa4fef180821e7a79e3
parent 010b9124
Branches
No related tags found
No related merge requests found
...@@ -162,9 +162,6 @@ NameDirectory::lookupAddress(const std::string& addr, LookupCallback cb) ...@@ -162,9 +162,6 @@ NameDirectory::lookupAddress(const std::string& addr, LookupCallback cb)
setHeaderFields(*request); setHeaderFields(*request);
request->add_on_done_callback( request->add_on_done_callback(
[this, cb = std::move(cb), reqid, addr](const dht::http::Response& response) { [this, cb = std::move(cb), reqid, addr](const dht::http::Response& response) {
if (response.status_code == 0) {
return;
}
if (response.status_code >= 400 && response.status_code < 500) { if (response.status_code >= 400 && response.status_code < 500) {
cb("", Response::notFound); cb("", Response::notFound);
} else if (response.status_code != 200) { } else if (response.status_code != 200) {
...@@ -251,9 +248,6 @@ NameDirectory::lookupName(const std::string& n, LookupCallback cb) ...@@ -251,9 +248,6 @@ NameDirectory::lookupName(const std::string& n, LookupCallback cb)
setHeaderFields(*request); setHeaderFields(*request);
request->add_on_done_callback([this, reqid, name, cb = std::move(cb)]( request->add_on_done_callback([this, reqid, name, cb = std::move(cb)](
const dht::http::Response& response) { const dht::http::Response& response) {
if (response.status_code == 0) {
return;
}
if (response.status_code >= 400 && response.status_code < 500) if (response.status_code >= 400 && response.status_code < 500)
cb("", Response::notFound); cb("", Response::notFound);
else if (response.status_code < 200 || response.status_code > 299) else if (response.status_code < 200 || response.status_code > 299)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment