From ab6b1726eb05084fa0b0eeb49a7b4ff072422e0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrien=20B=C3=A9raud?= <adrien.beraud@savoirfairelinux.com> Date: Fri, 26 Feb 2021 12:09:39 -0500 Subject: [PATCH] Revert "namedirectory: prevent deadlock on destruction" Reason for revert: breaks the design Change-Id: Ib94d36d5f671628ddfcbaaa4fef180821e7a79e3 --- src/jamidht/namedirectory.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/jamidht/namedirectory.cpp b/src/jamidht/namedirectory.cpp index 4b16bff514..7edc9d1855 100644 --- a/src/jamidht/namedirectory.cpp +++ b/src/jamidht/namedirectory.cpp @@ -162,9 +162,6 @@ NameDirectory::lookupAddress(const std::string& addr, LookupCallback cb) setHeaderFields(*request); request->add_on_done_callback( [this, cb = std::move(cb), reqid, addr](const dht::http::Response& response) { - if (response.status_code == 0) { - return; - } if (response.status_code >= 400 && response.status_code < 500) { cb("", Response::notFound); } else if (response.status_code != 200) { @@ -251,9 +248,6 @@ NameDirectory::lookupName(const std::string& n, LookupCallback cb) setHeaderFields(*request); request->add_on_done_callback([this, reqid, name, cb = std::move(cb)]( const dht::http::Response& response) { - if (response.status_code == 0) { - return; - } if (response.status_code >= 400 && response.status_code < 500) cb("", Response::notFound); else if (response.status_code < 200 || response.status_code > 299) -- GitLab