From acaa9dd6adb2b974be256da7a755f95e7d3f60c3 Mon Sep 17 00:00:00 2001
From: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>
Date: Tue, 21 Jul 2015 16:42:57 -0400
Subject: [PATCH] configurationmanager: fix nullptr access
This patch fixes a nullptr access to non checked pointer
returned by ring::Manager::instance().getCurrentCall().
This is a bug introduced by commit 3939750fba4caf00a553f47e7c3fb883aac12095
Refs #77483
Change-Id: I8bd1b67a8bb97c4afc86609e9fe276797bf54aa2
---
src/client/configurationmanager.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/client/configurationmanager.cpp b/src/client/configurationmanager.cpp
index e57cf050ff..3c687dd2ac 100644
--- a/src/client/configurationmanager.cpp
+++ b/src/client/configurationmanager.cpp
@@ -414,8 +414,8 @@ setCodecDetails(const std::string& accountID,
if (foundCodec->isRunning) {
RING_WARN("%s running. Need to restart encoding",
foundCodec->systemCodecInfo.name.c_str());
- auto call = ring::Manager::instance().getCurrentCall();
- call->restartMediaSender();
+ if (auto call = ring::Manager::instance().getCurrentCall())
+ call->restartMediaSender();
}
ring::emitSignal<ConfigurationSignal::MediaParametersChanged>(accountID);
return true;
--
GitLab