From b687f8e21c272dcdbdbaba9abc745d7ad732bfd7 Mon Sep 17 00:00:00 2001 From: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Date: Thu, 19 Jun 2025 11:11:25 -0400 Subject: [PATCH] media: fix return value for mediaTypeToString The function mediaTypeToString never checked for nullptr return values, which could potentially lead to crashes. This patch ensures it always returns a valid string for all defined MediaType values. Change-Id: I81ef8876e1f57265584fae02cdfaff2894ff9f8c --- src/media/media_attribute.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/media/media_attribute.cpp b/src/media/media_attribute.cpp index 50052f883d..a5c0b7f84f 100644 --- a/src/media/media_attribute.cpp +++ b/src/media/media_attribute.cpp @@ -136,7 +136,9 @@ MediaAttribute::mediaTypeToString(MediaType type) return libjami::Media::MediaAttributeValue::AUDIO; if (type == MediaType::MEDIA_VIDEO) return libjami::Media::MediaAttributeValue::VIDEO; - return nullptr; + if (type == MediaType::MEDIA_NONE) + return libjami::Media::MediaAttributeValue::SRC_TYPE_NONE; + return "UNKNOWN"; } bool -- GitLab