From c27d213542b16f58ca018050cdffb310b856464b Mon Sep 17 00:00:00 2001
From: philippegorley <philippe.gorley@savoirfairelinux.com>
Date: Fri, 15 Dec 2017 14:13:05 -0500
Subject: [PATCH] video: clean up video_rtp_session

Replaces empty methods and std::bind calls with lambdas.

Change-Id: I0d9c876a9ba0bbdc6a77a85e0e2d75766312f952
---
 src/media/video/video_rtp_session.cpp | 10 +++-------
 src/media/video/video_rtp_session.h   |  1 -
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/media/video/video_rtp_session.cpp b/src/media/video/video_rtp_session.cpp
index b11979d0d3..5a17db9fc5 100644
--- a/src/media/video/video_rtp_session.cpp
+++ b/src/media/video/video_rtp_session.cpp
@@ -58,14 +58,14 @@ VideoRtpSession::VideoRtpSession(const string &callID,
     , lastLongRTCPCheck_(std::chrono::system_clock::now())
     , videoBitrateInfo_ {}
     , rtcpCheckerThread_([] { return true; },
-            std::bind(&VideoRtpSession::processRtcpChecker, this),
-            std::bind(&VideoRtpSession::cleanupRtcpChecker, this))
+            [this]{ processRtcpChecker(); },
+            []{})
     , receiverRestartThread_([]{ return true; },
             [this]{ processReceiverRestart(); },
             []{})
     , packetLossThread_([] { return true; },
             [this]{ processPacketLoss(); },
-            [](){})
+            []{})
 {
     setupVideoBitrateInfo(); // reset bitrate
 }
@@ -585,10 +585,6 @@ VideoRtpSession::processRtcpChecker()
     rtcpCheckerThread_.wait_for(std::chrono::seconds(RTCP_CHECKING_INTERVAL));
 }
 
-void
-VideoRtpSession::cleanupRtcpChecker()
-{}
-
 void
 VideoRtpSession::processReceiverRestart()
 {
diff --git a/src/media/video/video_rtp_session.h b/src/media/video/video_rtp_session.h
index 31c502735e..9f96ee86d9 100644
--- a/src/media/video/video_rtp_session.h
+++ b/src/media/video/video_rtp_session.h
@@ -132,7 +132,6 @@ private:
 
     InterruptedThreadLoop rtcpCheckerThread_;
     void processRtcpChecker();
-    void cleanupRtcpChecker();
 
     InterruptedThreadLoop receiverRestartThread_;
     void processReceiverRestart();
-- 
GitLab