From c66d54834c02847043b04c4172cde112ce30741c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Quentin?=
 <jquentin@jquentin-laptop-kub2.(none)>
Date: Thu, 23 Jul 2009 17:58:10 -0400
Subject: [PATCH] [#1919] Error fixed [#1886]

---
 sflphone-client-kde/src/conf/dlgaccounts.cpp | 2 +-
 sflphone-client-kde/src/conf/dlgaccounts.h   | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/sflphone-client-kde/src/conf/dlgaccounts.cpp b/sflphone-client-kde/src/conf/dlgaccounts.cpp
index 3d91e82d07..2ff4ad4b16 100644
--- a/sflphone-client-kde/src/conf/dlgaccounts.cpp
+++ b/sflphone-client-kde/src/conf/dlgaccounts.cpp
@@ -182,7 +182,7 @@ void DlgAccounts::loadAccount(QListWidgetItem * item)
 	edit6_mailbox->setText( account->getAccountDetail(ACCOUNT_MAILBOX));
 	checkBox_conformRFC->setChecked( account->getAccountDetail(ACCOUNT_RESOLVE_ONCE) != "TRUE" );
 	bool ok;
-	int val = account->getAccountDetail(ACCOUNT_EXPIRE).toInt(ok);
+	int val = account->getAccountDetail(ACCOUNT_EXPIRE).toInt(&ok);
 	spinbox_regExpire->setValue(ok ? val : ACCOUNT_EXPIRE_DEFAULT);
 	updateStatusLabel(account);
 	frame2_editAccounts->setEnabled(true);
diff --git a/sflphone-client-kde/src/conf/dlgaccounts.h b/sflphone-client-kde/src/conf/dlgaccounts.h
index a0456b3bb4..3274368917 100644
--- a/sflphone-client-kde/src/conf/dlgaccounts.h
+++ b/sflphone-client-kde/src/conf/dlgaccounts.h
@@ -30,6 +30,8 @@
 
 /**
 	@author Jérémy Quentin <jeremy.quentin@gmail.com>
+	
+	\note see ticket #1309 for advices about how to improve this class.
 */
 class DlgAccounts : public QWidget, public Ui_DlgAccountsBase
 {
@@ -38,6 +40,7 @@ public:
 	DlgAccounts(KConfigDialog *parent = 0);
 
 	void saveAccount(QListWidgetItem * item);
+	
 	/**
 	 *   Fills the settings form in the right side with the
 	 *   settings of @p item.
@@ -49,7 +52,7 @@ public:
 	 *   is filled with the right default settings if blank (as 600 for
 	 *   registration expire).
 	 *
-	 * @param item 
+	 * @param item the item with which to fill the settings form
 	 */
 	void loadAccount(QListWidgetItem * item);
 	
-- 
GitLab