From d77082016ca363adb10be6408a3c6f47f3727d35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Blin?=
<sebastien.blin@savoirfairelinux.com>
Date: Tue, 1 Aug 2023 14:37:56 -0400
Subject: [PATCH] videoRtpSession: avoid busy loop
waitForRTCP as nothing to do with the readBlockingMode, so we should
remove this from the condition as it causes a busy loop (if video
is muted, receiver is stopped, condition_variable is always true,
causing a loop on the adaptative bitrate algorithm).
GitLab: #878
Change-Id: If19a43c5350eb43eff694b162d412a80d541f449
---
src/media/socket_pair.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/media/socket_pair.cpp b/src/media/socket_pair.cpp
index 1ce9f73aeb..a31aaf1ad6 100644
--- a/src/media/socket_pair.cpp
+++ b/src/media/socket_pair.cpp
@@ -222,8 +222,7 @@ SocketPair::waitForRTCP(std::chrono::seconds interval)
{
std::unique_lock<std::mutex> lock(rtcpInfo_mutex_);
return cvRtcpPacketReadyToRead_.wait_for(lock, interval, [this] {
- return interrupted_ or not listRtcpRRHeader_.empty() or not listRtcpREMBHeader_.empty()
- or not readBlockingMode_;
+ return interrupted_ or not listRtcpRRHeader_.empty() or not listRtcpREMBHeader_.empty();
});
}
--
GitLab