From f43da18f465f80f72d0f99b1149e3d650bd41a1e Mon Sep 17 00:00:00 2001
From: Eloi BAIL <eloi.bail@savoirfairelinux.com>
Date: Thu, 19 Nov 2015 14:08:51 -0500
Subject: [PATCH] media/video: bad writting access in video scaling
Padding needs sometimes to be done for scaling purpose when a change of video
source is performed. Padding calcul is wrong and leads to memory bad writting
access.
Tuleap: #87
Change-Id: Ied282941077c1e268529457d39cdcc403a741aaf
---
src/media/video/video_scaler.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/media/video/video_scaler.cpp b/src/media/video/video_scaler.cpp
index 009c5f3e7c..2ac11556fa 100644
--- a/src/media/video/video_scaler.cpp
+++ b/src/media/video/video_scaler.cpp
@@ -119,7 +119,7 @@ VideoScaler::scale_and_pad(const VideoFrame& input, VideoFrame& output,
const auto out_desc = av_pix_fmt_desc_get((AVPixelFormat)output_frame->format);
memset(tmp_data_, 0, sizeof(tmp_data_));
for (int i = 0; i < 4 && output_frame->linesize[i]; i++) {
- unsigned x_shift=xoff, y_shift=yoff;
+ signed x_shift=xoff, y_shift=yoff;
if (i == 1 || i == 2) {
x_shift = -((-x_shift) >> out_desc->log2_chroma_w);
y_shift = -((-y_shift) >> out_desc->log2_chroma_h);
--
GitLab