From ff403c6beb4733db3c51844284f3849aeaf28145 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Quentin?=
<jquentin@jquentin-laptop-kub2.(none)>
Date: Thu, 16 Jul 2009 12:56:17 -0400
Subject: [PATCH] Comments added
---
sflphone-client-kde/src/conf/ConfigurationDialog.h | 8 ++++++++
.../src/conf/ConfigurationSkeleton.h | 14 ++++++++------
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/sflphone-client-kde/src/conf/ConfigurationDialog.h b/sflphone-client-kde/src/conf/ConfigurationDialog.h
index 7fc0009b9c..4c3b1c26b9 100644
--- a/sflphone-client-kde/src/conf/ConfigurationDialog.h
+++ b/sflphone-client-kde/src/conf/ConfigurationDialog.h
@@ -42,6 +42,14 @@ class sflphone_kdeView;
/**
@author Jérémy Quentin <jeremy.quentin@gmail.com>
+ This class represents the config dialog for sflphone.
+ It uses the ConfigurationSkeleton class to handle most of the settings.
+ It inherits KConfigDialog with the pages defined in dlg... files.
+ A few complicated settings are handled directly by its pages.
+ Some custom behaviors have been added to handle specific cases,
+ as this config dialog is not the usual kind.
+ A few things might be done a cleaner way by passing the handling
+ to the skeleton like it has been done with codecs.
*/
class ConfigurationDialogKDE : public KConfigDialog
{
diff --git a/sflphone-client-kde/src/conf/ConfigurationSkeleton.h b/sflphone-client-kde/src/conf/ConfigurationSkeleton.h
index 71386a5070..d9fae7a6c1 100644
--- a/sflphone-client-kde/src/conf/ConfigurationSkeleton.h
+++ b/sflphone-client-kde/src/conf/ConfigurationSkeleton.h
@@ -28,6 +28,14 @@
/**
@author Jérémy Quentin <jeremy.quentin@gmail.com>
+ This class represents the config skeleton for the config dialog.
+ It inherits the KConfigSkeleton "ConfigurationSkeletonBase"generated
+ by sflphone-client-kde.kcfg which handles most of the settings.
+ This class handles the codec list.
+ A few complicated settings are handled directly by the config dialog
+ and its pages (accounts, sound managers).
+ This class reimplements the writeConfig and readConfig functions to ask the
+ daemon instead of the normal behavior (read and write in a kconfig file).
*/
class ConfigurationSkeleton : public ConfigurationSkeletonBase
{
@@ -54,12 +62,6 @@ public:
void setActiveCodecList(const QStringList & v);
CodecListModel * getCodecListModel();
-
-// protected:
-
-// virtual void usrReadConfig();
-
-
};
--
GitLab