- 06 Feb, 2015 1 commit
-
-
Guillaume Roguez authored
WARNING: GCC warns only with -Weffc++ option in a such situation. But we don't use it as is also very anoying. Refs #65446 Change-Id: I5ed4adbfa5aad5bc69d50e256035afd84ba601b3
-
- 05 Feb, 2015 1 commit
-
-
Guillaume Roguez authored
Refs #65511 Change-Id: Ic9026eea08456f6d94e93edbbc6ea13b3aea3735
-
- 04 Feb, 2015 7 commits
-
-
Alexandre Lision authored
This commit fixes coupling between udev and video, since udev is only available on Linux Refs #65446 Change-Id: I8ad782bbedb031b5973e202eff3487535aac3fb4
-
Stepan Salenikovich authored
Refs #65489
-
Only look for an IGD and remove existing port mappings the first time an account with UPnP enabled is registered. Also gets rid of upnp.h dependency in managerimpl.cpp. Refs #65267 Change-Id: I60c7608d66511b7caf6d990ec615bcfbf41765b7
-
avcodec_alloc_frame is an deprecated API. Now use av_frame_alloc. libav_deps.h take care of backward compatibility. Change-Id: Ifaf27e6908d09b5772c04fb819243901a3cb5660
-
Guillaume Roguez authored
Import various opendht fixes Refs #65401 Change-Id: I8234b0adb4e6cb091a14959c6c8705a667409170
-
Guillaume Roguez authored
Event loop duplicate event handler map before looping on it. So unregister an handler is not sync in this copy and can call dead stuff. Notice also registerEventHandler really replace the previous registered handler as it's expected. Refs #65401 Change-Id: Id2c27dd8ca42ee2a29fa3237bb836385deec11cd
-
Guillaume Roguez authored
Rationale: ice session must be destroyed before any other ressources. Refs #65401 Change-Id: Ib31fd1d09d5beb85692c975ed72e7f58d08c6792
-
- 03 Feb, 2015 8 commits
-
-
Emmanuel Lepage Vallee authored
Also rename security.h -> security_const.h Refs #65314 Change-Id: I1349b63b694c337e88c351a5b2d691145c5ff823
-
Prevent DHT port mapping from being deleted when doUnregister complete after doRegister Refs #65266 Change-Id: I7545e48e4c959478283d3d008b4bd0c54b5df3bf
-
Guillaume Roguez authored
Reordering implementation of SIPVoIPLink destructor. This fix dependencies issues. Refs #64903 Change-Id: I4f96359bd0708f79592bac325150edf7b149f843
-
Guillaume Roguez authored
Rationale: SipIceTranport was not standard-layout but a reinterpret_cast was called on one member to retrive the class. This "work" on Linux/gcc implementation but it's an undefined behavior and not portable. This changes the internal destroy transport callback: now PJSIP is the unique owner of the SipIceTransport instance and should call the destroy callback to delete the instance. By the way, we remove shutdown and destroy method as not more used. Side effect is the re-write of SipTransportBroker on how it handles instance of SipIceTransport. Refs #64903 Change-Id: I58848eca55c421de1883e53793fd58b0e1581d59
-
Guillaume Roguez authored
- move tp_state_callback from SipTransportBroker to SIPVoIPLink. - install/deinstall it in SIPVoIPLink constructor/destructor. Rationale: It's a endpoint related callback and SIPVoIPLink is the endpoint manager. Refs Change-Id: Iea2fdf1a7ce8681bc0cdf732eb6033314cb2cdf9
-
Guillaume Roguez authored
- thread-safe - check value during event loop Refs #64903 Change-Id: I84cb83f3a37fb77e5eff7d21e7f18d67fef7f288
-
Guillaume Roguez authored
Also requires to check getSIPVoIPLink return everywhere. Refs #64903 Change-Id: I8f62a38fd5e26efeb5d64a6a178352b4798dcbfa
-
Guillaume Roguez authored
- thread-safe - limit respawn (no limit by default) Refs #64903 Change-Id: Ie9b2465b6d4b064fa82454d389d4269805f0145d
-
- 02 Feb, 2015 1 commit
-
-
Guillaume Roguez authored
Note that iax has been modified also to remove a duplicate code at application wide. Refs #64903 Change-Id: Ie0739fa6b4cc66b4042837c920442e16fd50043f
-
- 01 Feb, 2015 4 commits
-
-
Guillaume Roguez authored
This patch fixes how the class SipTransportBroker handles mapping between our transport classes and the PJSIP transport structure. - remove unsafe SipIceTransport "onDestroy" callback that call invalidated objects (as the mutex) in some conditions. - handle ICE transports in the state-change callback. - unmap SipTransport before let our transport instances handle events. - shutdown remaining mapped transports at destructor. - minor changes in logging and indentation rules. Refs #64903 Change-Id: I975cca4e5cb4e2a5dee623985c956241902a6b92
-
Guillaume Roguez authored
- use a std::unique_ptr to handle the PJSIP transport (exception-proof). Deleter calls pjsip_transport_shutdown() then pjsip_transport_dec_ref(). - prevent a valid construction with invalid PJSIP transport. - use insert than map [] operator to not cause extra memory allocations. - minor: postfix private class member with an underscore. - minor: using-aliases prefered than typedef. - minor: code indentation fixes. Refs #64903 Change-Id: I1e78d119ca7291928d5148344be5c0258ca2c02e
-
Guillaume Roguez authored
This patch changes SipTransportBroker::findTransport() method by removing the possibility to map a pjsip transport if not found in the mapping. Rationale: This idiom breaks the expected behavior of the method and let unknown transports be handled by application. Alien transports have not to be handled by us. Now an handled transport is shutdown when SipTransport is destroyed, and the constructor throw an exception if this transport is given again... so impossible to "re-use" a shutdown'ed transport. Refs #64903 Change-Id: Ib06f8f9d567f1bc84bfe4764f4f6c1252f7dc9ec
-
Guillaume Roguez authored
Refs #64903 Change-Id: I2756df42b50a149645b722ffd64b5676b6c9953a
-
- 31 Jan, 2015 6 commits
-
-
Guillaume Roguez authored
This fix "single role" class design rule. Refs #64903 Change-Id: Idc8a82d04d13380bddad75c766fc7b3175a54ef1
-
Guillaume Roguez authored
Rationale: These methods depend on internal states owned by an other class (and obviously parameters). So why to not put them where theses states are really located? This is also not the role of the former class to gives these methods. Refs #64903 Change-Id: I539715cb63ed99acf5b579666588c88e280cde05
-
Guillaume Roguez authored
Remove ambiguity in code reading. Refs #64903 Change-Id: I98ef4b95406ca011933fb2152e844bf7c437ef27
-
Guillaume Roguez authored
Refs #64903 Change-Id: Ia21d2d3a2e2df54db11fa35690c81b9673a777ef
-
Guillaume Roguez authored
Refs #64903 Change-Id: Ia8986be9c7c4566e6f26e2b9bedaa09b0247a6db
-
Guillaume Roguez authored
Notes: yep, constexpr implies const... but the second one in following snippet, and not the first. const char* const foo = "bar"; Refs #64785 Refs #64828 Refs #64413 Change-Id: I59078f266e8c9a2cb2ad889955fdcb78bb1382c1
-
- 30 Jan, 2015 4 commits
-
-
Guillaume Roguez authored
Refs #64935 Change-Id: I8293e184087a9b526c3ba4a3db12d875b8313306
-
Refs #56702 Change-Id: I00694aca0849a82f56edaaf52643ef58a8b4b21d
-
Refs #64943 Change-Id: I2779c3d35647d91d422a7886a681b402b2011270
-
Stepan Salenikovich authored
Refs #64935 Change-Id: I8322d459466c4e0be27d760363a87058d49b89eb
-
- 28 Jan, 2015 8 commits
-
-
If upnp finds a device on the network but it cannot determine that it is a valid upnp device nor a valid IGD device, do not try to use it. Also gets rid of potential memory leak if chooseIGD() crashes. Refs #64828 Change-Id: Ibe0895ec8de043f7fcd1a1e9aa36e5b766091008
-
Refs #64874 Change-Id: If74722be3790971484db74611a139f1022a7b8c1
-
This commit also fix various issues with the TLSValidator: * Remove dead code (-Wunused) * Handle exeptions in configurationmanager (runtime assert) * Add missing construction initializer (-Wuninitialized) Refs #64785 Change-Id: I315396b2a3a29d097743ce825cda91235a6e7936
-
Refs #64008 Change-Id: I9bb649ff8b4cfc41cd38ce3e01e30ec9a0104b65
-
Refs #64797 Change-Id: Iccb874e9683894b4cc0589dc152f8a650a1eeaba
-
Refs #64797 Change-Id: Id157e67fc90876ee25414f0f771189d6de0dfba7
-
Refs #64797 Change-Id: Ieed7b25a0c04b2b50c58d828626a345ddfdb6903
-
Refs #64797 Change-Id: I338d8b1fb78a84f3c45a422817cd7d847098d637
-