1. 02 Oct, 2015 3 commits
  2. 01 Oct, 2015 1 commit
  3. 29 Sep, 2015 2 commits
  4. 28 Sep, 2015 1 commit
  5. 25 Sep, 2015 3 commits
    • Eloi Bail's avatar
      media/sinkclient: change registerSinkTarget API · c588b6be
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      API change: remove sharedptr parameter of registerSinkTarget,
      used for direct rendering. Instead use a client provided buffer.
      
      Client now has control of this buffer lifecycle.
      This API has to be used only when daemon and client both live
      in the same process.
      
      Issue: #80643
      Change-Id: Idd7dbc977cbc8fabcece2392388b2d5aac7d2cdc
      c588b6be
    • Eloi Bail's avatar
      media/encoder: set correctly buf size · 3b84b1cc
      Eloi Bail authored
      Buf size is needed to set correcty variable bitrate mode.
      It was set to a value equal to 0
      
      Issue: #80568
      Change-Id: Ie83367893ec830c1c2b5c10b94f46fd57b714221
      3b84b1cc
    • Edric Milaret's avatar
      scaler: use correct pixel format on scaler for yuv · 524a2d35
      Edric Milaret authored
      - This format shouldn't even be used by ffmpeg
      as they have deprecated it.
      
      Issue: #80842
      Change-Id: Ie284fad75458de71c23b2474dc0cac0a7ee272ae
      524a2d35
  6. 23 Sep, 2015 4 commits
    • Guillaume Roguez's avatar
      AudioRecord: fix memory leak · 823e9499
      Guillaume Roguez authored
      Use a shared_ptr to handle SndfileHandle object.
      Note: shared and not unique as we need declaration of SndfileHandle
      if AudioRecord has to be used into unique_ptr.
      
      Issue: #79703
      Change-Id: I27547111abc145958f7154e3bed30d92b2575da7
      823e9499
    • Eloi Bail's avatar
      tools/dringctrl: change bitrate only on video · 08b11036
      Eloi Bail authored
      Do not change bitrate on audio codecs. Only video
      
      Issue: #80498
      Change-Id: I6d305de2d3ba2156644a2f0ad72adb8efef72227
      08b11036
    • Guillaume Roguez's avatar
      call: remove dead code · 87917f1e
      Guillaume Roguez authored
      Remove time_stop() and timestamp_stop_ as never used
      
      Issue: #79703
      Change-Id: Ic0de9cddf0129042dac55e8788bc956aa5dd5727
      87917f1e
    • Guillaume Roguez's avatar
      AudioRecord: fix false positif in toggleRecording · b0d0d00c
      Guillaume Roguez authored
      AudioRecord::openFile() is called but returns not checked
      resulting into a possible recording startup on non-existant file.
      
      Issue: #79703
      Change-Id: Iefb273bddc119a00b0652e271e3bf91114be043d
      b0d0d00c
  7. 22 Sep, 2015 2 commits
    • Guillaume Roguez's avatar
      AudioRecord: fix concurrency access · 57fb8cbd
      Guillaume Roguez authored
      recordingEnabled_ was not thread safe.
      AudioRecorder is an example of class that does concurrent access
      on this member, througth AudioRecord::recData() inside a private thread.
      
      This patch also remove protected members (converted to private).
      
      Issue: #79703
      Change-Id: I4bf54000c512b6a79d89bc74eb238d6f098c4321
      57fb8cbd
    • Guillaume Roguez's avatar
      audiorecorder: use ThreadLoop · dbc4ace9
      Guillaume Roguez authored
      Use our integrated threadloop class than re-invent the weel.
      Also cleanup code using modern C++.
      
      Issue: #79703
      Change-Id: Ibc3b0da9d0d24b4fc17950b946c1c3b9f134cdc5
      dbc4ace9
  8. 21 Sep, 2015 2 commits
    • Guillaume Roguez's avatar
      update Copyright header · 5236ab05
      Guillaume Roguez authored
      - remove OpenSSL exception
      - fix Savoir-faire Linux naming
      - fix common Author: representation
      
      Issue: #80663
      Change-Id: I6c3b2ca1ed48ed474a0ecd5a30fe793526e11b00
      5236ab05
    • Eloi Bail's avatar
      media/encoder: use max bitrate if possible · ab24c146
      Eloi Bail authored
      define max bitrate for H264. Encoder could then use less bitrate
      if he can.
      It seems that it is not possible for VP8 et MPEG4
      
      Issue: #80568
      Change-Id: I8dc2cfc76ac02ef1f159a380a9e6ce31bc9eac06
      ab24c146
  9. 19 Sep, 2015 1 commit
    • Guillaume Roguez's avatar
      threadloop: fix deadlock issue · a25e653f
      Guillaume Roguez authored
      start() can deadlock into join if a previous stop has been called and
      the thread hasn't seen it before started again.
      
      This patch solves that by using a transactional stop (using FSM).
      This also adds MoveConstructible and MoveAssignement behaviour.
      
      Issue: #80556
      Change-Id: Ie04e3a20007e69b4d372b9619d67710f4e2af1b7
      a25e653f
  10. 18 Sep, 2015 4 commits
    • Alexandre Lision's avatar
      compilation: fix warnings · 8d9028f6
      Alexandre Lision authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Add override marker to explicit from where functions come from
      
      Issue: #80598
      Change-Id: I957afd713de22016220786145471d87c211064c8
      8d9028f6
    • Adrien Béraud's avatar
      audiolayer: prevent double-init · 6aeafbd0
      Adrien Béraud authored
      Issue: #80355
      Change-Id: I8d0a1c0391aa33b9c01e3cd1f1ed315e1a68fe14
      6aeafbd0
    • Eloi Bail's avatar
      contrib/ffmpeg: add rtpdec traces · a4e58ada
      Eloi Bail authored
      This patchset adds information about jitter buffer used in rtpdec.
      The first patch prints as warning when jitter buffer is full.
      The second patch prints as verbose jitter buffer size set by default in
      libav headers or by application.
      The third patch prints as waring when max delay on jitter buffer is
      reached
      
      Those traces are helpful to know the origin of decoding issues.
      Indeed a jitter buffer full or a max delay reached will lead to packet
      reordering failure and then to video decoding failure.
      
      Issue: #80483
      Change-Id: I7f123f04fe67c279391f153db5ea6f472759f8b2
      a4e58ada
    • Eloi Bail's avatar
      contrib/libav: add rtpdec traces · bd9f1426
      Eloi Bail authored
      This patchset adds information about jitter buffer used in rtpdec.
      The first patch prints as warning when jitter buffer is full.
      The second patch prints as verbose jitter buffer size set by default in
      libav headers or by application.
      The third patch prints as waring when max delay on jitter buffer is
      reached
      
      Those traces are helpful to know the origin of decoding issues.
      Indeed a jitter buffer full or a max delay reached will lead to packet
      reordering failure and then to video decoding failure.
      
      Issue: #80483
      Change-Id: I1351e9b607fd2ffa1223209389cfdb6162c9c93b
      bd9f1426
  11. 17 Sep, 2015 4 commits
    • Eloi Bail's avatar
      tools/dringctrl: select codecs to use in config · 38e050c4
      Eloi Bail authored and Eloi Bail's avatar Eloi Bail committed
      Add of audio and video codecs selection in config
      
      Issue: #80498
      Change-Id: Ic10a6f2894cec9732b7fbbe3a76ccdd3c4bb858a
      38e050c4
    • Eloi Bail's avatar
      media: tune decoder jitter buffer · 90dbad37
      Eloi Bail authored
      This patchset allows ring application to tune 2 parameters of
      libav jitter buffer:
      - buffer size: maximal amount of packets to be queued
      - packet delay: maximal amount of time a packet can be queued
      
      Tuning those values allows correct handling of packet reordering issues
      and network jitter.
      Notice that for the moment default libav values are set.
      
      Issue: #80311
      Change-Id: Ife4be65a12a01e381bc952b07741104f9a969213
      90dbad37
    • Eloi Bail's avatar
      tools: use config file for dringctrl.py · bc8615c0
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Use a config file (test_config.ini) to configure test environnement
      test_config.ini is provided as example
      
      Issue: #80498
      Change-Id: If0613d2264412af50e42f0a0eb151ecf741cbab4
      bc8615c0
    • Eloi Bail's avatar
      tools: refactor automatic call test tool · 9b3f4a27
      Eloi Bail authored
      Refactor of automatic call test tool
      Now do ./dringctrl --help : all test name will be listed
      ./dringctrl --test <testName> to execute a test
      
      Issue: #80498
      Change-Id: I86d16e7d96f04f040133f16856ba9ca8a061374d
      9b3f4a27
  12. 16 Sep, 2015 1 commit
    • Eloi Bail's avatar
      media: add libav default traces to warning · 6432f74f
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Default trace level is ERROR. In order to investigate
      video decoding issues, I change it to WARNING
      After stabilisation, we should reset it to ERROR.
      
      Issue: #79686
      Change-Id: I2e77e1759e46748ddbef6f6a60c6cba55c4d0a41
      6432f74f
  13. 15 Sep, 2015 3 commits
  14. 14 Sep, 2015 2 commits
  15. 12 Sep, 2015 1 commit
    • Eloi Bail's avatar
      media_decoder: increase jitter buffer size · 1cb755ae
      Eloi Bail authored
      jitter buffer size is by default equal to 10.
      We see often packets reordering (on internet) that can not be managed
      by jitter buffer sized to 10. We increase the jitter buffer size to 30.
      
      Notice that it would lead to more latency and thus potentially to
      desynchronisation
      
      Issue: #80311
      Change-Id: I8e6ba6faea2be74602c5e63fded1b0d896c7a847
      1cb755ae
  16. 11 Sep, 2015 2 commits
    • Stepan Salenikovich's avatar
      im: use pjsip api to create and parse messages · b7ee00ee
      Stepan Salenikovich authored and Guillaume Roguez's avatar Guillaume Roguez committed
      
      
      This supports both simple and multipart content types.
      
      *WARNING* the daemon API has not changed; however the previous
      implementation was not RFC compliant and thus messages sent from or
      received by a previous version of the daemon will not be interpreted
      correctly. Additionally the behaviour of the API has slightly changed.
      It will no longer split multiple message pairs received in the
      map<string, string> into multiple, separate SIP messages if they do not
      all fit into one. If there is only one pair in the map, then a message
      with a single content-type will be created and sent. If multiple pairs
      exist, then a multipart/mixed type message will be created. If the
      created message is too large to be sent, then no parts will be sent.
      
      Support for storing the URI of the original sender is dropped for now as it
      was not being used by the clients and the implementation was buggy.
      
      The APIs for creating XML recipient lists as defined by RFC 5365 remains
      but is no longer used for now.
      
      Issue: #79657
      Change-Id: I2b00cbd797fbb423ee0a7eb24748d2362e9f9ff8
      Signed-off-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      b7ee00ee
    • Guillaume Roguez's avatar
      utils: c++11'ify RING_ARRAYSIZE and CONST_PJ_STR macros · 6f868d66
      Guillaume Roguez authored
      Macros (C relica) are easly transformed into C++ using constexpr.
      Using template provides type-safe.
      
      RING_ARRAYSIZE becomes arraySize.
      CONST_PJ_STR has been also moved into sip_utils.
      
      Issue: #79703
      Change-Id: Ic197f53bbfeba363f0609908fa680f18529f8075
      6f868d66
  17. 04 Sep, 2015 4 commits
    • Eloi Bail's avatar
      rtp: ensure to synchronously update seq number · db771a00
      Eloi Bail authored
      
      
      When bitrate is changed, new RTP session created must rely
      on RTP sequence of previous RTP session in order to provide
      continous sequence numbers.
      This patchset ensures to keep last RTP sequence updated correctly
      ensuring that no new packet will be sent when bitrate change is performed.
      
      Issue: #80058
      Change-Id: Ia7fbecd19aa0ec648327307de3ce3f8eace163a0
      Signed-off-by: Guillaume Roguez's avatarGuillaume Roguez <guillaume.roguez@savoirfairelinux.com>
      db771a00
    • Guillaume Roguez's avatar
      socket_pair: fix system socket · 549fd8fc
      Guillaume Roguez authored and Eloi Bail's avatar Eloi Bail committed
      This patch tries to fix read errors on system socket when
      no data available.
      
      Issue: #80094
      Change-Id: I7306bb32402983a939e9eca6cc4dbcc4d854685c
      549fd8fc
    • Eloi Bail's avatar
      daemon: decrease default video bitrate · fefe9316
      Eloi Bail authored
      Decrease default video bitrate from 800 to 250 to adapt to slow connections
      
      Issue: #79686
      Change-Id: I5db1a8de025073a617ae5a2ff37c199a14354476
      fefe9316
    • Eloi Bail's avatar
      daemon: decrease RTP payload max size · 53297a6d
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      RTP packet maximum size must rely on maximum MTU size.
      Networks such as ADSL include PPPoE header that reduce maximum
      payload size.
      Notice that packets higher than MTU would lead to fragmentation
      by routers. With high bitrates in video, we want to avoid that.
      
      This patch proposes to reduce the maximum UDP payload size allowed
      to RTP to a value safe for PPPoE MTU.
      
      This value has been computed as follow:
      
      Ethernet MTU          = 1500 bytes
      PPPoE headers        -= 8
      IP headers           -= 24
      UDP headers          -= 8
      ----------------------------------
      Total for RTP payload = 1460 bytes
      
      Issue: #80080
      Change-Id: Ibc8d5943017f3cea3ac6e1f17f90a85f06755ebe
      53297a6d