- fix Coding Rules violation or better reability
- modern C++11 code fixes
- use #pragma once of .h file

Issue: #81174
Change-Id: I7442dbc0df0ff929e5472b4ba04b63264bead3d7

Handle VideoMixerSource list using std::unique_ptr pointers.
Move also VideoMixerSource definition in .cpp file as its private.

Issue: #81174
Change-Id: Ia38fd44b3f9e1e8506864c0d6226a69dcbe7f9ac

This dependency causes a almost complet build if only video_mixer
is changed.

Issue: #81174
Change-Id: I1d374b582e6f388962ff78f67ee03b967ee82779

- bump libvpx to latest release v1.4.0
- this patch disable ssse3 optimization for vp8 causing
access violation on win64 os

Issue: #80982
Change-Id: I308cbad5c60120aafb46f3efa05bb892069f2005

Eloi Bail authored Aug 28, 2015 and Guillaume Roguez committed Oct 02, 2015

Based on RTCP RR packets info, this patchset add a dichotomous algorithm that
converge to highest bitrate value.
Minimal and maximal bitrates are set by account.
Packet lost rate threshold is defined by call to 1%.

Issue: #78984
Change-Id: I8864a5e83bf93146e8bd0186bab0dde36fcd0348
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Eloi Bail authored Oct 01, 2015 and Guillaume Roguez committed Oct 02, 2015

Adding an interruptable thread loop class, derivated from ThreadLoop.
It implements wait_for function that can be interrupted when stop()
method is called.

Issue: #81210
Change-Id: I8fcbeedd3d39f901e2fa159ab1408486e317b052

Patch submited by Peter Kovář.

Usage of PIX_FMT_XXX flags is deprecated.
We shall use AV_PIX_FMT_FLAG_XXX now.

Issue: #80588
Change-Id: I944661ba8ed58ac6820f38dfbc9351e02314540b

lag-in-frames is missing and lead to codec initialization
failure on windows (using ffmpeg)

Issue: #80984
Change-Id: If23a93bd6e30e3130816c2b8b7927bffc95417c6

When investigating video frame loss, we saw some keyframes
lost after video start. With last improvement, this workaround
is useless.

Issue: #79690
Change-Id: I328c5a9b7cf4dd1e44fa89143ad9f05b9bd32c6f

- use #pragma once than define inclusion wall
- precise that NON_COPYABLE macro usage imposes
non-movable behavior by default.

Issue: #79703
Change-Id: Ic11c4e7978ac6664c8f9b6009f988e56047db720

Eloi Bail authored Sep 23, 2015 and Guillaume Roguez committed Sep 25, 2015

API change: remove sharedptr parameter of registerSinkTarget,
used for direct rendering. Instead use a client provided buffer.

Client now has control of this buffer lifecycle.
This API has to be used only when daemon and client both live
in the same process.

Issue: #80643
Change-Id: Idd7dbc977cbc8fabcece2392388b2d5aac7d2cdc

Buf size is needed to set correcty variable bitrate mode.
It was set to a value equal to 0

Issue: #80568
Change-Id: Ie83367893ec830c1c2b5c10b94f46fd57b714221

- This format shouldn't even be used by ffmpeg
as they have deprecated it.

Issue: #80842
Change-Id: Ie284fad75458de71c23b2474dc0cac0a7ee272ae

Use a shared_ptr to handle SndfileHandle object.
Note: shared and not unique as we need declaration of SndfileHandle
if AudioRecord has to be used into unique_ptr.

Issue: #79703
Change-Id: I27547111abc145958f7154e3bed30d92b2575da7

Do not change bitrate on audio codecs. Only video

Issue: #80498
Change-Id: I6d305de2d3ba2156644a2f0ad72adb8efef72227

Remove time_stop() and timestamp_stop_ as never used

Issue: #79703
Change-Id: Ic0de9cddf0129042dac55e8788bc956aa5dd5727

AudioRecord::openFile() is called but returns not checked
resulting into a possible recording startup on non-existant file.

Issue: #79703
Change-Id: Iefb273bddc119a00b0652e271e3bf91114be043d

recordingEnabled_ was not thread safe.
AudioRecorder is an example of class that does concurrent access
on this member, througth AudioRecord::recData() inside a private thread.

This patch also remove protected members (converted to private).

Issue: #79703
Change-Id: I4bf54000c512b6a79d89bc74eb238d6f098c4321

Use our integrated threadloop class than re-invent the weel.
Also cleanup code using modern C++.

Issue: #79703
Change-Id: Ibc3b0da9d0d24b4fc17950b946c1c3b9f134cdc5

- remove OpenSSL exception
- fix Savoir-faire Linux naming
- fix common Author: representation

Issue: #80663
Change-Id: I6c3b2ca1ed48ed474a0ecd5a30fe793526e11b00

define max bitrate for H264. Encoder could then use less bitrate
if he can.
It seems that it is not possible for VP8 et MPEG4

Issue: #80568
Change-Id: I8dc2cfc76ac02ef1f159a380a9e6ce31bc9eac06

start() can deadlock into join if a previous stop has been called and
the thread hasn't seen it before started again.

This patch solves that by using a transactional stop (using FSM).
This also adds MoveConstructible and MoveAssignement behaviour.

Issue: #80556
Change-Id: Ie04e3a20007e69b4d372b9619d67710f4e2af1b7

Alexandre Lision authored Sep 18, 2015 and Guillaume Roguez committed Sep 18, 2015

Add override marker to explicit from where functions come from

Issue: #80598
Change-Id: I957afd713de22016220786145471d87c211064c8

Issue: #80355
Change-Id: I8d0a1c0391aa33b9c01e3cd1f1ed315e1a68fe14

This patchset adds information about jitter buffer used in rtpdec.
The first patch prints as warning when jitter buffer is full.
The second patch prints as verbose jitter buffer size set by default in
libav headers or by application.
The third patch prints as waring when max delay on jitter buffer is
reached

Those traces are helpful to know the origin of decoding issues.
Indeed a jitter buffer full or a max delay reached will lead to packet
reordering failure and then to video decoding failure.

Issue: #80483
Change-Id: I7f123f04fe67c279391f153db5ea6f472759f8b2

This patchset adds information about jitter buffer used in rtpdec.
The first patch prints as warning when jitter buffer is full.
The second patch prints as verbose jitter buffer size set by default in
libav headers or by application.
The third patch prints as waring when max delay on jitter buffer is
reached

Those traces are helpful to know the origin of decoding issues.
Indeed a jitter buffer full or a max delay reached will lead to packet
reordering failure and then to video decoding failure.

Issue: #80483
Change-Id: I1351e9b607fd2ffa1223209389cfdb6162c9c93b

Eloi Bail authored Sep 17, 2015 and Eloi Bail committed Sep 17, 2015

Add of audio and video codecs selection in config

Issue: #80498
Change-Id: Ic10a6f2894cec9732b7fbbe3a76ccdd3c4bb858a

This patchset allows ring application to tune 2 parameters of
libav jitter buffer:
- buffer size: maximal amount of packets to be queued
- packet delay: maximal amount of time a packet can be queued

Tuning those values allows correct handling of packet reordering issues
and network jitter.
Notice that for the moment default libav values are set.

Issue: #80311
Change-Id: Ife4be65a12a01e381bc952b07741104f9a969213

Eloi Bail authored Sep 16, 2015 and Guillaume Roguez committed Sep 17, 2015

Use a config file (test_config.ini) to configure test environnement
test_config.ini is provided as example

Issue: #80498
Change-Id: If0613d2264412af50e42f0a0eb151ecf741cbab4

Refactor of automatic call test tool
Now do ./dringctrl --help : all test name will be listed
./dringctrl --test <testName> to execute a test

Issue: #80498
Change-Id: I86d16e7d96f04f040133f16856ba9ca8a061374d

Eloi Bail authored Sep 16, 2015 and Guillaume Roguez committed Sep 16, 2015

Default trace level is ERROR. In order to investigate
video decoding issues, I change it to WARNING
After stabilisation, we should reset it to ERROR.

Issue: #79686
Change-Id: I2e77e1759e46748ddbef6f6a60c6cba55c4d0a41

Eloi Bail authored Aug 19, 2015 and Guillaume Roguez committed Sep 15, 2015

RTCP RR packets are parsed and information is stored in
RtcpInfo struct.

Issue: #78983
Change-Id: I07538e08f5dd4e2635ea94070e16e286f879b358
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Alexandre Lision authored Sep 02, 2015 and Guillaume Roguez committed Sep 15, 2015

Restricting to one causes problems on Android, where it is sometimes necessary
to restart the daemon during the same execution runtime.

Issue: #77994
Change-Id: I36bd27c82dd627f7b0645eb8620850ff6c0c9fe8

Issue: #80355
Change-Id: I79b5a51549c30f0af14889d4e1d79ff32685de5c

Adrien Béraud authored Sep 14, 2015 and Guillaume Roguez committed Sep 14, 2015

Was not working with the NDK tool chain

Issue: #78221
Change-Id: I7b8fd4eaebce410b41efe955b0fa800cf8319d4c
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

- removes functions to create XML uri list, which are no longer used
- without these functions, lib expat is no longer required

Issue: #79618
Change-Id: I8511d09dc707f3244700f4d396c7f81a01176982

jitter buffer size is by default equal to 10.
We see often packets reordering (on internet) that can not be managed
by jitter buffer sized to 10. We increase the jitter buffer size to 30.

Notice that it would lead to more latency and thus potentially to
desynchronisation

Issue: #80311
Change-Id: I8e6ba6faea2be74602c5e63fded1b0d896c7a847

Stepan Salenikovich authored Sep 11, 2015 and Guillaume Roguez committed Sep 11, 2015

This supports both simple and multipart content types.

*WARNING* the daemon API has not changed; however the previous
implementation was not RFC compliant and thus messages sent from or
received by a previous version of the daemon will not be interpreted
correctly. Additionally the behaviour of the API has slightly changed.
It will no longer split multiple message pairs received in the
map<string, string> into multiple, separate SIP messages if they do not
all fit into one. If there is only one pair in the map, then a message
with a single content-type will be created and sent. If multiple pairs
exist, then a multipart/mixed type message will be created. If the
created message is too large to be sent, then no parts will be sent.

Support for storing the URI of the original sender is dropped for now as it
was not being used by the clients and the implementation was buggy.

The APIs for creating XML recipient lists as defined by RFC 5365 remains
but is no longer used for now.

Issue: #79657
Change-Id: I2b00cbd797fbb423ee0a7eb24748d2362e9f9ff8
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Macros (C relica) are easly transformed into C++ using constexpr.
Using template provides type-safe.

RING_ARRAYSIZE becomes arraySize.
CONST_PJ_STR has been also moved into sip_utils.

Issue: #79703
Change-Id: Ic197f53bbfeba363f0609908fa680f18529f8075

When bitrate is changed, new RTP session created must rely
on RTP sequence of previous RTP session in order to provide
continous sequence numbers.
This patchset ensures to keep last RTP sequence updated correctly
ensuring that no new packet will be sent when bitrate change is performed.

Issue: #80058
Change-Id: Ia7fbecd19aa0ec648327307de3ce3f8eace163a0
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>