1. 13 Oct, 2015 1 commit
    • Guillaume Roguez's avatar
      media_encoder: disable sdp related logging · 57bc2d33
      Guillaume Roguez authored
      - refactored media_encoder::print_sdp(): log result only if DEBUG_SDP build variable is defined
      - video_sender: remove sdp_ variable seems not to be used anywhere
      
      Issue: #81581
      Change-Id: I191e520d2ff81907adf9db90dfdf96616d3c50d4
      57bc2d33
  2. 09 Oct, 2015 1 commit
    • Guillaume Roguez's avatar
      video: remove dead code · 0fa0715a
      Guillaume Roguez authored
      This patchset removes VideoProvider class not used anywhere.
      
      Issue: #81116
      Change-Id: I2e32dbe174d1168c75698e00a1104cbefb0ec71f
      0fa0715a
  3. 08 Oct, 2015 1 commit
    • Eloi Bail's avatar
      media: decrease max video bitrate to 2Mbits/s · f23071fa
      Eloi Bail authored
      H264 baseline profile level 2 is used by default for encoding.
      According to RFC max bitrate supported for this profile is 2Mbit/s.
      Test results with this max bitrate show acceptable video quality. A proper
      max bitrate determination algorithm will be developped in the future based on
      video source information such as resolution, framerate.
      
      Issue: #79686
      Change-Id: I2863ff3ef581ad520f695e649d014a8c964213fa
      f23071fa
  4. 07 Oct, 2015 2 commits
  5. 05 Oct, 2015 2 commits
    • Guillaume Roguez's avatar
      threadloop: fix race condition in get_id access · efd4a93a
      Guillaume Roguez authored
      threadloop::get_id() can be called with a non-initialized thread_ variable.
      If this call is done under the loop thread, right after its creation,
      and if InterruptedThreadLoop::wait_for is call, an non catched exception
      is thrown and std::terminate stops all the application.
      This patch proposes to fix this race condition and fix the non-catched
      exception to let the application in a safe state.
      
      Issue: #81210
      Change-Id: I3d8409ac505be181d1a54c5bdd0e679fdb81bf88
      efd4a93a
    • Eloi Bail's avatar
      media: remove useless trace · 66015aef
      Eloi Bail authored
      Warning only if bitrate is effectively changed.
      
      Issue: #78984
      Change-Id: I6203d88ad519d448e33aa016941ff92d262427c5
      66015aef
  6. 03 Oct, 2015 1 commit
    • Guillaume Roguez's avatar
      build: remove annoying warnings on gcc5 build · 624f699a
      Guillaume Roguez authored
      Tons of warning are emited and trash the build log output
      during build of dbus adaptors if GCC-5 or later is used,
      due to wrong GCC version check.
      
      Issue: #81427
      Change-Id: I8fdbb759feeb68efb189a796de8f3b6ea39c4c0e
      624f699a
  7. 02 Oct, 2015 7 commits
  8. 01 Oct, 2015 1 commit
  9. 29 Sep, 2015 2 commits
  10. 28 Sep, 2015 1 commit
  11. 25 Sep, 2015 3 commits
    • Eloi Bail's avatar
      media/sinkclient: change registerSinkTarget API · c588b6be
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      API change: remove sharedptr parameter of registerSinkTarget,
      used for direct rendering. Instead use a client provided buffer.
      
      Client now has control of this buffer lifecycle.
      This API has to be used only when daemon and client both live
      in the same process.
      
      Issue: #80643
      Change-Id: Idd7dbc977cbc8fabcece2392388b2d5aac7d2cdc
      c588b6be
    • Eloi Bail's avatar
      media/encoder: set correctly buf size · 3b84b1cc
      Eloi Bail authored
      Buf size is needed to set correcty variable bitrate mode.
      It was set to a value equal to 0
      
      Issue: #80568
      Change-Id: Ie83367893ec830c1c2b5c10b94f46fd57b714221
      3b84b1cc
    • Edric Milaret's avatar
      scaler: use correct pixel format on scaler for yuv · 524a2d35
      Edric Milaret authored
      - This format shouldn't even be used by ffmpeg
      as they have deprecated it.
      
      Issue: #80842
      Change-Id: Ie284fad75458de71c23b2474dc0cac0a7ee272ae
      524a2d35
  12. 23 Sep, 2015 4 commits
    • Guillaume Roguez's avatar
      AudioRecord: fix memory leak · 823e9499
      Guillaume Roguez authored
      Use a shared_ptr to handle SndfileHandle object.
      Note: shared and not unique as we need declaration of SndfileHandle
      if AudioRecord has to be used into unique_ptr.
      
      Issue: #79703
      Change-Id: I27547111abc145958f7154e3bed30d92b2575da7
      823e9499
    • Eloi Bail's avatar
      tools/dringctrl: change bitrate only on video · 08b11036
      Eloi Bail authored
      Do not change bitrate on audio codecs. Only video
      
      Issue: #80498
      Change-Id: I6d305de2d3ba2156644a2f0ad72adb8efef72227
      08b11036
    • Guillaume Roguez's avatar
      call: remove dead code · 87917f1e
      Guillaume Roguez authored
      Remove time_stop() and timestamp_stop_ as never used
      
      Issue: #79703
      Change-Id: Ic0de9cddf0129042dac55e8788bc956aa5dd5727
      87917f1e
    • Guillaume Roguez's avatar
      AudioRecord: fix false positif in toggleRecording · b0d0d00c
      Guillaume Roguez authored
      AudioRecord::openFile() is called but returns not checked
      resulting into a possible recording startup on non-existant file.
      
      Issue: #79703
      Change-Id: Iefb273bddc119a00b0652e271e3bf91114be043d
      b0d0d00c
  13. 22 Sep, 2015 2 commits
    • Guillaume Roguez's avatar
      AudioRecord: fix concurrency access · 57fb8cbd
      Guillaume Roguez authored
      recordingEnabled_ was not thread safe.
      AudioRecorder is an example of class that does concurrent access
      on this member, througth AudioRecord::recData() inside a private thread.
      
      This patch also remove protected members (converted to private).
      
      Issue: #79703
      Change-Id: I4bf54000c512b6a79d89bc74eb238d6f098c4321
      57fb8cbd
    • Guillaume Roguez's avatar
      audiorecorder: use ThreadLoop · dbc4ace9
      Guillaume Roguez authored
      Use our integrated threadloop class than re-invent the weel.
      Also cleanup code using modern C++.
      
      Issue: #79703
      Change-Id: Ibc3b0da9d0d24b4fc17950b946c1c3b9f134cdc5
      dbc4ace9
  14. 21 Sep, 2015 2 commits
    • Guillaume Roguez's avatar
      update Copyright header · 5236ab05
      Guillaume Roguez authored
      - remove OpenSSL exception
      - fix Savoir-faire Linux naming
      - fix common Author: representation
      
      Issue: #80663
      Change-Id: I6c3b2ca1ed48ed474a0ecd5a30fe793526e11b00
      5236ab05
    • Eloi Bail's avatar
      media/encoder: use max bitrate if possible · ab24c146
      Eloi Bail authored
      define max bitrate for H264. Encoder could then use less bitrate
      if he can.
      It seems that it is not possible for VP8 et MPEG4
      
      Issue: #80568
      Change-Id: I8dc2cfc76ac02ef1f159a380a9e6ce31bc9eac06
      ab24c146
  15. 19 Sep, 2015 1 commit
    • Guillaume Roguez's avatar
      threadloop: fix deadlock issue · a25e653f
      Guillaume Roguez authored
      start() can deadlock into join if a previous stop has been called and
      the thread hasn't seen it before started again.
      
      This patch solves that by using a transactional stop (using FSM).
      This also adds MoveConstructible and MoveAssignement behaviour.
      
      Issue: #80556
      Change-Id: Ie04e3a20007e69b4d372b9619d67710f4e2af1b7
      a25e653f
  16. 18 Sep, 2015 4 commits
    • Alexandre Lision's avatar
      compilation: fix warnings · 8d9028f6
      Alexandre Lision authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Add override marker to explicit from where functions come from
      
      Issue: #80598
      Change-Id: I957afd713de22016220786145471d87c211064c8
      8d9028f6
    • Adrien Béraud's avatar
      audiolayer: prevent double-init · 6aeafbd0
      Adrien Béraud authored
      Issue: #80355
      Change-Id: I8d0a1c0391aa33b9c01e3cd1f1ed315e1a68fe14
      6aeafbd0
    • Eloi Bail's avatar
      contrib/ffmpeg: add rtpdec traces · a4e58ada
      Eloi Bail authored
      This patchset adds information about jitter buffer used in rtpdec.
      The first patch prints as warning when jitter buffer is full.
      The second patch prints as verbose jitter buffer size set by default in
      libav headers or by application.
      The third patch prints as waring when max delay on jitter buffer is
      reached
      
      Those traces are helpful to know the origin of decoding issues.
      Indeed a jitter buffer full or a max delay reached will lead to packet
      reordering failure and then to video decoding failure.
      
      Issue: #80483
      Change-Id: I7f123f04fe67c279391f153db5ea6f472759f8b2
      a4e58ada
    • Eloi Bail's avatar
      contrib/libav: add rtpdec traces · bd9f1426
      Eloi Bail authored
      This patchset adds information about jitter buffer used in rtpdec.
      The first patch prints as warning when jitter buffer is full.
      The second patch prints as verbose jitter buffer size set by default in
      libav headers or by application.
      The third patch prints as waring when max delay on jitter buffer is
      reached
      
      Those traces are helpful to know the origin of decoding issues.
      Indeed a jitter buffer full or a max delay reached will lead to packet
      reordering failure and then to video decoding failure.
      
      Issue: #80483
      Change-Id: I1351e9b607fd2ffa1223209389cfdb6162c9c93b
      bd9f1426
  17. 17 Sep, 2015 4 commits
    • Eloi Bail's avatar
      tools/dringctrl: select codecs to use in config · 38e050c4
      Eloi Bail authored and Eloi Bail's avatar Eloi Bail committed
      Add of audio and video codecs selection in config
      
      Issue: #80498
      Change-Id: Ic10a6f2894cec9732b7fbbe3a76ccdd3c4bb858a
      38e050c4
    • Eloi Bail's avatar
      media: tune decoder jitter buffer · 90dbad37
      Eloi Bail authored
      This patchset allows ring application to tune 2 parameters of
      libav jitter buffer:
      - buffer size: maximal amount of packets to be queued
      - packet delay: maximal amount of time a packet can be queued
      
      Tuning those values allows correct handling of packet reordering issues
      and network jitter.
      Notice that for the moment default libav values are set.
      
      Issue: #80311
      Change-Id: Ife4be65a12a01e381bc952b07741104f9a969213
      90dbad37
    • Eloi Bail's avatar
      tools: use config file for dringctrl.py · bc8615c0
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Use a config file (test_config.ini) to configure test environnement
      test_config.ini is provided as example
      
      Issue: #80498
      Change-Id: If0613d2264412af50e42f0a0eb151ecf741cbab4
      bc8615c0
    • Eloi Bail's avatar
      tools: refactor automatic call test tool · 9b3f4a27
      Eloi Bail authored
      Refactor of automatic call test tool
      Now do ./dringctrl --help : all test name will be listed
      ./dringctrl --test <testName> to execute a test
      
      Issue: #80498
      Change-Id: I86d16e7d96f04f040133f16856ba9ca8a061374d
      9b3f4a27
  18. 16 Sep, 2015 1 commit
    • Eloi Bail's avatar
      media: add libav default traces to warning · 6432f74f
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      Default trace level is ERROR. In order to investigate
      video decoding issues, I change it to WARNING
      After stabilisation, we should reset it to ERROR.
      
      Issue: #79686
      Change-Id: I2e77e1759e46748ddbef6f6a60c6cba55c4d0a41
      6432f74f