Eloi Bail authored Oct 08, 2015 and Guillaume Roguez committed Oct 15, 2015

If video_rtp_session is restarted due to bitrate changement
we need to setup again conferencepipeline. Otherwise videomixer sink
would be never attached and video never send.

Issue: #81547
Change-Id: I6de180afab5a7dd320fe3b31a1d61735106d76d1

Adrien Béraud authored Jul 24, 2015 and Guillaume Roguez committed Oct 14, 2015

Experimental

Issue: #81125
Change-Id: Id0e579fa0fd70ef152c7e4074ed713730b542923

This patchset prevents client from reading a frame that is being written
by the daemon using a push/pull mechanism.

**WARNING** This breaks the direct rendering API

Issue: #81542
Change-Id: I55d4ee9b986ac682903b326fd86c32d8f5f68825
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Account level text messages only reported the SIP userrname
instead of the full SIP URI username@hostname.

This prevented clients to preperly recorgnise the sender.
The proper URI is now reported.

Issue: #81724
Change-Id: Id37b658340d07e14d6cda685d68872b634429306

Issue: #78220
Change-Id: Ibc89d02ad226a9ac003ae2adb3a476b3b714d911

std::stoi is not available on Android

Issue: #78221
Change-Id: I3cf69dba62c8d4e5bf3f946340cd44a8c08a788e

Arbitrate DRing::VideoSignal::DecodingStopped signal to not
emitting it if not previously started.
This prevents client troubles if they don't handle well
this behavior.

Issue: #81116
Change-Id: Ib08801d2f62795550238bc91810e6bf139376553

- refactored media_encoder::print_sdp(): log result only if DEBUG_SDP build variable is defined
- video_sender: remove sdp_ variable seems not to be used anywhere

Issue: #81581
Change-Id: I191e520d2ff81907adf9db90dfdf96616d3c50d4

This patchset removes VideoProvider class not used anywhere.

Issue: #81116
Change-Id: I2e32dbe174d1168c75698e00a1104cbefb0ec71f

H264 baseline profile level 2 is used by default for encoding.
According to RFC max bitrate supported for this profile is 2Mbit/s.
Test results with this max bitrate show acceptable video quality. A proper
max bitrate determination algorithm will be developped in the future based on
video source information such as resolution, framerate.

Issue: #79686
Change-Id: I2863ff3ef581ad520f695e649d014a8c964213fa

Eloi Bail authored Oct 05, 2015 and Guillaume Roguez committed Oct 07, 2015

add method to get codec details of an account

Issue: #81048
Change-Id: I0889ef08a94d0fb642ba85f7f3cc3bff380033b9

If the connection state changes to disconnected while a
call is on hold, it should still emit a stateChanged signal
with HUNGUP as the new state.

Issue: #81544
Change-Id: I866bbb9f9cf666bc5d8b2113ab69b01a9ec40fbd

threadloop::get_id() can be called with a non-initialized thread_ variable.
If this call is done under the loop thread, right after its creation,
and if InterruptedThreadLoop::wait_for is call, an non catched exception
is thrown and std::terminate stops all the application.
This patch proposes to fix this race condition and fix the non-catched
exception to let the application in a safe state.

Issue: #81210
Change-Id: I3d8409ac505be181d1a54c5bdd0e679fdb81bf88

Warning only if bitrate is effectively changed.

Issue: #78984
Change-Id: I6203d88ad519d448e33aa016941ff92d262427c5

Tons of warning are emited and trash the build log output
during build of dbus adaptors if GCC-5 or later is used,
due to wrong GCC version check.

Issue: #81427
Change-Id: I8fdbb759feeb68efb189a796de8f3b6ea39c4c0e

This problem happens on system without video camera.
Without this checks, the process function loops with log error message,
at each incoming frame from peers

Issue: #81174
Change-Id: Icfdda3c67f79ee01559ae15b9f61b53e607fd626

- fix Coding Rules violation or better reability
- modern C++11 code fixes
- use #pragma once of .h file

Issue: #81174
Change-Id: I7442dbc0df0ff929e5472b4ba04b63264bead3d7

Handle VideoMixerSource list using std::unique_ptr pointers.
Move also VideoMixerSource definition in .cpp file as its private.

Issue: #81174
Change-Id: Ia38fd44b3f9e1e8506864c0d6226a69dcbe7f9ac

This dependency causes a almost complet build if only video_mixer
is changed.

Issue: #81174
Change-Id: I1d374b582e6f388962ff78f67ee03b967ee82779

- bump libvpx to latest release v1.4.0
- this patch disable ssse3 optimization for vp8 causing
access violation on win64 os

Issue: #80982
Change-Id: I308cbad5c60120aafb46f3efa05bb892069f2005

Eloi Bail authored Aug 28, 2015 and Guillaume Roguez committed Oct 02, 2015

Based on RTCP RR packets info, this patchset add a dichotomous algorithm that
converge to highest bitrate value.
Minimal and maximal bitrates are set by account.
Packet lost rate threshold is defined by call to 1%.

Issue: #78984
Change-Id: I8864a5e83bf93146e8bd0186bab0dde36fcd0348
Signed-off-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Eloi Bail authored Oct 01, 2015 and Guillaume Roguez committed Oct 02, 2015

Adding an interruptable thread loop class, derivated from ThreadLoop.
It implements wait_for function that can be interrupted when stop()
method is called.

Issue: #81210
Change-Id: I8fcbeedd3d39f901e2fa159ab1408486e317b052

Patch submited by Peter Kovář.

Usage of PIX_FMT_XXX flags is deprecated.
We shall use AV_PIX_FMT_FLAG_XXX now.

Issue: #80588
Change-Id: I944661ba8ed58ac6820f38dfbc9351e02314540b

lag-in-frames is missing and lead to codec initialization
failure on windows (using ffmpeg)

Issue: #80984
Change-Id: If23a93bd6e30e3130816c2b8b7927bffc95417c6

When investigating video frame loss, we saw some keyframes
lost after video start. With last improvement, this workaround
is useless.

Issue: #79690
Change-Id: I328c5a9b7cf4dd1e44fa89143ad9f05b9bd32c6f

- use #pragma once than define inclusion wall
- precise that NON_COPYABLE macro usage imposes
non-movable behavior by default.

Issue: #79703
Change-Id: Ic11c4e7978ac6664c8f9b6009f988e56047db720

Eloi Bail authored Sep 23, 2015 and Guillaume Roguez committed Sep 25, 2015

API change: remove sharedptr parameter of registerSinkTarget,
used for direct rendering. Instead use a client provided buffer.

Client now has control of this buffer lifecycle.
This API has to be used only when daemon and client both live
in the same process.

Issue: #80643
Change-Id: Idd7dbc977cbc8fabcece2392388b2d5aac7d2cdc

Buf size is needed to set correcty variable bitrate mode.
It was set to a value equal to 0

Issue: #80568
Change-Id: Ie83367893ec830c1c2b5c10b94f46fd57b714221

- This format shouldn't even be used by ffmpeg
as they have deprecated it.

Issue: #80842
Change-Id: Ie284fad75458de71c23b2474dc0cac0a7ee272ae

Use a shared_ptr to handle SndfileHandle object.
Note: shared and not unique as we need declaration of SndfileHandle
if AudioRecord has to be used into unique_ptr.

Issue: #79703
Change-Id: I27547111abc145958f7154e3bed30d92b2575da7

Do not change bitrate on audio codecs. Only video

Issue: #80498
Change-Id: I6d305de2d3ba2156644a2f0ad72adb8efef72227

Remove time_stop() and timestamp_stop_ as never used

Issue: #79703
Change-Id: Ic0de9cddf0129042dac55e8788bc956aa5dd5727

AudioRecord::openFile() is called but returns not checked
resulting into a possible recording startup on non-existant file.

Issue: #79703
Change-Id: Iefb273bddc119a00b0652e271e3bf91114be043d

recordingEnabled_ was not thread safe.
AudioRecorder is an example of class that does concurrent access
on this member, througth AudioRecord::recData() inside a private thread.

This patch also remove protected members (converted to private).

Issue: #79703
Change-Id: I4bf54000c512b6a79d89bc74eb238d6f098c4321

Use our integrated threadloop class than re-invent the weel.
Also cleanup code using modern C++.

Issue: #79703
Change-Id: Ibc3b0da9d0d24b4fc17950b946c1c3b9f134cdc5

- remove OpenSSL exception
- fix Savoir-faire Linux naming
- fix common Author: representation

Issue: #80663
Change-Id: I6c3b2ca1ed48ed474a0ecd5a30fe793526e11b00

define max bitrate for H264. Encoder could then use less bitrate
if he can.
It seems that it is not possible for VP8 et MPEG4

Issue: #80568
Change-Id: I8dc2cfc76ac02ef1f159a380a9e6ce31bc9eac06

start() can deadlock into join if a previous stop has been called and
the thread hasn't seen it before started again.

This patch solves that by using a transactional stop (using FSM).
This also adds MoveConstructible and MoveAssignement behaviour.

Issue: #80556
Change-Id: Ie04e3a20007e69b4d372b9619d67710f4e2af1b7

Alexandre Lision authored Sep 18, 2015 and Guillaume Roguez committed Sep 18, 2015

Add override marker to explicit from where functions come from

Issue: #80598
Change-Id: I957afd713de22016220786145471d87c211064c8

Issue: #80355
Change-Id: I8d0a1c0391aa33b9c01e3cd1f1ed315e1a68fe14