When removing a contact, we need to update the ID of its linked
conversation (to be empty, which is the convention used to signify that
a contact doesn't have a linked conversation).

This used to be done via the updateConvForContact function, but there
were two issues (which are fixed by this patch):
1) if the user had multiple one-to-one conversations with the removed
   contact, then the function would be called multiple times (once per
   conversation) even though the update only needs to be performed once;
2) more importantly, if the contact's linked conversation ID didn't
   match any of its one-to-one conversations, then the update would not
   be performed at all. (Every contact should normally be linked to a
   valid conversation, but this can fail in practice due to
   synchronization issues.) As a result, the contact would remain linked
   to a conversation that no longer exists.

jami-client-qt#1673
jami-client-qt#1804

Change-Id: Ia75c5b27a4120bc48da5f449a874354326c6d96a

Adrien Béraud authored 1 month ago and Adrien Béraud committed 1 month ago

Change-Id: I480edbe0fb14f4b4758a681fb789cb30385d4982

Léopold Chappuis authored 1 month ago and Adrien Béraud committed 1 month ago

Change-Id: Ifb3d176bc37c4ecbc6ce9ff682e7721d55ea7e0f

Pierre Nicolas authored 1 month ago and Adrien Béraud committed 1 month ago

Removed legacy code that was causing options to be cleared unnecessarily.

Change-Id: I02b32221acc6abfef634ba843549c6391c2058c8

GitLab: #1101
Change-Id: Ifaee9fe0a2b79716e00ccc1a12c8c78c348e80bf

Adrien Béraud authored 1 month ago and François-Simon Fauteux-Chapleau committed 1 month ago

GitLab: #1104
Change-Id: I8d5c0a1fdb2f9bfc84f442e1323216ae3100da6d

Given the change made in commit
e048f1b9, it no longer makes sense to
use a null pointer as the default value for the optHistory argument of
the addToHistory function.

GitLab: #1102
Change-Id: Ifc5ca8b069c16d7d9cca2cbc0c8237c56895ff4e

Change-Id: Icd57e9a33b58c97ef9df18531510fb9590a9ee73

Change-Id: I68f4aab6d1588a53aaaf5757cb9dc20b8e6d8b8d

GitLab: #1100
Change-Id: I6ae6d125c730fc9a8a2125b9b6da68c005922bce

GitLab: #1100
Change-Id: I22255a2b34e5c33d1db4c1a02747874512372d5b

remove artificial const signature for announce and addToHistory

Change-Id: I2edbffeaaaff4bbfa68122fa96ed23aa8859dc0b

Change-Id: I178b437e99cf31c13622df136d635ff2147a04a9

Adrien Béraud authored 1 month ago and Adrien Béraud committed 1 month ago

Prevents multiple requests to JAMS for every message sent.

Change-Id: I17a0e9b885730979b10c635dd99ac3d37bef69bd

Adrien Béraud authored 1 month ago and Adrien Béraud committed 1 month ago

Change-Id: I65c99d62848b2d18e5c54e7b8ec28219320fb363

Change-Id: I7cb060661c89ea4839bafd87ad5b224e5faa785e

Change-Id: Idaf8e45775d2b76a9b306563baa074c7484ff68c

ovari authored 2 months ago and ovari committed 2 months ago

Change-Id: Ied16cc4536b4abe4740bfa76beb6e2fb1210439e

Change-Id: Ia92378315f88051de76311d23156c1eb85c07770

Change-Id: I527d834dac6fb2f57c879d02afd09c529f95b5fe

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I1aa416e952c2b38107c6534e104601641fabbf5f

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I8f11b6ede9701ba7770c7c774e87b6028dda117b

ovari authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I553a183700ecdd3b5a8740cb962169a3037e3696

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

GitLab: #1097
Change-Id: I742d1306007b3ae4908ee2d46bd5275d1ce2c99a

Léopold Chappuis authored 2 months ago and Adrien Béraud committed 2 months ago

resolved a segfault triggered by multiple clients accessing and calling clearCache simultaneously during conversation loading.

Change-Id: Ic2b134d67d1a207f45e52c5aedeee5712ead14ba

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I1731d5b876bde9c0d954d36e9644988dedeca079

ovari authored 2 months ago and ovari committed 2 months ago

Change-Id: Ib969e576919058468e88786adccbda9d672e7af4

This patch removes the callback argument to the doUnregister function,
which wasn't really needed since it was always called right before
returning from the function.

The patch also removes all calls to the shutdownConnections function
outside of doUnregister, and instead adds a boolean argument to
doUnregister to allow the caller to specify if they want the connections
to be shut down. This is a preparatory step for fixing the bug described
in the GitLab issue linked below.

GitLab: #1095
Change-Id: Ic78659f2e00684fd1db91c0ee3cf894a53d558ce

Change-Id: I67ab26f9fe3d4afcb682e60db25c97b1f07ebb5e

This should fix the following issue:
jami-client-qt#1898

Change-Id: I508e02b7fd1870228801dc7f773ff586f439c4ed

Change-Id: I8b66fe04a4ed5b1aa14da99cde3b7c84d1361e2d

Change-Id: Iaf9e4019c3c15b106bf8db6841c9fd43d1785640

Change-Id: I8b2d628acfdcad83983e12409b5c033a318a6bf4

Change-Id: Iaa92e035fe4ac6a09e1586e7f4d681ecf1b053f4

GitLab: #1093
Change-Id: Iaaed6d86dba597b7b4435a98022aad163599c9fb

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: Ia2858d7dab79954312b657ea4380f0ea65bfa640

Léopold Chappuis authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I9853bfd5742f751c4e20ee4668feed550013561a

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: Ia3ec3a96660821175d52c0120642c7c6fc946d1c

Change-Id: I7ceb5c0809918ca53cbcf2bc1c0d8efff586f960

Change-Id: I2753c58c12d167ee5f7454e5a2ed893991c90e24