1. 24 Oct, 2015 1 commit
  2. 23 Oct, 2015 1 commit
  3. 22 Oct, 2015 1 commit
  4. 20 Oct, 2015 3 commits
    • Guillaume Roguez's avatar
      rtp: fix RtpSession::restartSender() · 761d38e6
      Guillaume Roguez authored
      Calling this API causes a race condition with RtpSession::start().
      The former needs the latter to be run first, this was not enforced,
      causing a crash by nullptr access on socketPair_ member.
      This patch checks for a non-nullptr socketPair_ to procceed the restart.
      
      Issue: #81987
      Change-Id: I20886fe70398f018621aade1c7bac3ff15ef9055
      761d38e6
    • Guillaume Roguez's avatar
      manager: fix nullptr access in Manager::sendCallTextMessage · fe932995
      Guillaume Roguez authored
      Call::getCallId() method is accessed in a nullptr pointer context.
      This patch fix it by using the user given callId.
      
      Issue: #82045
      Change-Id: I8700aeaa173706909cf303be6d1efff5a4d1fc44
      fe932995
    • Guillaume Roguez's avatar
      video: remove blink fx during conference · 82edcbbf
      Guillaume Roguez authored
      During a conference, video display blink on a full black image
      at each video restart (due to adaptative bitrate algorithm).
      This patch fixes this effect due to an unvoluntary mixer's sink
      start/stop.
      
      Issue: #82044
      Change-Id: I181051de7230189d0a951f65f02b5673f202ffb5
      82edcbbf
  5. 19 Oct, 2015 5 commits
    • Alexandre Lision's avatar
      video: change pixfmt used by VideoMixer · 7f7bc0e7
      Alexandre Lision authored and Guillaume Roguez's avatar Guillaume Roguez committed
      YUV420P was allocating one large buffer on Linux and 3 on OSX.
      This was causing read overflows. We use YUYV422 which is packed (always one buf)
      
      Issue: #81116
      Change-Id: I76456f72c6f155d181aa533aa62cb70b92f6eff1
      7f7bc0e7
    • Guillaume Roguez's avatar
      video_scaler: fix VideoScaler::scale_and_pad · b0a4abc8
      Guillaume Roguez authored
      This method doesn't shift correctly in case of YUYV422 output format.
      This patch simplify the code and force the x-shift to be correct.
      
      Issue: #81116
      Change-Id: I049d61f51a944476f5a1c3743ecb905308becc83
      b0a4abc8
    • Guillaume Roguez's avatar
      video: fix VideoFrame::yuv422_clear_to_black() · 485da039
      Guillaume Roguez authored
      This method wasn't able to treat some non-planar YUV pixel formats,
      like YUYV422, giving a green background.
      This patchset fixes that by giving a true black background when format
      is non-planar YUV.
      
      Note: this method continue to not working for non-YUV format,
      as before, but it's not checked.
      
      Issue: #81116
      Change-Id: I55ec947d1474fc55dee861510623b8e91ef7f467
      485da039
    • Guillaume Roguez's avatar
      video mixer: fix bad frame re-use · 58863eca
      Guillaume Roguez authored
      Some of internal stats of a frame could be re-used by ffmpeg,
      but the frame doesn't have been reset for that.
      This endings into potential multiple crashes.
      
      This patch forces frame reset before re-use.
      
      Issue: #81689
      Change-Id: I9fa1c7e0d7a19d4abc8e44cb8978fa9379d51abf
      58863eca
    • Alexandre Lision's avatar
      video: reuse scaler · 2493ad1c
      Alexandre Lision authored
      Video scaler now follows sink lifecycle
      
      Issue: #81116
      Change-Id: Ibb053991b265131e1f63e1b2a169821e1d0f3bae
      2493ad1c
  6. 17 Oct, 2015 1 commit
  7. 15 Oct, 2015 1 commit
    • Eloi Bail's avatar
      conference: attach mixer sink if source restarted · 7dfb47df
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      If video_rtp_session is restarted due to bitrate changement
      we need to setup again conferencepipeline. Otherwise videomixer sink
      would be never attached and video never send.
      
      Issue: #81547
      Change-Id: I6de180afab5a7dd320fe3b31a1d61735106d76d1
      7dfb47df
  8. 14 Oct, 2015 2 commits
  9. 13 Oct, 2015 5 commits
    • Adrien Béraud's avatar
      sip/im: use the full peer SIP URI · 0b08a64f
      Adrien Béraud authored
      Account level text messages only reported the SIP userrname
      instead of the full SIP URI username@hostname.
      
      This prevented clients to preperly recorgnise the sender.
      The proper URI is now reported.
      
      Issue: #81724
      Change-Id: Id37b658340d07e14d6cda685d68872b634429306
      0b08a64f
    • Adrien Béraud's avatar
      contrib: disable x264 on Android · b9e5ef42
      Adrien Béraud authored
      Issue: #78220
      Change-Id: Ibc89d02ad226a9ac003ae2adb3a476b3b714d911
      b9e5ef42
    • Adrien Béraud's avatar
      video_rtp_session: replace std::stoi by ring::stoi · ffd2e180
      Adrien Béraud authored
      std::stoi is not available on Android
      
      Issue: #78221
      Change-Id: I3cf69dba62c8d4e5bf3f946340cd44a8c08a788e
      ffd2e180
    • Guillaume Roguez's avatar
      sink: prevent DecodingStopped signal if not started · 92060d3f
      Guillaume Roguez authored
      Arbitrate DRing::VideoSignal::DecodingStopped signal to not
      emitting it if not previously started.
      This prevents client troubles if they don't handle well
      this behavior.
      
      Issue: #81116
      Change-Id: Ib08801d2f62795550238bc91810e6bf139376553
      92060d3f
    • Guillaume Roguez's avatar
      media_encoder: disable sdp related logging · 57bc2d33
      Guillaume Roguez authored
      - refactored media_encoder::print_sdp(): log result only if DEBUG_SDP build variable is defined
      - video_sender: remove sdp_ variable seems not to be used anywhere
      
      Issue: #81581
      Change-Id: I191e520d2ff81907adf9db90dfdf96616d3c50d4
      57bc2d33
  10. 09 Oct, 2015 1 commit
    • Guillaume Roguez's avatar
      video: remove dead code · 0fa0715a
      Guillaume Roguez authored
      This patchset removes VideoProvider class not used anywhere.
      
      Issue: #81116
      Change-Id: I2e32dbe174d1168c75698e00a1104cbefb0ec71f
      0fa0715a
  11. 08 Oct, 2015 1 commit
    • Eloi Bail's avatar
      media: decrease max video bitrate to 2Mbits/s · f23071fa
      Eloi Bail authored
      H264 baseline profile level 2 is used by default for encoding.
      According to RFC max bitrate supported for this profile is 2Mbit/s.
      Test results with this max bitrate show acceptable video quality. A proper
      max bitrate determination algorithm will be developped in the future based on
      video source information such as resolution, framerate.
      
      Issue: #79686
      Change-Id: I2863ff3ef581ad520f695e649d014a8c964213fa
      f23071fa
  12. 07 Oct, 2015 2 commits
  13. 05 Oct, 2015 2 commits
    • Guillaume Roguez's avatar
      threadloop: fix race condition in get_id access · efd4a93a
      Guillaume Roguez authored
      threadloop::get_id() can be called with a non-initialized thread_ variable.
      If this call is done under the loop thread, right after its creation,
      and if InterruptedThreadLoop::wait_for is call, an non catched exception
      is thrown and std::terminate stops all the application.
      This patch proposes to fix this race condition and fix the non-catched
      exception to let the application in a safe state.
      
      Issue: #81210
      Change-Id: I3d8409ac505be181d1a54c5bdd0e679fdb81bf88
      efd4a93a
    • Eloi Bail's avatar
      media: remove useless trace · 66015aef
      Eloi Bail authored
      Warning only if bitrate is effectively changed.
      
      Issue: #78984
      Change-Id: I6203d88ad519d448e33aa016941ff92d262427c5
      66015aef
  14. 03 Oct, 2015 1 commit
    • Guillaume Roguez's avatar
      build: remove annoying warnings on gcc5 build · 624f699a
      Guillaume Roguez authored
      Tons of warning are emited and trash the build log output
      during build of dbus adaptors if GCC-5 or later is used,
      due to wrong GCC version check.
      
      Issue: #81427
      Change-Id: I8fdbb759feeb68efb189a796de8f3b6ea39c4c0e
      624f699a
  15. 02 Oct, 2015 7 commits
  16. 01 Oct, 2015 1 commit
  17. 29 Sep, 2015 2 commits
  18. 28 Sep, 2015 1 commit
  19. 25 Sep, 2015 2 commits
    • Eloi Bail's avatar
      media/sinkclient: change registerSinkTarget API · c588b6be
      Eloi Bail authored and Guillaume Roguez's avatar Guillaume Roguez committed
      API change: remove sharedptr parameter of registerSinkTarget,
      used for direct rendering. Instead use a client provided buffer.
      
      Client now has control of this buffer lifecycle.
      This API has to be used only when daemon and client both live
      in the same process.
      
      Issue: #80643
      Change-Id: Idd7dbc977cbc8fabcece2392388b2d5aac7d2cdc
      c588b6be
    • Eloi Bail's avatar
      media/encoder: set correctly buf size · 3b84b1cc
      Eloi Bail authored
      Buf size is needed to set correcty variable bitrate mode.
      It was set to a value equal to 0
      
      Issue: #80568
      Change-Id: Ie83367893ec830c1c2b5c10b94f46fd57b714221
      3b84b1cc