This patch introduces many changes that prevent various crashes
and assertion failures.

In PJNATH source code:
 - Avoid duplication when adding host candidates.
 - Prtoect ICE context (lock) in TCP callbacks
 - Correctly set local and remote addres in STUN request

In jami source code:
 - Check that the address is valid before using PJSIP
 helpers

Gitlab: #617

Change-Id: I317d748db8d1f93dda6d5f510a2fae909a04704c

Also set agent logging to console by default.

Change-Id: I4993886a149eb4f60e1d61bad7ed18956350599f

Change-Id: Ica9005c67b0aff391166356aff0beb502b8e3f42

This avoid to use the certificate store when using an identified
channel.

Change-Id: I7b9c5c6d896ee9e14ff1f3f456a63fd2452d887b

Adrien Béraud authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: I82413cac3557666de6c3407f01a9f0dc93cea7a1

This gives the possibility to know what channel are initiated
by the daemon via connectDevice()

Change-Id: I6dc42a4765cdd2987dc675ef455d119cbd31406d

shutdownConnections is only called when the account is disabled to
avoid to call it if the account's config is changed.
However, when stopping the daemon, doUnregister is called if the
account is enabled, and this should also call shutdownConnections()
to avoid any lock.

Change-Id: I35fba66b1b7f86360fa29cbeec78697f2b7c3328

Andreas Traczyk authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: I9244f02a7c48da930cd34b1e20c6fe8d10c048b1

Change-Id: Ia220b318c6995a97157b5d3f122ae58d71d5ceb1

If somehow we have obtained a convInfo file with invalid conversations
(reproducible during a post link account sync), remove them when
loading the conversations.

Gitlab: #528
Change-Id: I45f759f470e58f567e70abafaca21dcce728183f

Change-Id: I750ee4f9b1f174d0f6aacab77293506c633a00f4

Change-Id: Ife1e1a111bbda8d8b10fc967502f713d7f09de58

Change-Id: I48cf424123ef137dc1c6fee0ab68c94ab6ac4c56

* contrib/src/main.mak (TARBALLS_DEFAULT): New variable.
(TARBALLS): Define in terms of the above.
(FLOCK, FLOCK_PREFIX): New variables.
(download): Use $(FLOCK_PREFIX), which may be empty when flock is not
available and a default TARBALLS location is used.

Change-Id: I95ca0ec0cdd893fc50f3924619cc87fe8cd6a5b7

Change-Id: Iedf63f2c4a1cf0c3a4fdc78a5ccb452576c522f6

Andreas Traczyk authored 3 years ago and Adrien Béraud committed 3 years ago

Replaces an atomic flag with a mutex preventing async calls to
switchInput from just failing or possibly causing a crash if a
resource already in progress.

jami-client-qt#522

Change-Id: I5f726306a2d54b1dcaa396a463d221a6efca13d8

This homogeneize build between autotools and CMake. jami_contact.h
is a source.

Change-Id: I5bf7a46c858dbfd6ccc4b8c0d053b3b834eebf13

This reverts commit 5e453368.

Reason for revert: Cause crash due to re-ordering the checklist while some checks are in progress

The resort of is causing inconstitency between the checks. The current uses
the list index as the ID for the STUN request. When the STUN response
(for this request) is received, the ID is used as is to retrieve the
check in the check list.
If the list is re-ordered (when receiving an new incoming check), before
the STUN response is received and processed, the ID of STUN request will
point to a different check on reception of the STUN response.

This a temporary revert until a more robust solution to the ordering
issue is found.

Change-Id: I912a9861118461ff7f6296f61c53531fa2b9384e

Change-Id: I5a30a4f5b7c7f2b74e5457973fdf42849fbc604c
GitLab: https://git.jami.net/savoirfairelinux/ring-project/-/issues/1282

SipTransportBroker::shutdown triggers pjsip_transport_shutdown
that can call transportStateChanged synchronously. In this case,
transportMapMutex_ is locked, causing a deadlock on a single thread.
We don't care about the transport's map at this point as we are
destroying the transportbroker, so we can just ignore the state
changed here.

Change-Id: I180ff1807fe87d1c48d72851f17e94ae2f892823

The handleEvent should finish. If after 3 secs nothing it's still
running, it should be stopped anyway. Add a log to detect this case.

Change-Id: Icc64f9450d5a8aecfcb6a5aa2e6a13882f4d0e8b

With this patch, contact left is removed in one to one. So, if
a contact left, they still receive message notification and they
will generate conversation requests and retrieve the old history.
Moreover, if they remove and re-add a contact, they will receives
a confirmation for the previous conversation and retrieve the old
history.
This avoid duplicates and read-only conversation.

GitLab: https://git.jami.net/savoirfairelinux/ring-project/-/issues/1282
Change-Id: Id820482e82e23334632e76bf4920255efb45f4cb

Olivier Dion authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: I8d5eaf4c90cb425e8f96eaac25e727b6a6aae24f

Do not emit CallSignal::StateChange while locked. Because if the
client uses any method that lock callMutex_ it will be a deadlock.

Change-Id: I49aa7cb4ee60b23ef069751a7c1abbf4c9fcec95

This makes the log sending messages in the order the client will
show it and avoid to calculate linearized parent for each commit.
However, this linearized parent can change over time. In fact, if
a merge happens, the parents of the messages shown can be
modified.

Change-Id: I26372aa52de0e5f89140680a4beaf5fc7ec52163
GitLab: https://git.jami.net/savoirfairelinux/ring-project/-/issues/1282

Change-Id: I295f444373aaf00ca11e56dd594e61548237364e

This patches introduces two new concepts in order to reduce the code
of JamiAccount.

ChannelHandlers to manages protocols logic. The idea of this class
is to handle channels per protocol, accept and reject it.
AccountModule, to be able to separate logic between call managements
datatransfer, config and conversation but give an interface to
detect when some events should occurs.

Change-Id: I34ff07852c06d7266411f1ffb32b71a1834aba4f
GitLab: #603

A deadlock is caused by a lock-order-inversion of the private
mutex from pulse-audio thread loop, and the callMutex_ mutex
from the Call class. It occurs when concurrently calling
writeToSpeaker() and onNegoDone() callbacks.
The deadlock is prevented by avoid to a access Call data from
the pulse-audio thread.

Gitlab: #623

Change-Id: I91d936b37528db3de24e93b0d49d686f5ca11813

Change-Id: Ib4377b5a109dc9b1554a35f2341820307ec6a500
GitLab: #624

There is an issue with the nomination of triggered checks in ICE
that causes ICE negotiation to conclude on sub-optimal pairs.
The issue was reported, and acknolegded by PJSIP maintainers.
This patch will fix the issue.

Gitlab: #622

Change-Id: I4bed7191692051d6215fbde8ee2ca9f94b76e0f9

Use a higher Ta value (50ms instead of 20ms) as
recommended by newer ICE spec (RFC-8445).
This will reduce bandwith usage (peaks) needed for the connectivity
checks as described in RFC-8445.

Gitlab: #605

Change-Id: I6a228a47d5f6cf574003d1354c4410294aedf95a

Aline Gondim Santos authored 3 years ago and Sébastien Blin committed 3 years ago

Gitlab: #562

Change-Id: I577c86b3e6a30c171f0233c4354ccfb79e494d40

fixes commit b954f3b5

Gitlab: #617

Change-Id: I82b6f9f229b173279bfcd3c200b73690d752b670

Change-Id: I7e46255256ebce1a1e133c53d170539f6c8e1f8c

Sébastien Blin authored 3 years ago and Mohamed Chibani committed 3 years ago

Change-Id: Icee8afc872c9b25fce2d049e66673459de254b4d
GitLab: https://git.jami.net/savoirfairelinux/ring-project/-/issues/1282

Change-Id: I505b63153f49aa9733d278c613c9813c67febb62

Change-Id: I384bca2ca4e97588b21041ebca72083c57abb915

Mohamed Chibani authored 3 years ago and Sébastien Blin committed 3 years ago

Resort the check list  when new prflx candidates are discovered,
to avoid the nomination of candidates pairs with less priority.

Gitlab: #617

Change-Id: I93559facd8b6ce99708ccf1311925837d9cd119d

ICE "aggressive nomination" was enabled to reduce connection time.
However, this feature may cause ICE to nominate a sub-optimal pair
during the negotiation process. For example, nominating a
relay-prflx pair, while a srflx-prflx is more optimal.
Furthermore, aggressive nomination was dropped in the latest ICE
specification (RFC-8445)
Also fix logging of nominated pairs

Gitlab: #601

Change-Id: Ib08103b830fc0c5d158cf776a1082a0655317270

When receiving a 'connectivity change', UPNP search must be restarted
if the host address changes and also if there is no valid IGD.
Also reduce the number of retries on failure.

Gitlab: #615

Change-Id: I80e6d61ab79ef91f480bb0073b9cec8e7e67e559