Skip to content
GitLab
  1. 29 Jun, 2021 15 commits
  3. 28 Jun, 2021 12 commits
    • Adrien Béraud's avatar
      fileutils: fallback on symlink if hardlink fails · 28275796
      Adrien Béraud authored 
      This is because there are many normal cases for a hardlink to fail,
for instance different partitions or hardware devices.

Change-Id: Ie5b75c343f4a611a1d959c24adc92997f05cdf44
      28275796
    • Adrien Béraud's avatar
      nodejs: update for new API · e57520d0
      Adrien Béraud authored 
      Change-Id: I1db1fc47a7a3164318dcaad6bfd51be006838bc0
      e57520d0
    • Adrien Béraud's avatar
      ice_sdp_parser: fix unit test · 92fbb845
      Adrien Béraud authored 
      Change-Id: Ie692ceda6fc098c387b22474049bd66728095a57
      92fbb845
    • Adrien Béraud's avatar
      sip: accept more version strings, cleanup · ffe7d64f
      Adrien Béraud authored 
      Now support more possible version strings from the peer,
in case of future changes:
* 4-component versions (2.1.3.1)
* <3-component versions (10 or 10.1), in case we want to provide
  less details to the peer about our version in the future.

Also cleanup to use string-view (2 less string allocations).

Change-Id: Ifbd35d203a47fc573b4670218ce4ccc9bebaecc5
      ffe7d64f
    • Adrien Béraud's avatar
      autotools: make fuzzing optional · 459ee469
      Adrien Béraud authored 
      Change-Id: Iaa11c6880858316336f5e5b5e1fc6f55597d24d0
      459ee469
    • Adrien Béraud's avatar
      autotools: cleanup nodejs · 1c37197b
      Adrien Béraud authored 
      Change-Id: Ie5c67deace0664c2d8d9664ecb0f722fce13a57e
      1c37197b
    • Olivier Dion's avatar
      account: Fix read after free · 8b09cd89
      Olivier Dion authored 
      Commit f0fb8148 introduces a bug that makes Jami
crash with ASAN.

Change-Id: I7547fcc221b8bf25fdb0b2ae5a9a6f458eceda88
      8b09cd89
    • Maxim Cournoyer's avatar
      daemon: Use the PROGSHAREDIR macro to refer to the custom datadir. · f0fb8148
      Maxim Cournoyer authored and Adrien Béraud's avatar Adrien Béraud committed 
      The sources previously hard-coded the location of the default Jami
ringtone as "/usr/share/ring/ringtones/default.opus".  It should
instead be computed from the already existing PROGSHAREDIR macro,
which is built from Autoconf's configurable datadir.

* globals.mk (-DPROGSHAREDIR): Rename the 'ring' subdirectory to
'jami'.
* meson.build (conf): Likewise.
* ringtones/Makefile.am (dist_jamiringtones_DATA): s/ring/jami/g
* ringtones/meson.build: Likewise.
* src/account.cpp (DEFAULT_RINGTONE_PATH): Define in terms of
PROGSHAREDIR.
* bin/dbus/Makefile.am (libclient_dbus_la_CXXFLAGS): Remove extraneous
flags, already propagated via AM_CPPFLAGS.  Honor AM_CXXFLAGS.
* src/client/Makefile.am (libclient_la_CXXFLAGS): Remove.
* src/plugin/Makefile.am (libplugin_la_CXXFLAGS): Likewise.

Change-Id: Icaa0a92e896f86b0bb07f82e4079570db08fafbd
      f0fb8148
    • Maxim Cournoyer's avatar
      dring: Rename to jamid. Likewise for ringcli. · 11a85bde
      Maxim Cournoyer authored and Adrien Béraud's avatar Adrien Béraud committed 
      This change renames the dring binary to jamid on GNU/Linux, and from
ringcli to jamid on the other Windows/Mac platforms.

* .gitignore: Ignore bin/jamid instead of bin/dring.
* bin/Makefile.am (bin_PROGRAMS)[HAVE_WIN32]: Replace ringcli by
jamid.
(ringcli_SOURCES)[HAVE_WIN32]: Rename to jamid_SOURCES.
(ringcli_CXXFLAGS)[HAVE_WIN32]: Rename to jamid_CXXFLAGS.
(ringcli_LDADD)[HAVE_WIN32]: Rename to jamid_LDADD.
[HAVE_OXS]: Likewise for each of the above 4 variables.
(bin_PROGRAMS): Replace dring by jamid.
(dring_SOURCES, dring_CXXFLAGS, dring_LDADD): Replace the 'dring'
Automake variables prefix by 'jamid'.
* bin/dbus/cx.ring.Ring.service.in (Exec)<dring>: Rename to 'jamid'.

Change-Id: I3f41846a38e74e2f3c6f687a46e1a208f0083ca2
      11a85bde
    • Sébastien Blin's avatar
      test: listen for announced not registered · 7d754099
      Sébastien Blin authored 
      Change-Id: I64cdedb5f3a5131cab4ae85b8eaf3dd46102952e
      7d754099
    • Sébastien Blin's avatar
      data_transfer: channel can live longer than IncomingFile · f9a34f99
      Sébastien Blin authored 
      Change-Id: Ifbc66d0197949f82826bd743b3a015ae5b540e6f
      f9a34f99
    • Sébastien Blin's avatar
      jamiaccount: avoid use after move · 062111c7
      Sébastien Blin authored 
      Change-Id: Ie72b4c03bfe5d948a0aa8e48ae8a5d99f1650f42
      062111c7
  5. 25 Jun, 2021 6 commits
  7. 23 Jun, 2021 2 commits
  9. 22 Jun, 2021 5 commits
    • Sébastien Blin's avatar
      test: fix testMemberJoinsNoBadFile by waiting for join before copying · e5d95eb6
      Sébastien Blin authored 
      Change-Id: I4e34411c6e362c2aca31337224b077f7674d73da
      e5d95eb6
    • Maxim Cournoyer's avatar
      daemon: Install dring to libexec and edit templates at install time. · 2afa99fd
      Maxim Cournoyer authored 
      Executables are typically installed under bin/, sbin/ or libexec,
rather than lib/.  The problem was noticed when trying to use Jami
with a Guix relocatable pack, which only wraps executables found under
the above locations.  Since dring is a daemon and should not be run
directly by users under normal circumstances, the convention is to use
the libexec directory, according to the File Hierchy Standard 3.0.

Also tackled in this change is the substitution of the Autoconf
variables at installation time rather than configuration time, as per
the GNU Coding Standards.  The following solution is taken from
https://github.com/gentoo/eudev/pull/183/commits, which in turn is
adapted from the Autoconf manual (c.f.: info "(autoconf)Installation
Directory Variables").

* bin/Makefile.am (ringlibdir): Delete variable.
* bin/dbus/Makefile.am (do_subst): New variable.
(cx.ring.Ring.service): Derive from the cx.ring.Ring.service.in
template.
[HAVE_WIN32]: (ringlib_PROGRAMS): Rename to ...
(bin_PROGRAMS): ... this.
[HAVE_OSX, RING_DBUS]: Likewise.
* bin/dbus/cx.ring.Ring.service.in (Exec): Adust.
* globals.mk (ringlibdir): Delete variable.
* configure.ac [with_dbus] <AC_CONFIG_FILES>: Remove
bin/dbus/cx.ring.Ring.service.  Also remove the LIBDIR variable, no
longer used.  Fix indentation.

Thanks to Vladimir Stoiakin for providing feedback on this change.

Change-Id: I845bf2bd590a9457e70ca173027217b8f164d713
      2afa99fd
    • Andreas Traczyk's avatar
      datatransfer: save directly to conversation_data if no path is set · 4bb6741e
      Andreas Traczyk authored 
      Incoming transfers should be preserved in the conversation's data
directory by default. This will prevent broken pending file
transfers and chat UI when the user cleans their download folders.
Subsequent commits to the project should provide a mechanism for
users to download(copy) transfers to their chosen download path.

Change-Id: Ide109fadb950ce7ab096c052c0a54ad4d215a9a1
      4bb6741e
    • Andreas Traczyk's avatar
      fileutils: remove symlink creation on windows · dd36baa5
      Andreas Traczyk authored 
      Requires developer mode at best on windows 10

Change-Id: I0861c3f87c51f0de9de3f3860b371ced0d5ccb2d
      dd36baa5
    • Sébastien Blin's avatar
      ut_syncHistory: fix testCreateConversationWithMessagesThenAddDevice · eaeb865a
      Sébastien Blin authored 
      sendMessage is async, causing messages to be mixed before the assert

Change-Id: Ia08855a6a1516db2ee5acf01c166055831be80eb
      eaeb865a