Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: I1f800f5377375fd561885378fa0f3a21f67fe880

Set the security (SRTP) flag for media using account settings

Gitlab #556

Change-Id: I657c054625c37e3a3baa576efe27a67ea16bcff6

Handle and test generation and processing of SIP INVITEs without
media offers (no SDP)
Also add basic call scenario for SIP accounts

Gitlab: #556

Change-Id: I4967a821936e7c33cf4d7e7bdd7ee96718db285e

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Iaa58c76c6cef0b80df45a5d2d6a328ee9159c8d8

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Icecdfddd200932eb7f4f5fdd7e6a406472f85c18

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Ie622946606226171da6244361d334ba023dfa655

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Ide37f73f142cb1cfa86b86c6ddbc76ce80e9414d

Change-Id: I07e13c237af76db0ee197f69ece12ed2461b3b52

This is because there are many normal cases for a hardlink to fail,
for instance different partitions or hardware devices.

Change-Id: Ie5b75c343f4a611a1d959c24adc92997f05cdf44

Change-Id: I1db1fc47a7a3164318dcaad6bfd51be006838bc0

Change-Id: Ie692ceda6fc098c387b22474049bd66728095a57

Now support more possible version strings from the peer,
in case of future changes:
* 4-component versions (2.1.3.1)
* <3-component versions (10 or 10.1), in case we want to provide
  less details to the peer about our version in the future.

Also cleanup to use string-view (2 less string allocations).

Change-Id: Ifbd35d203a47fc573b4670218ce4ccc9bebaecc5

Change-Id: Iaa11c6880858316336f5e5b5e1fc6f55597d24d0

Change-Id: Ie5c67deace0664c2d8d9664ecb0f722fce13a57e

Commit f0fb8148 introduces a bug that makes Jami
crash with ASAN.

Change-Id: I7547fcc221b8bf25fdb0b2ae5a9a6f458eceda88

Maxim Cournoyer authored Jun 21, 2021 and Adrien Béraud committed Jun 28, 2021

The sources previously hard-coded the location of the default Jami
ringtone as "/usr/share/ring/ringtones/default.opus".  It should
instead be computed from the already existing PROGSHAREDIR macro,
which is built from Autoconf's configurable datadir.

* globals.mk (-DPROGSHAREDIR): Rename the 'ring' subdirectory to
'jami'.
* meson.build (conf): Likewise.
* ringtones/Makefile.am (dist_jamiringtones_DATA): s/ring/jami/g
* ringtones/meson.build: Likewise.
* src/account.cpp (DEFAULT_RINGTONE_PATH): Define in terms of
PROGSHAREDIR.
* bin/dbus/Makefile.am (libclient_dbus_la_CXXFLAGS): Remove extraneous
flags, already propagated via AM_CPPFLAGS.  Honor AM_CXXFLAGS.
* src/client/Makefile.am (libclient_la_CXXFLAGS): Remove.
* src/plugin/Makefile.am (libplugin_la_CXXFLAGS): Likewise.

Change-Id: Icaa0a92e896f86b0bb07f82e4079570db08fafbd

Maxim Cournoyer authored Jun 09, 2021 and Adrien Béraud committed Jun 28, 2021

This change renames the dring binary to jamid on GNU/Linux, and from
ringcli to jamid on the other Windows/Mac platforms.

* .gitignore: Ignore bin/jamid instead of bin/dring.
* bin/Makefile.am (bin_PROGRAMS)[HAVE_WIN32]: Replace ringcli by
jamid.
(ringcli_SOURCES)[HAVE_WIN32]: Rename to jamid_SOURCES.
(ringcli_CXXFLAGS)[HAVE_WIN32]: Rename to jamid_CXXFLAGS.
(ringcli_LDADD)[HAVE_WIN32]: Rename to jamid_LDADD.
[HAVE_OXS]: Likewise for each of the above 4 variables.
(bin_PROGRAMS): Replace dring by jamid.
(dring_SOURCES, dring_CXXFLAGS, dring_LDADD): Replace the 'dring'
Automake variables prefix by 'jamid'.
* bin/dbus/cx.ring.Ring.service.in (Exec)<dring>: Rename to 'jamid'.

Change-Id: I3f41846a38e74e2f3c6f687a46e1a208f0083ca2

Change-Id: I64cdedb5f3a5131cab4ae85b8eaf3dd46102952e

Change-Id: Ifbc66d0197949f82826bd743b3a015ae5b540e6f

Change-Id: Ie72b4c03bfe5d948a0aa8e48ae8a5d99f1650f42

Change-Id: Ie593e1a6496d47fa8bb1fa3b046a01f87a44377b

Change-Id: I53c9da27babcbb1c1f678ddf7b885a322d3a4d96

Change-Id: Ia946d08f370143ff2e7d9ece379ad63a8207a4b3

Change-Id: I5a3718b9c19800bd6615b52a050f6f443394136e

Change-Id: I189cdf06e74314f6e35b34addafe599d39f2dc42

Change-Id: Ibb9d0b2d0ab638de914d31c500e41224cf293f1e

Aline Gondim Santos authored Jun 11, 2021 and Aline Gondim Santos committed Jun 23, 2021

with lasts ms patches, audio only participants dummy video was not being attached to conference mixer, causing participant to not show

Change-Id: I4621562e901aec7dfed6c6ae4a543724f9ccb0d3
GitLab: #565

Change-Id: I26433e1463ecb261fb586431b6c43a3e6b931dcf

Change-Id: I4e34411c6e362c2aca31337224b077f7674d73da

Executables are typically installed under bin/, sbin/ or libexec,
rather than lib/.  The problem was noticed when trying to use Jami
with a Guix relocatable pack, which only wraps executables found under
the above locations.  Since dring is a daemon and should not be run
directly by users under normal circumstances, the convention is to use
the libexec directory, according to the File Hierchy Standard 3.0.

Also tackled in this change is the substitution of the Autoconf
variables at installation time rather than configuration time, as per
the GNU Coding Standards.  The following solution is taken from
https://github.com/gentoo/eudev/pull/183/commits, which in turn is
adapted from the Autoconf manual (c.f.: info "(autoconf)Installation
Directory Variables").

* bin/Makefile.am (ringlibdir): Delete variable.
* bin/dbus/Makefile.am (do_subst): New variable.
(cx.ring.Ring.service): Derive from the cx.ring.Ring.service.in
template.
[HAVE_WIN32]: (ringlib_PROGRAMS): Rename to ...
(bin_PROGRAMS): ... this.
[HAVE_OSX, RING_DBUS]: Likewise.
* bin/dbus/cx.ring.Ring.service.in (Exec): Adust.
* globals.mk (ringlibdir): Delete variable.
* configure.ac [with_dbus] <AC_CONFIG_FILES>: Remove
bin/dbus/cx.ring.Ring.service.  Also remove the LIBDIR variable, no
longer used.  Fix indentation.

Thanks to Vladimir Stoiakin for providing feedback on this change.

Change-Id: I845bf2bd590a9457e70ca173027217b8f164d713

Incoming transfers should be preserved in the conversation's data
directory by default. This will prevent broken pending file
transfers and chat UI when the user cleans their download folders.
Subsequent commits to the project should provide a mechanism for
users to download(copy) transfers to their chosen download path.

Change-Id: Ide109fadb950ce7ab096c052c0a54ad4d215a9a1

Requires developer mode at best on windows 10

Change-Id: I0861c3f87c51f0de9de3f3860b371ced0d5ccb2d

sendMessage is async, causing messages to be mixed before the assert

Change-Id: Ia08855a6a1516db2ee5acf01c166055831be80eb

Also check repo pointer in conversationRepository. If the conversation
is not correctly cloned (can be caused by a lot of things during the clone),
the infos will be invalid, so avoid to crash in this case.

Change-Id: I42a15200a06ca700bac972deea4cfc07ae87cae8
GitLab: #568

If the ICE is closed during the cacheSIPConnection, the sip transport
will not be found causing a potential crash

Change-Id: Ic2e7ab9272a2eb3274256151e37c2acd208cb0dd
GitLab: #569

Andreas Traczyk authored Jun 17, 2021 and Adrien Béraud committed Jun 17, 2021

Change-Id: Iff94a21f26fd1518e1d7287e511c41176ea8eea9

Change-Id: I610ae85bb3b779457a9ce64161e3b8b19ca820df
Gitlab: #516

Media direction attribute in the SDP should be set to "sendonly"
when the call is put on-hold.

Gitlab: #553

Change-Id: Iad82bf1fcac703bd275e857f28d1a4aa7323cc0d

Change-Id: I829ca79f3786d400c1cf9937affcd713ea48e05e

Trevor Tabah authored Jun 15, 2021 and Adrien Béraud committed Jun 16, 2021

Change-Id: I3c0202705488c84cade375b79a9d47669c2dcd20