GitLab

Gitlab: #583

Change-Id: Iddd1b582595daee498b383a11c6323546d14bef4

If `monitorLog` is set to true in between the copy of variadic arguments and
branch to `vnsprintf`, it results in SEGFAULT.

Change-Id: I610b950cec22e9b7123cca709e2f145b1bc1be16

Gitlab: #570

Change-Id: I87f476082f0f04b342e737e523eae976b0717bca

Olivier Dion authored Jul 07, 2021 and Sébastien Blin committed Jul 09, 2021

Increment of the invite session has to be done before SIPCall takes a reference
to it.

Otherwise, `pjsip_inv_dec_ref()` will be called internally by PJSIP when the
reference counter has reached 0.  This happen when `SIPCall::setInviteSession()`
is called in `invite_session_state_changed_cb()`, resulting in the deletion of
the invitation.

Change-Id: Icba0985ea26ce5dec462bd124cca4dd2187d6a47

Change-Id: I0f0a926996d34ae22051f0247e36575ab755d0ba

Rework the test to use two audio streams instead of audio+video.
This is needed to run the test on environments where the camera
is not available (e.g. Docker). For this specific test, the media
type is irrelevant, so using two audio media is acceptable.

Gitlab: #516

Change-Id: Idc4911d5aea5ffdd931bd7d63516ed484344d41c

Olivier Dion authored Jul 06, 2021 and Sébastien Blin committed Jul 08, 2021

Change-Id: I1acac4dd8e87d2ffe1c63638d03fd28c6749adef

Change-Id: I702ab3422c3fd6bd528fe65a5541c98150a5722d

Change-Id: I68e954bc8de9548a9da0026c014f27141e0b7ec0

Change-Id: Ice706b3c5384cb8bec7becfc6209658a78b9ac9a

Olivier Dion authored Jun 08, 2021 and Sébastien Blin committed Jul 07, 2021

`last_REMB_*` can be at `time_point::min()` when `delayMonitor()` is called.  This
results in a signed integer overflow, which UBASAN doesn't like.

Fix this by setting `last_REMB_*` to `clock::now()` before setting callback.

Change-Id: I0b24d759927c2eb7e23253a16333ba54dc3f9edf

Aline Gondim Santos authored Jun 14, 2021 and Kateryna Kostiuk committed Jul 06, 2021

Change-Id: I13b63eff7f7b729ece6ac3d16cd4d36767a20464

Change-Id: Ib943587e49bcbf16104cf3bbc206e30bc3448f82

Mohamed Chibani authored Jun 30, 2021 and Sébastien Blin committed Jul 02, 2021

Currently, when an empty offer is received, a media offer is
generated with audio, and video if enabled in the account.
Now, the generated offer will include only audio. Both
participants can add video to the call if they wish.
Also some code clean-up

Gitlab: #556

Change-Id: Id51bf44b2b84fd9341de4b67bf53963614088ef8

Olivier Dion authored Jun 17, 2021 and Sébastien Blin committed Jul 02, 2021

Change-Id: I67825b04f1fead3d4267564e4c366cb54037c593

This seems to avoid a heap buffer overflow. Anyway, we only add data at the
end of the buffer so the deque has no need.

Change-Id: I8f3932599a065f22b11adc701ededfb5ebedfff8

Change-Id: I62f93b4b0706863debc9595b0b4646c3b0974b52

This can re-generate MessageReceived for already received messages. If we
are not behind from, this means we are up-to-date and no-need to re-announce.

Change-Id: I890ec20117235aeec56e4a7d3f720c1193e9633c

avoid any possible race condition. shutdown the sock when onShutdown is set

Change-Id: I0e7a5e940267154aec4417c8b653d19b1f54430c

Adrien Béraud authored Jun 30, 2021 and Sébastien Blin committed Jun 30, 2021

If we receive EOF, didn't the peer already closed the socket ?

Change-Id: I06ae908b49ddd4ba0a5eb43ff25f51da1f15cc21

Adrien Béraud authored Jun 30, 2021 and Sébastien Blin committed Jun 30, 2021

Change-Id: I34eeff81cb639bab901e939dd6436f6645c32b4d

Adrien Béraud authored Jun 30, 2021 and Sébastien Blin committed Jun 30, 2021

Refactor structures to improve memory consistency
and reduce concurrency on the main mutex.

Change-Id: I3dcf1b94d96d51bddff4446b7011605821c4f1b6

This is a follow up commit to
d5021c78.

* bin/dbus/cx.ring.Ring.service.in (Exec): Replace @libexec@ by
@libexecdir@.

Change-Id: Id72503d45f24bf1ff4341d025b9c7af51cb52479

Windows fixup post https://review.jami.net/c/jami-client-qt/+/18383

Change-Id: Id3b4b11ad49f09bfc0be22155145080b661aceeb

setOnRecv must lock socketsMutex. Generally it,s the case because onAccept
will be ready right away and still locked, however if onChannelReady_ retrigger
the callback, setOnRecv will be used without socketsMutex locked.

Retrigger in a thread and always lock socketsMutex to be sure.

Change-Id: If44d240e113585a5ce3320b8f17feaaaa8be8515

When starting an outgoing call, if the ICE initialization is too fast:
+ SIPCall::initIceMediaTransport will init the ICE transport
+ onInitDone will be called before tmpMediaTransport_ initialized
+ JamiAccount::SIPStartCall will be called and add ICE candidates
BUT because transportMtx_ is not locked, tmpMediaTransport_ will be null
and no ICE transport will be added.

This is why createUTransport should be done while locked. Anyway the method is
async so should not block.

GitLab: #574
Change-Id: Id88dc92f6d77c18de3ea4614e2b5fd79d3429ff0

* src/meson.build (libjami_dep): Sort headers.
* src/Makefile.am (nobase_include_HEADERS): Sort and add
'jami/conversation_interface.h'.

Change-Id: Ib66e4c9904906dcca4722cc81b6487aa43086e2e

Maxim Cournoyer authored Jun 21, 2021 and Sébastien Blin committed Jun 29, 2021

This avoids the error:

   ld: /home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib/libswscale.a(swscale.o): relocation R_X86_64_PC32 against symbol `ff_M24A' can not be used when making a shared object; recompile with -fPIC
   ld: final link failed: bad value

caused by the missing '-Wl,-Bsymbolic' linker directive (which is
documented as required by ffmpeg when a shared library is built
against a static ffmpeg object).

* src/Makefile.am (libring_la_LDFLAGS): Set to AM_LDFLAGS.
[HAVE_WIN32]: Append using the += operator.
[HAVE_OSX]: Likewise.
[HAVE_LINUX]: Remove; it was not necessary.

Change-Id: Id2af9ea5812b2d1fd3b4f7f893108bb94671ffc6
GitLab: jami-packaging#101

Ming Rui Zhang authored Jun 18, 2021 and Adrien Béraud committed Jun 29, 2021

Gitlab: #567

Change-Id: I9fdb1601f407759a8b6ef73bccc32769e5693b5b

Maxim Cournoyer authored Jun 29, 2021 and Sébastien Blin committed Jun 29, 2021

This is a follow up to commit 2afa99fd (Install dring to libexec and
edit templates at install time).

* bin/dbus/Makefile.am (do_subst): Replace bindir by libexecdir.

Change-Id: I380e61467ef4f3c4873698c9e2061b9c61370d44

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Ia9ce297062ac28dcf7f03ee28247cad4411d1b0f

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: I92e57a1f62e3bae67c8ae4ca6d7654dfe427c361

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: I31128ff65ca03c62971165ed61683cbc84b0b5d4

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: I39f655b439a47caaa9c5e7ce57c3ef042258c778

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Ieeda03d459eeefb86a19e57277bde7c194e5b8c5

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: I1f800f5377375fd561885378fa0f3a21f67fe880

Set the security (SRTP) flag for media using account settings

Gitlab #556

Change-Id: I657c054625c37e3a3baa576efe27a67ea16bcff6

Handle and test generation and processing of SIP INVITEs without
media offers (no SDP)
Also add basic call scenario for SIP accounts

Gitlab: #556

Change-Id: I4967a821936e7c33cf4d7e7bdd7ee96718db285e

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Iaa58c76c6cef0b80df45a5d2d6a328ee9159c8d8

Olivier Dion authored Jun 10, 2021 and Adrien Béraud committed Jun 29, 2021

Change-Id: Icecdfddd200932eb7f4f5fdd7e6a406472f85c18