jami-daemon issueshttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues2023-05-19T13:19:39Zhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/765ios-specific ffmpeg patch applied erroneously on gnu/linux?2023-05-19T13:19:39ZMaxim Cournoyerios-specific ffmpeg patch applied erroneously on gnu/linux?Hi,
https://git.jami.net/savoirfairelinux/jami-daemon/-/blob/master/contrib/src/ffmpeg/rules.mak#L368 applies what looks like an ios-specific patch (at least by its name) on any platform -- should there be a conditional, or is it good ...Hi,
https://git.jami.net/savoirfairelinux/jami-daemon/-/blob/master/contrib/src/ffmpeg/rules.mak#L368 applies what looks like an ios-specific patch (at least by its name) on any platform -- should there be a conditional, or is it good on all platforms? If the later, I'd strip 'ios' from the file name, to avoid confusion.
Thanks!https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/28"Blob" class split for increased clarity2022-11-14T21:52:31ZJami Bot"Blob" class split for increased clarityIssue generated from Tuleap's migration script.
**Originally submitted by: Macony Gautradis (teamlog8430)**
The Account class is showing the first signs of becoming a monolithic "Blob" antipattern. Our solution is to split the "Blob" cl...Issue generated from Tuleap's migration script.
**Originally submitted by: Macony Gautradis (teamlog8430)**
The Account class is showing the first signs of becoming a monolithic "Blob" antipattern. Our solution is to split the "Blob" class into multiple separate subclasses, by issues, used to ease maintenance and upgrades of the code by separating relevant and linked methods into more descriptive subclasses. This initial work splits some functions of Account into the CodecContainer subclass.
The other modifications were made throughout the project to reflect the changes to Account. The makefile was updated to automake using our new class.
Here is a more thorough list of changes:
CHANGED FILES:
(all in daemon/)
MAJOR CHANGES:
src/account.h
src/account.cpp
description: Removed ALL codec-related functions, added CodecContainer class to
replace said functions,
added std::shared\_ptr<CodecContainer> codecContainer\_; and
std::shared\_ptr<CodecContainer> getCodecContainer(); definitions
Removed \#include "media\_codec.h" because it makes no sense to have
it here anymore
src/codeccontainer.h
src/codeccontainer.cpp
description: Created these two files and moved all codec-related code in
account.h/account.cpp to these respective files, creating
the CodecContainer class
in the process
Migrated code was cleaned up a bit - references to getSystemCodecContainer()
changed to already existing member systemCodecContainer\_
MINOR CHANGES:
src/Makefile.am
description: Updated automake makefile to compile the new codeccontainer.\* files
src/client/configurationmanager.cpp
description: Updated references to codec-calling functions
src/media/video/video\_sender.cpp
description: Added \#include "media\_codec.h" that was implicitly included in account.h
but removed due to codec separation
src/sip/sipaccount.cpp
description: Updated references to codec-calling functions
src/sip/sipcall.cpp
description: Updated references to codec-calling functions
src/sip/sipvoiplink.cpp
description: Updated references to codec-calling functions
src/ringdht/ringaccount.cpp
description: Updated references to codec-calling functions
\* Was only tested on Mint
[RingChanges.zip](/uploads/035972cc8864c9cbc735f2829d219685/RingChanges.zip)https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/744[enhancement] add ringing time before autoreplay2022-08-03T11:55:44ZPietro[enhancement] add ringing time before autoreplayHi there,
thanks for this nice software. I'm currently using it to get in touch with my mom, that can no longer handle the mobile phone.
I activated the autoanswer option and everything works great except for one thing: there is no ring...Hi there,
thanks for this nice software. I'm currently using it to get in touch with my mom, that can no longer handle the mobile phone.
I activated the autoanswer option and everything works great except for one thing: there is no ringing time.
It would be very helpful to have a few seconds of ringtone to notify the recipient of the incoming call.
I achieved this very easily, by just adding some sleep time before the auto-answer:
```
diff --git a/src/manager.cpp b/src/manager.cpp
index 582bbc012..3e436a8e8 100644
--- a/src/manager.cpp
+++ b/src/manager.cpp
@@ -2541,7 +2541,7 @@ Manager::ManagerPimpl::processIncomingCall(const std::string& accountId, Call& i
});
} else if (autoAnswer_ || account->isAutoAnswerEnabled()) {
dht::ThreadPool::io().run(
- [this, incomCall = incomCall.shared_from_this()] { base_.answerCall(*incomCall); });
+ [this, incomCall = incomCall.shared_from_this()] { sleep(9); base_.answerCall(*incomCall); });
} else if (currentCall && currentCall->getCallId() != incomCallId) {
// Test if already calling this person
if (currentCall->getAccountId() == account->getAccountID()
```
Are you interested in this option? I'm not sure I can code it through both the deamon and the gui, but I know C++ and QML so I may just need some directions on the structure of the code.https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/632Load balancing/connection bonding2022-02-18T21:11:59ZovariLoad balancing/connection bondingIt is understood that Jami does not work if the internet connection is changed while in a call.
Can load balancing/connection bonding please be added to Jami?
Load balancing/connection bonding programs `combine multiple internet connec...It is understood that Jami does not work if the internet connection is changed while in a call.
Can load balancing/connection bonding please be added to Jami?
Load balancing/connection bonding programs `combine multiple internet connections (Wi-Fi networks/Ethernet/3G/4G) to increase your overall internet download/upload speed` to:
* increase reliability
* increase performance
* improve stability
* add redundancy
* enable hot-swappable internet connections
Similar to the emoji picker in Jami, perhaps there is a free/open-source cross-platform load-balancing program that could be included with Jami?
1. [HAProxy](https://www.haproxy.org/)
2. [dispatch_ng](https://gitlab.com/akash_rawal/dispatch_ng)
3. [Go dispatch proxy](https://github.com/extremecoders-re/go-dispatch-proxy)
What do you think?
Thank youhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/356What are the license for ringtone files2021-11-19T21:46:34ZSahil DhimanWhat are the license for ringtone filesI would like to add the Jami [ringtone](https://git.jami.net/savoirfairelinux/ring-daemon/tree/master/ringtones) are nice. Could you specify what are license terms for it, if they're under CC license or not.
and thanks for the amazing ...I would like to add the Jami [ringtone](https://git.jami.net/savoirfairelinux/ring-daemon/tree/master/ringtones) are nice. Could you specify what are license terms for it, if they're under CC license or not.
and thanks for the amazing work and sorry for the noise.https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/130[Bug+Question] Daemon only sending trust request if account is not in the co...2021-08-19T18:18:16ZMoritz Brunner[Bug+Question] Daemon only sending trust request if account is not in the contact list**Platform:** x86_64
**OS:** Fedora 29
**Build:** based on eff973bd
**Prerequisites:** Client A with client B as a contact, client B with client A as a contact
**Steps to reproduce:**
1. In client A: Delete client B from th...**Platform:** x86_64
**OS:** Fedora 29
**Build:** based on eff973bd
**Prerequisites:** Client A with client B as a contact, client B with client A as a contact
**Steps to reproduce:**
1. In client A: Delete client B from the contact list
2. In client B: Send a message to client A
**Expected behaviour:** Client B sends a trust request in order to trigger client A's `onTrustRequest` function in src/jamidht/jamiaccount.cpp
**Actual behaviour:** Client B sends no trust request and therefore client A never calls the `onTrustRequest` function.
As a result the refuse button in client A's trust request dialog won't work and it may have other unintended side effects.
**Question:** Is client B supposed to send a new trust request for already existing contacts **or** should client A handle a message from an unknown client as if it were a trust request and call `onTrustRequest`?https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/72Which layer owns the auto-answer flag???? Daemon or lrc?2020-12-24T21:25:55ZSébastien BlinWhich layer owns the auto-answer flag???? Daemon or lrc?For now, the auto-answer flag is in the account's config. The `--auto-answer` flag is also available for `dring`. Nice.
So, we can conclude that the code for auto answering a call is in the daemon. But it's not the case for the clients....For now, the auto-answer flag is in the account's config. The `--auto-answer` flag is also available for `dring`. Nice.
So, we can conclude that the code for auto answering a call is in the daemon. But it's not the case for the clients. We should re-implement this flag into the client part.
I think it's bad. We should implement this feature only once, and the flag should be managed by the layer which implems this behavior.
Also, in the future, I think we want to improve this flag by contact and by account.https://git.jami.net/savoirfairelinux/jami-daemon/-/issues/275Getting error when starting daemon: ==25277==ASan runtime does not come first...2020-10-06T02:26:26ZDoron BeharGetting error when starting daemon: ==25277==ASan runtime does not come first in initial library listHi, I'm getting this error when trying to run `$jami-daemon/lib/dring/dring`:
```
==27318==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELO...Hi, I'm getting this error when trying to run `$jami-daemon/lib/dring/dring`:
```
==27318==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
```
I also noticed I get it when trying to run the tests:
https://review.jami.net/c/ring-daemon/+/15021