jami-daemon issueshttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues2020-12-22T20:02:14Zhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/351Swarm: cleanup current code2020-12-22T20:02:14ZSébastien BlinSwarm: cleanup current code# Done, to rebase
+ Avoid lock in testBanDevice if CPPUNIT_ASSERT(fileutils::isFile(bannedFile)); fails (just change bannedFile)
+ Add getUri() and getDeviceId() for JamiAccount to avoid multiple lookups + cleanup username_ usage => htt...# Done, to rebase
+ Avoid lock in testBanDevice if CPPUNIT_ASSERT(fileutils::isFile(bannedFile)); fails (just change bannedFile)
+ Add getUri() and getDeviceId() for JamiAccount to avoid multiple lookups + cleanup username_ usage => https://review.jami.net/c/ring-daemon/+/16424
+ Add test to assert that device certificate is there on commit
+ Add check to validate votes + commit messages (verif certificate)
+ invited create a directory instead a file
+ Some message sends to self. Avoid
+ valiadte too much commits
+ Disconnection during fetch => block the fetch, should be stopped
+ Some fetch blocked in
```
#0 0x00007ffff7a1c4e8 in pthread_cond_clockwait () from /lib64/libpthread.so.0
#1 0x0000000000671142 in std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > > (this=0x7ffe10017ce8, __lock=..., __atime=...) at /usr/include/c++/10/condition_variable:209
#2 0x000000000066d8e7 in std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > > (this=0x7ffe10017ce8, __lock=..., __atime=...) at /usr/include/c++/10/condition_variable:119
#3 0x000000000065fdb8 in std::condition_variable::wait_until<std::chrono::_V2::steady_clock, std::chrono::duration<long int, std::ratio<1, 1000000000> >, jami::MultiplexedSocket::waitForData(const uint16_t&, std::chrono::milliseconds, s
td::error_code&) const::<lambda()> >(std::unique_lock<std::mutex> &, const std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1, 1000000000> > > &, struct {...}) (this=0x7ffe10017ce8, __lock=..
., __atime=..., __p=...) at /usr/include/c++/10/condition_variable:158
--Type <RET> for more, q to quit, c to continue without paging--
#4 0x000000000065fb76 in std::condition_variable::wait_for<long int, std::ratio<1, 1000>, jami::MultiplexedSocket::waitForData(const uint16_t&, std::chrono::milliseconds, std::error_code&) const::<lambda()> >(std::unique_lock<std::mutex
> &, const std::chrono::duration<long, std::ratio<1, 1000> > &, struct {...}) (this=0x7ffe10017ce8, __lock=..., __rtime=..., __p=...) at /usr/include/c++/10/condition_variable:185
#5 0x000000000065e959 in jami::MultiplexedSocket::waitForData (this=0x7ffe10008400, channel=@0x7ffe100092d8: 38876, timeout=..., ec=...) at multiplexed_socket.cpp:481
#6 0x000000000065f517 in jami::ChannelSocket::waitForData (this=0x7ffe10006850, timeout=..., ec=...) at multiplexed_socket.cpp:656
#7 0x000000000073cbb1 in P2PStreamRead (stream=0x7ffe04026910, buffer=0x7ffe0402e060 "0008NAK\n", buflen=65536, read=0x7ffe727f7a08) at gittransport.cpp:104
#8 0x0000000000bc0863 in git_smart.recv_cb ()
#9 0x0000000000bc2418 in recv_pkt ()
#10 0x0000000000bc32f1 in git_smart.download_pack ()
#11 0x0000000000ba8919 in git_remote_download ()
```
+ Add account id on logs (to rebase)
+ Queue for merge (convId, device)
+ test double fetch without common refs => should merge both side ok
(a & b same repo, a add commit, b too, then start daemon)
+ Handle 3 users
+ Add locks on conversations_ & pendingFetch & avoid lock on sendMessageNotification + avoid to lock on big operations
+ Avoid multiple parrallel fetch on different remots with same repository, this cause issues
+ Clean warnings
+ Fix segv for repository_ in conversationrepository_
+ improve getMembers()
+ Doc: verify in the doc that we do not add certificates in invited
+ end blockedSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/345Swarm: Fetch validation2021-04-19T13:29:22ZSébastien BlinSwarm: Fetch validation+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#validating-a-commit
+ Add tests
+ Avoid too big fetch
+ Rebase changes in wanted patches+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#validating-a-commit
+ Add tests
+ Avoid too big fetch
+ Rebase changes in wanted patchesSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/344Swarm: Design change. A member must accepts the invite to be in getMembers()2021-04-19T14:20:47ZSébastien BlinSwarm: Design change. A member must accepts the invite to be in getMembers()We need to avoid to send messages to someone that discard an invite. Also when removing a conversation, we should be sure that someone can sync, so accepted
Problem:
+ What happen when accepting/discarding an invite?
+ To discuss/solve:...We need to avoid to send messages to someone that discard an invite. Also when removing a conversation, we should be sure that someone can sync, so accepted
Problem:
+ What happen when accepting/discarding an invite?
+ To discuss/solve: The invite must go through, else, it will be problematic to detect invitations
+ Change tests for getMembers
+ Change tests for removeConversation
+ Add tests for accepts/discards
+ Test that the invite is received if not present at first
+ Update docSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/321Swarm: relink share location2021-01-18T17:17:30ZSébastien BlinSwarm: relink share locationSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/320swarm: relink typing indication2021-06-12T11:37:14ZSébastien Blinswarm: relink typing indicationShould not be difficult
The only difficulty is that the conversation is not specified, only the message-id, so that will need some calculation or add a custom indication into:
https://tools.ietf.org/html/rfc5438#section-11
To determin...Should not be difficult
The only difficulty is that the conversation is not specified, only the message-id, so that will need some calculation or add a custom indication into:
https://tools.ietf.org/html/rfc5438#section-11
To determine:
1. where to store the convID related
2. Who store the information for read-by (daemon, or we forward the signal to client?)Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/319swarm: relink read status (for messages)2021-06-12T11:37:10ZSébastien Blinswarm: relink read status (for messages)All is in the titleAll is in the titleSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/314Swarm: Test transmit messages for non connected peers2021-04-19T14:20:57ZSébastien BlinSwarm: Test transmit messages for non connected peers# Done
+ An account can add a member which is offline to a conversation. When the member is online, they should receives the request and be able to clone it.
+ Add test receives conversations request on loading account
+ Lot of unwanted...# Done
+ An account can add a member which is offline to a conversation. When the member is online, they should receives the request and be able to clone it.
+ Add test receives conversations request on loading account
+ Lot of unwanted packet for references discovery
+ An account should ask a request if a conversation is unknown (request missed) & add test
+ Test when loading account, a user should connect to peers and retrieve messages
+ Add test receives messages when already have conversation on loading account
+ Add test ping pong messages
+ Updates doc for application/im-gitmessage-id. Doc that conversation request is now a SIP message (for messageEngine mechanisms)
+ Between 2 computer: Something went wrong when cloning conversation: Couldn't clone repository
+ Try to clone on invalid hash 000000000000000...
+ Test conversation 100%Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/305Swarm: remove conversation2021-06-12T11:37:12ZSébastien BlinSwarm: remove conversationImplement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-conversationImplement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-conversationSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/302Swarm: Get conversations requests & sync2021-06-12T11:37:24ZSébastien BlinSwarm: Get conversations requests & synccf https://review.jami.net/c/ring-daemon/+/15748 and https://git.jami.net/savoirfairelinux/ring-project/wikis/technical/6.2.-Sync-Protocolcf https://review.jami.net/c/ring-daemon/+/15748 and https://git.jami.net/savoirfairelinux/ring-project/wikis/technical/6.2.-Sync-ProtocolSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/299Swarm: remove a user from the conversation2021-04-19T13:28:58ZSébastien BlinSwarm: remove a user from the conversation+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-device-from-a-conversation
+ Add tests+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-device-from-a-conversation
+ Add testsSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/298Swarm: Remove a device from the conversation2022-07-13T17:35:28ZSébastien BlinSwarm: Remove a device from the conversation+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-device-from-a-conversation
+ Add tests+ Implement https://git.jami.net/savoirfairelinux/ring-project/wikis/Group-chat-feature-(design-draft)#remove-a-device-from-a-conversation
+ Add testsSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/296Swarm: see for file transfers (NEEDS DESIGN)2021-06-12T11:37:07ZSébastien BlinSwarm: see for file transfers (NEEDS DESIGN)Swarm-chatSébastien BlinAdrien BéraudSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/295Swarm: add a test for sending a message to multiple participants at once2021-06-12T11:37:27ZSébastien BlinSwarm: add a test for sending a message to multiple participants at onceScenario:
Alice creates a conversation with 8 members
Then sends a messages
All devices should receives the whole conversationScenario:
Alice creates a conversation with 8 members
Then sends a messages
All devices should receives the whole conversationSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/294Swarm: default branch should not be "master" but "main"2021-02-19T17:12:18ZSébastien BlinSwarm: default branch should not be "master" but "main"Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/292Swarm: Fix build on jenkins2020-12-23T19:37:25ZSébastien BlinSwarm: Fix build on jenkinsPatches are not building for nowPatches are not building for nowSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/291Swarm: redo code for gitserver2021-04-19T14:20:32ZSébastien BlinSwarm: redo code for gitserverThis commit is ugly
# TODO
+ [x] Remove ioPool and only use callbacks
+ [x] Support shutdown
+ [ ] Multiple want and improve negotiation
+ [ ] Recheck answerToWantOrder();
+ [ ] Support depth request (https://github.com/git/git/blo...This commit is ugly
# TODO
+ [x] Remove ioPool and only use callbacks
+ [x] Support shutdown
+ [ ] Multiple want and improve negotiation
+ [ ] Recheck answerToWantOrder();
+ [ ] Support depth request (https://github.com/git/git/blob/master/Documentation/technical/pack-protocol.txt#L256)Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/205[Feature Request] Typing Indicators2020-12-22T20:03:07Ztrymeout[Feature Request] Typing IndicatorsNot an important feature, this exists in WhatsApp and Signal and when someone is typing a message it will send an indicator to the other peer(s) show that they are typing.
If this feature is added it should be optional for each conversa...Not an important feature, this exists in WhatsApp and Signal and when someone is typing a message it will send an indicator to the other peer(s) show that they are typing.
If this feature is added it should be optional for each conversation were it can be turned on/oof since some people will like more privacy and not have the other peer know when they are typing.Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/198Clone conversation through socket provided by the ConnectionManager2021-04-19T14:20:49ZSébastien BlinClone conversation through socket provided by the ConnectionManagerhttps://review.jami.net/c/ring-daemon/+/13304https://review.jami.net/c/ring-daemon/+/13304Swarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/197Add new conversation member and send invite2021-04-19T14:20:51ZSébastien BlinAdd new conversation member and send inviteSwarm-chatSébastien BlinSébastien Blinhttps://git.jami.net/savoirfairelinux/jami-daemon/-/issues/196Create initial commit of the conversation2021-04-19T14:20:53ZSébastien BlinCreate initial commit of the conversationhttps://review.jami.net/c/ring-daemon/+/13304https://review.jami.net/c/ring-daemon/+/13304Swarm-chatSébastien BlinSébastien Blin