From 16342e620b34c9db6862c6624368deb8dc48baa2 Mon Sep 17 00:00:00 2001
From: Emmanuel Lepage Vallee <emmanuel.lepage@savoirfairelinux.com>
Date: Tue, 5 May 2015 10:58:29 -0400
Subject: [PATCH] history: Notify client when a category is filled
* Remove some dead, commented code
Refs #72489
(cherry picked from commit ce0be45f71948dfb133b0cfffd315a2ad1095743)
---
src/categorizedhistorymodel.cpp | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/src/categorizedhistorymodel.cpp b/src/categorizedhistorymodel.cpp
index 8b60ace4..1f952916 100644
--- a/src/categorizedhistorymodel.cpp
+++ b/src/categorizedhistorymodel.cpp
@@ -300,40 +300,33 @@ void CategorizedHistoryModelPrivate::add(Call* call)
return;
}
-// if (!m_HavePersonModel && call->contactBackend()) {
-// connect(((QObject*)call->contactBackend()),SIGNAL(collectionChanged()),this,SLOT(reloadCategories()));
-// m_HavePersonModel = true;
-// }//TODO implement reordering
-
emit q_ptr->newHistoryCall(call);
HistoryTopLevelItem* tl = getCategory(call);
const QModelIndex& parentIdx = q_ptr->index(tl->modelRow,0);
+
q_ptr->beginInsertRows(parentIdx,tl->m_lChildren.size(),tl->m_lChildren.size());
CategorizedHistoryModelPrivate::HistoryItem* item = new CategorizedHistoryModelPrivate::HistoryItem(call);
item->m_pParent = tl;
item->m_pNode = new HistoryItemNode(q_ptr,call,item);
connect(item->m_pNode,SIGNAL(changed(QModelIndex)),this,SLOT(slotChanged(QModelIndex)));
- item->m_Index = tl->m_lChildren.size();
+ const int size = tl->m_lChildren.size();
+ item->m_Index = size;
tl->m_lChildren << item;
//Try to prevent startTimeStamp() collisions, it technically doesn't work as time_t are signed
//we don't care
m_sHistoryCalls[(call->startTimeStamp() << 10)+qrand()%1024] = call;
q_ptr->endInsertRows();
+
LastUsedNumberModel::instance()->addCall(call);
emit q_ptr->historyChanged();
- /*
- // Loop until it find a compatible backend
- //HACK only support a single active history backend
- if (!call->collection()) {
- foreach (CollectionInterface* backend, q_ptr->collections(CollectionInterface::ADD)) {
- if (backend->editor<Call>()->addNew(call)) {
- call->setCollection(backend);
- break;
- }
- }
- }*/
+ //When the categories goes from 0 items to many, its conceptual state change
+ //therefore the clients may want to act on this, notify them
+ if (!size) {
+ const QModelIndex idx = q_ptr->index(item->m_Index,0);
+ emit q_ptr->dataChanged(idx,idx);
+ }
}
///Set if the history has a limit
--
GitLab