From 1b7de38d16eb16fb4f8f7f4977ef49bb32391188 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Blin?=
<sebastien.blin@savoirfairelinux.com>
Date: Tue, 1 Sep 2020 13:46:53 -0400
Subject: [PATCH] Revert "plugin:add editable preference"
This reverts commit dfeaa87049dfd8b09106df37c0a24171c00f4746.
Change-Id: Iaeb7cc7507a53f5336fc204ba937ad55eb8f93b2
---
src/api/pluginmodel.h | 11 +----------
src/pluginmodel.cpp | 8 --------
src/qtwrapper/pluginmanager.cpp | 10 ----------
src/qtwrapper/pluginmanager_wrap.h | 4 ----
4 files changed, 1 insertion(+), 32 deletions(-)
diff --git a/src/api/pluginmodel.h b/src/api/pluginmodel.h
index 27b6eb6b..bf99c87f 100644
--- a/src/api/pluginmodel.h
+++ b/src/api/pluginmodel.h
@@ -158,19 +158,10 @@ public:
Q_INVOKABLE MapStringString getPluginPreferencesValues(const QString& path);
/**
- * Reset preferences values of installed plugin to default values
+ * Reste preferences values of installed plugin to default values
* @return true if preference was succesfully reset
*/
Q_INVOKABLE bool resetPluginPreferencesValues(const QString& path);
-
- /**
- * Add a possible value to a preference that can be edited by the user
- * the only possibility at the moment is USERLIST option
- * @return if addition was successfull
- */
- Q_INVOKABLE bool addValueToPreference(const QString& pluginId,
- const QString& preferenceKey,
- const QString& value);
};
} // namespace api
diff --git a/src/pluginmodel.cpp b/src/pluginmodel.cpp
index 07d500a1..f02fe6a3 100644
--- a/src/pluginmodel.cpp
+++ b/src/pluginmodel.cpp
@@ -187,14 +187,6 @@ PluginModel::resetPluginPreferencesValues(const QString& path)
return PluginManager::instance().resetPluginPreferencesValues(path);
}
-bool
-PluginModel::addValueToPreference(const QString& pluginId,
- const QString& preferenceKey,
- const QString& value)
-{
- return PluginManager::instance().addValueToPreference(pluginId, preferenceKey, value);
-}
-
} // namespace lrc
#include "api/moc_pluginmodel.cpp"
diff --git a/src/qtwrapper/pluginmanager.cpp b/src/qtwrapper/pluginmanager.cpp
index 51b62084..51ff960c 100644
--- a/src/qtwrapper/pluginmanager.cpp
+++ b/src/qtwrapper/pluginmanager.cpp
@@ -124,13 +124,3 @@ PluginManagerInterface::resetPluginPreferencesValues(const QString& path)
{
return DRing::resetPluginPreferencesValues(path.toStdString());
}
-
-bool
-PluginManagerInterface::addValueToPreference(const QString& pluginId,
- const QString& preferenceKey,
- const QString& value)
-{
- return DRing::addValueToPreference(pluginId.toStdString(),
- preferenceKey.toStdString(),
- value.toStdString());
-}
diff --git a/src/qtwrapper/pluginmanager_wrap.h b/src/qtwrapper/pluginmanager_wrap.h
index f1ee3b82..e0a75512 100644
--- a/src/qtwrapper/pluginmanager_wrap.h
+++ b/src/qtwrapper/pluginmanager_wrap.h
@@ -79,10 +79,6 @@ public Q_SLOTS: // METHODS
MapStringString getPluginPreferencesValues(const QString& path);
bool resetPluginPreferencesValues(const QString& path);
-
- bool addValueToPreference(const QString& pluginId,
- const QString& preferenceKey,
- const QString& value);
};
namespace org {
--
GitLab