From 225f8db98682b08da354c600fbc7ebb91fb3f890 Mon Sep 17 00:00:00 2001
From: Ming Rui Zhang <mingrui.zhang@savoirfairelinux.com>
Date: Thu, 20 Feb 2020 16:46:44 -0500
Subject: [PATCH] script: use subprocess returncode in make-lrc.py
Change-Id: I02c5a10602bea7ffde76b67b302bbab3ed2551f3
---
make-lrc.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/make-lrc.py b/make-lrc.py
index 5fee3cb1..d7b6c7ae 100644
--- a/make-lrc.py
+++ b/make-lrc.py
@@ -97,8 +97,8 @@ def build_project(msbuild, msbuild_args, proj, env_vars):
p = subprocess.Popen(cmd, shell=True,
stdout=sys.stdout,
env=env_vars)
- _, perr = p.communicate()
- if perr:
+ _, _ = p.communicate()
+ if p.returncode:
print("Build failed when building ", proj)
sys.exit(1)
@@ -151,8 +151,8 @@ def generate(force, qtver, sdk, toolset, arch):
cmd.extend(cmake_options)
p = subprocess.Popen(cmd, shell=True,
stdout=subprocess.PIPE)
- _, perr = p.communicate()
- if perr:
+ _, _ = p.communicate()
+ if p.returncode:
print("Couldn't generate!")
sys.exit(1)
--
GitLab