From 30c2d77088e916cc7fdac6e89f85b305816f121d Mon Sep 17 00:00:00 2001
From: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>
Date: Tue, 4 Oct 2016 18:36:55 -0400
Subject: [PATCH] Call: don't listen to unreadMessageCountChanged
There doesn't seem to be a need for the Call to be updated (and
thus emit a changed signal) when the unread message count changes
in the peer ContatMethod. Otherwise all calls (current and history)
will keep getting updated with this signal.
Change-Id: I2f464ef39fe4e48f2b52c441a3f18ccb4b9a419f
Tuleap: #1076
---
src/call.cpp | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/call.cpp b/src/call.cpp
index 84006267..43505cf1 100644
--- a/src/call.cpp
+++ b/src/call.cpp
@@ -317,8 +317,6 @@ Call::Call(Call::State startState, const QString& peerName, ContactMethod* numbe
d_ptr->m_Account = account;
d_ptr->m_PeerName = peerName;
d_ptr->m_pPeerContactMethod = number;
- if (number)
- connect(number, &ContactMethod::unreadTextMessageCountChanged, d_ptr, &CallPrivate::updated);
d_ptr->m_pParentCall = nullptr;
emit changed();
@@ -1196,7 +1194,6 @@ void Call::setPeerContactMethod(ContactMethod* cm)
return;
}
d_ptr->m_pPeerContactMethod = cm;
- connect(cm, &ContactMethod::unreadTextMessageCountChanged, d_ptr, &CallPrivate::updated);
setDialNumber(cm->uri());
}
@@ -1347,7 +1344,6 @@ Call::State CallPrivate::stateChanged(const QString& newStateName)
if (q_ptr->lifeCycleState() != Call::LifeCycleState::CREATION && m_pDialNumber) {
if (!m_pPeerContactMethod) {
m_pPeerContactMethod = PhoneDirectoryModel::instance().fromTemporary(m_pDialNumber);
- connect(m_pPeerContactMethod, &ContactMethod::unreadTextMessageCountChanged, this, &CallPrivate::updated);
}
m_pDialNumber->deleteLater();
m_pDialNumber = nullptr;
@@ -1782,7 +1778,6 @@ void CallPrivate::call()
URI uri {peerCM->uri()};
if (!m_pPeerContactMethod) {
m_pPeerContactMethod = PhoneDirectoryModel::instance().getNumber(uri, q_ptr->account());
- connect(m_pPeerContactMethod, &ContactMethod::unreadTextMessageCountChanged, this, &CallPrivate::updated);
}
// m_pDialNumber is now discarded
@@ -1899,7 +1894,6 @@ void CallPrivate::start()
if (m_pDialNumber) {
if (!m_pPeerContactMethod) {
m_pPeerContactMethod = PhoneDirectoryModel::instance().fromTemporary(m_pDialNumber);
- connect(m_pPeerContactMethod, &ContactMethod::unreadTextMessageCountChanged, this, &CallPrivate::updated);
}
m_pDialNumber->deleteLater();
m_pDialNumber = nullptr;
--
GitLab