From 69d6961e0041c7d842712d8628a3bde2c80e5778 Mon Sep 17 00:00:00 2001 From: Amin Bandali <amin.bandali@savoirfairelinux.com> Date: Mon, 23 Nov 2020 10:38:50 -0500 Subject: [PATCH] chatview: add bidi support to input textarea and text messages Simply set dir="auto" on the input textarea and textual messages, which tells WebKit to do the right thing when encountering bidirectional text. Fixes display of messages in RTL languages like Persian and Arabic. Change-Id: I8742f792022d16e8da08e54f351c0b9462d19cd3 --- src/web-chatview/chatview.html | 2 +- src/web-chatview/chatview.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/web-chatview/chatview.html b/src/web-chatview/chatview.html index e644ca41..a51fe07c 100644 --- a/src/web-chatview/chatview.html +++ b/src/web-chatview/chatview.html @@ -113,7 +113,7 @@ </svg> </div> <textarea id="message" autofocus placeholder="Type a message" onkeyup="grow_text_area()" onkeydown="process_messagebar_keydown()" - rows="1"></textarea> + dir="auto" rows="1"></textarea> <div id="sendButton" class="nav-button action-button" onclick="sendMessage();"> <svg class="svgicon" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"> <path d="M2.01 21L23 12 2.01 3 2 10l15 2-15 2z" /> diff --git a/src/web-chatview/chatview.js b/src/web-chatview/chatview.js index 591f1c40..9744ca8e 100644 --- a/src/web-chatview/chatview.js +++ b/src/web-chatview/chatview.js @@ -1375,6 +1375,7 @@ function textInteraction(message_id, message_direction, htmlText) { message_wrapper.setAttribute("class", "message_wrapper") var message_text = document.createElement("div") message_text.setAttribute("class", "message_text") + message_text.setAttribute("dir", "auto"); message_text.innerHTML = htmlText message_wrapper.appendChild(message_text) // TODO STATUS -- GitLab